VOOZH about

URL: https://bugs.launchpad.net/ubuntu/+source/indicator-session/+bug/1642989

⇱ Bug #1642989 “indicators should use 'com.canonical.indicators.li...” : Bugs : indicator-session package : Ubuntu


indicators should use 'com.canonical.indicators.link' type for Settings links

Bug #1642989 reported by Charles Kerr
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
indicator-bluetooth (Ubuntu)
New
Undecided
Unassigned
indicator-datetime (Ubuntu)
New
Undecided
Unassigned
indicator-location (Ubuntu)
New
Undecided
Unassigned
indicator-network (Ubuntu)
Triaged
Medium
Unassigned
indicator-power (Ubuntu)
New
Undecided
Unassigned
indicator-session (Ubuntu)
Triaged
Medium
Unassigned
indicator-sound (Ubuntu)
New
Undecided
Unassigned

Bug Description

http://bazaar.launchpad.net/~unity-team/unity8/trunk/view/head:/qml/Panel/Indicators/MenuItemFactory.qml has this code:

> if (modelData.action !== undefined && modelData.action.indexOf("settings") > -1) {
> // FIXME : At the moment, the indicators aren't using
> // com.canonical.indicators.link for settings menu. Need to fudge it.
> return linkMenu;
> }

We should set the type of settings menuitems to 'com.canonical.indicators.link' so that this hack can be removed.

Related branches

lp:~pete-woods/indicator-network/use-correct-settings-item-lp1642989
dobey (community): Needs Fixing
unity-api-1-bot: Approve (continuous-integration)
Diff: 403 lines (+52/-98)
8 files modified
src/indicator/CMakeLists.txt (+1/-1)
src/indicator/menuitems/settings-item.cpp (+23/-13)
src/indicator/menuitems/settings-item.h (+16/-20)
src/indicator/menuitems/wifi-link-item.cpp (+0/-13)
src/indicator/sections/ethernet-section.cpp (+3/-3)
src/indicator/sections/vpn-section.cpp (+3/-17)
src/indicator/sections/wifi-section.cpp (+3/-14)
src/indicator/sections/wwan-section.cpp (+3/-17)
api
Pete Woods (pete-woods)
Changed in indicator-network (Ubuntu):
status: New → Triaged
importance: Undecided → Medium
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.