VOOZH about

URL: https://bugzilla.mozilla.org/show_bug.cgi?id=1055676

⇱ 1055676 - (ruby-align) implement CSS 'ruby-align' property

Closed Bug 1055676 (ruby-align) Opened 11 years ago Closed 11 years ago

implement CSS 'ruby-align' property

implement CSS 'ruby-align' property
Core
Layout: Block and Inline
Trunk
All
All
defect
Not set
normal
Points:
---
RESOLVED FIXED
RESOLVED
FIXED
mozilla38
Iteration:
---
a11y-review
Accessibility Severity
Performance Impact
Size Estimate
Webcompat Priority
Webcompat Score
Tracking Status
firefox38 --- fixed
Tracking Status
firefox38
relnote-firefox
thunderbird_esr115
thunderbird_esr140
thunderbird_esr153
firefox-esr115
firefox-esr140
firefox-esr153
firefox152
firefox153
firefox154
ruby-align
QA Whiteboard:
---
Has STR:
---
Change Request:
---
Signature:
None
This bug is publicly visible. 

 












 
 

 

 
 
 
 
13.73 KB,
 patch 

 		
 
 
heycam

:
 
 review+
 

 
 Details
 | Diff |
 Splinter Review
 

 

 
 
 
 
5.53 KB,
 patch 

 		
 
 
roc

:
 
 review+
 

 
 Details
 | Diff |
 Splinter Review
 

 

 
 
 
 
8.86 KB,
 patch 

 		
 
 
roc

:
 
 review+
 

 
 Details
 | Diff |
 Splinter Review
 

 

 
 
 
 
4.19 KB,
 patch 

 		
 
 
roc

:
 
 review+
 

 
 Details
 | Diff |
 Splinter Review
 

 

 
 
 
 
5.51 KB,
 patch 

 		
 
 
roc

:
 
 review+
 

 
 Details
 | Diff |
 Splinter Review
 





 
















I'm filing this as a bug on implementing the CSS ruby-align property:
http://dev.w3.org/csswg/css-ruby/#ruby-align-property

I think we probably don't need to do this in order to ship CSS Ruby, although I'm willing to entertain arguments to the contrary.
Assignee: nobody → quanxunzhen
Status: NEW → ASSIGNED
I'm going to implement the actually alignment inside PropertyProvider of nsTextFrame. The reason is that we have to expand spacing of characters instead of only the width of frames, so that the continuity of selection can be kept.
Blocks: enable-css-ruby
No longer blocks: css-ruby
Depends on: 1063857, 1055665
I'm going to merge nsRuby{Base,Text}Frame to one super class, as behaviors of them are mostly identical in the given box model. What do you think is the proper name for that class? Maybe nsRubyContentFrame or something?
Flags: needinfo?(dbaron)
It might make sense to use nsRubyTextFrame as the common name, although I'd be ok with nsRubyContentFrame.
Flags: needinfo?(dbaron)
Blocks: 1081770
Depends on: 1107721
Depends on: 1108429
Blocks: css-ruby
No longer blocks: enable-css-ruby
No longer depends on: 1107721
No longer blocks: 1081770
We probably need to implement this before implementing inter-character ruby.

 
 
 
 
 


 

 Attachment #8564796 -
 Flags: review?(roc)
Comment on attachment 8564792 [details] [diff] [review]
patch 1 - Parse and compute ruby-align

Review of attachment 8564792 [details] [diff] [review]:
-----------------------------------------------------------------

Better get someone else to review style system patches :-)

 Attachment #8564792 -
 Flags: review?(roc) → review?(cam)
Comment on attachment 8564792 [details] [diff] [review]
patch 1 - Parse and compute ruby-align

Review of attachment 8564792 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/style/nsComputedDOMStyle.cpp
@@ +3077,5 @@
> 
> CSSValue*
> +nsComputedDOMStyle::DoGetRubyAlign()
> +{
> + nsROCSSPrimitiveValue *val = new nsROCSSPrimitiveValue;

"*" next to type please.

 Attachment #8564792 -
 Flags: review?(cam) → review+
Blocks: 1133624

 You need to log in
 before you can comment on or make changes to this bug.