Closed
Bug 1096378
Opened 11 years ago
Closed 11 years ago
Don't allow duplicate parameter names in concise method definitions
Don't allow duplicate parameter names in concise method definitions
| Tracking | Status | |
|---|---|---|
| firefox38 | --- | fixed |
---
---
QA Whiteboard:
---
Has STR:
---
Change Request:
---
0
Bug Flags:
|
1.61 KB,
patch
|
jorendorff
:
review+
|
Details | Diff | Splinter Review |
| Reporter | |
Descriptionβ’11 years ago
|
Test case:
---
({m(a, a){}})
---
Expected: SyntaxError is thrown
Actual: No SyntaxError
Concise method definition parameters use the 'StrictFormalParameters' grammar production [1] which disallows duplicate parameter names [2].
[1] https://people.mozilla.org/~jorendorff/es6-draft.html#sec-method-definitions
[2] https://people.mozilla.org/~jorendorff/es6-draft.html#sec-function-definitions-static-semantics-early-errors
| Assignee | |
Comment 1β’11 years ago
|
applied after the patch in bug 1096376 and bug 1096377.
Already passed the try (same as bug 1096376):
https://treeherder.mozilla.org/#/jobs?repo=try&revision=91855352a697
Attachment #8553309 -
Flags: review?(jorendorff)
Updatedβ’11 years ago
|
Attachment #8553309 -
Flags: review?(jorendorff) β review+
| Assignee | |
Comment 2β’11 years ago
|
Comment 3β’11 years ago
|
Assignee: nobody β arai_a
Status: NEW β RESOLVED
Closed: 11 years ago
status-firefox38:
--- β fixed
Flags: in-testsuite+
Resolution: --- β FIXED
Target Milestone: --- β mozilla38
Comment 4β’11 years ago
|
Keywords: dev-doc-complete,
site-compat
You need to log in
before you can comment on or make changes to this bug.
