[webvtt] support multi-line region parsing.

👁 Image	Benjamin Chen [:bechen] Assignee
	Description • 8 years ago

https://www.w3.org/TR/webvtt1/#introduction-other-features example 10: REGION id:fred width:40% lines:3 regionanchor:0%,100% viewportanchor:10%,90% scroll:up ... Now our parser only support only one line parsing.

👁 Image	Blake Wu [:bwu][:blakewu]
	Updated • 8 years ago

👁 Image	Benjamin Chen [:bechen] Assignee
	Comment 1 • 8 years ago
mozreview-request

Comment hidden (mozreview-request)

Review commit: https://reviewboard.mozilla.org/r/199020/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/199020/

👁 Image	Benjamin Chen [:bechen] Assignee
	Comment 2 • 8 years ago
mozreview-request

Comment hidden (mozreview-request)

Review commit: https://reviewboard.mozilla.org/r/199022/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/199022/

👁 Image	Alastor Wu [:alwu]
	Comment 3 • 8 years ago
mozreview-review

Comment on attachment 8927752 [details] Bug 1415821 - Modify .vtt REGION syntax. https://reviewboard.mozilla.org/r/199022/#review204082

👁 Image	Alastor Wu [:alwu]
	Comment 4 • 8 years ago

Per offline discussion, will review the patch again after passing tests.

👁 Image	Benjamin Chen [:bechen] Assignee
	Comment 5 • 8 years ago
mozreview-request

Comment hidden (mozreview-request)

Comment on attachment 8927751 [details] Bug 1415821 - Support multi-line parsing for REGION/STYLE block. Review request updated; see interdiff: https://reviewboard.mozilla.org/r/199020/diff/1-2/

👁 Image	Benjamin Chen [:bechen] Assignee
	Comment 6 • 8 years ago
mozreview-request

Comment hidden (mozreview-request)

Comment on attachment 8927752 [details] Bug 1415821 - Modify .vtt REGION syntax. Review request updated; see interdiff: https://reviewboard.mozilla.org/r/199022/diff/1-2/

👁 Image	Benjamin Chen [:bechen] Assignee
	Comment 7 • 8 years ago
mozreview-request

Comment hidden (mozreview-request)

Review commit: https://reviewboard.mozilla.org/r/199636/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/199636/

👁 Image	Benjamin Chen [:bechen] Assignee
	Comment 8 • 8 years ago
mozreview-request

Comment hidden (mozreview-request)

Comment on attachment 8927752 [details] Bug 1415821 - Modify .vtt REGION syntax. Review request updated; see interdiff: https://reviewboard.mozilla.org/r/199022/diff/2-3/

👁 Image	Benjamin Chen [:bechen] Assignee
	Comment 9 • 8 years ago
mozreview-request

Comment hidden (mozreview-request)

Comment on attachment 8927751 [details] Bug 1415821 - Support multi-line parsing for REGION/STYLE block. Review request updated; see interdiff: https://reviewboard.mozilla.org/r/199020/diff/2-3/

👁 Image	Alastor Wu [:alwu]
	Comment 10 • 8 years ago
mozreview-review

Comment on attachment 8927751 [details] Bug 1415821 - Support multi-line parsing for REGION/STYLE block. https://reviewboard.mozilla.org/r/199020/#review204786

👁 Image	Alastor Wu [:alwu]
	Comment 11 • 8 years ago
mozreview-review

Comment on attachment 8928412 [details] Bug 1415821 - Correct the behavior for BADCUE state. https://reviewboard.mozilla.org/r/199636/#review204788 ::: dom/media/webvtt/vtt.jsm:1360 (Diff revision 1) > } > > var nextIteration = false; > while (nextIteration || self.buffer) { > nextIteration = false; > - if (!line) { > + if (self.state == "BADCUE") { Per offline discussed, should handle "BADCUE" in the following switch statement.

👁 Image	Benjamin Chen [:bechen] Assignee
	Comment 12 • 8 years ago
mozreview-request

Comment hidden (mozreview-request)

Comment on attachment 8928412 [details] Bug 1415821 - Correct the behavior for BADCUE state. Review request updated; see interdiff: https://reviewboard.mozilla.org/r/199636/diff/1-2/

👁 Image	Alastor Wu [:alwu]
	Comment 13 • 8 years ago
mozreview-review

Comment on attachment 8928412 [details] Bug 1415821 - Correct the behavior for BADCUE state. https://reviewboard.mozilla.org/r/199636/#review204958

👁 Image	Benjamin Chen [:bechen] Assignee
	Updated • 8 years ago

👁 Image	Pulsebot
	Comment 14 • 8 years ago

Pushed by rgurzau@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0f276f1cc275 Modify .vtt REGION syntax. r=alwu https://hg.mozilla.org/integration/autoland/rev/1786297a20df Support multi-line parsing for REGION/STYLE block. r=alwu https://hg.mozilla.org/integration/autoland/rev/5a9fbe6806cf Correct the behavior for BADCUE state. r=alwu

👁 Image	Andrei Ciure[:aciure]
	Comment 15 • 8 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/0f276f1cc275 https://hg.mozilla.org/mozilla-central/rev/1786297a20df https://hg.mozilla.org/mozilla-central/rev/5a9fbe6806cf

👁 Image	Eric Shepherd [:sheppy]
	Updated • 8 years ago

👁 Image	Eric Shepherd [:sheppy]
	Comment 16 • 8 years ago

Firefox 59 for developers now notes this change.