Implement iterator includes proposal

👁 Image	Dan Minor [:dminor] Assignee
	Description • 2 months ago

This should be fairly easily implementable, this seems to be equivalent to using Iterator.prototype.some, e.g. .some(e => e === searchElement), except for the skipped elements part, which could be done using Iterator.prototype.take.

Bug 2003345 has an example of how to add an empty placeholder method to iterator. I suspect the implementation can be done using IteratorSome and IteratorTake in Iterator.js as examples, most likely by calling them directly.

👁 Image	Matthew Gaudet (he/him) [:mgaudet]
	Updated • 2 months ago

👁 Image	Dan Minor [:dminor] Assignee
	Updated • 2 months ago

👁 Image	Ruth John
	Updated • 1 month ago

👁 Image	Dan Minor [:dminor] Assignee
	Comment 1 • 1 month ago

👁 Image	Dan Minor [:dminor] Assignee
	Comment 2 • 1 month ago

👁 Image	Dan Minor [:dminor] Assignee
	Comment 3 • 1 month ago

👁 Image	Dan Minor [:dminor] Assignee
	Comment 4 • 1 month ago

These are from https://github.com/tc39/test262/pull/5031 which is
currently under review. Once the tests land upstream, these can be
removed. This will be handled as part of shipping the feature when
it reaches Stage 3.

👁 Image	Pulsebot
	Comment 5 • 1 month ago

Pushed by dminor@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/94ea010a5377 https://hg.mozilla.org/integration/autoland/rev/c7e5a9607447 Add pref for Iterator Includes; r=arai https://github.com/mozilla-firefox/firefox/commit/0bb419a49a6b https://hg.mozilla.org/integration/autoland/rev/81c4ad74dc82 Implement Iterator Includes; r=arai https://github.com/mozilla-firefox/firefox/commit/8d8499371150 https://hg.mozilla.org/integration/autoland/rev/6d64532cce7f Update test262-update.py; r=arai https://github.com/mozilla-firefox/firefox/commit/fec9c4047b54 https://hg.mozilla.org/integration/autoland/rev/3b83144474b1 Import Iterator Includes tests; r=arai

👁 Image	Silaghi Andreea
	Comment 6 • 1 month ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/c7e5a9607447
https://hg.mozilla.org/mozilla-central/rev/81c4ad74dc82
https://hg.mozilla.org/mozilla-central/rev/6d64532cce7f
https://hg.mozilla.org/mozilla-central/rev/3b83144474b1

👁 Image	Mihai Boldan, Desktop QA [:mboldan]
	Updated • 27 days ago

👁 Image	Hamish Willee
	Comment 7 • 22 days ago • Edited

FF152 MDN docs work for can be tracked in https://github.com/mdn/content/issues/44158 (in review)

👁 Image	Hamish Willee
	Updated • 22 days ago