[XHR2] Allow setting XHR responseType and withCredentials before open

👁 Image	Masatoshi Kimura [:emk] Reporter
	Description • 14 years ago

The latest XHR2 spec allows setting responseType and withCredentials in UNSENT or OPENED state.

👁 Image	Masatoshi Kimura [:emk] Reporter
	Updated • 14 years ago

👁 Image	Tillmann Karras
	Comment 1 • 13 years ago

👁 Image	Jonas Sicking (:sicking) No longer reading bugmail consistently
	Comment 2 • 13 years ago

Comment on attachment 707601 [details] [diff] [review] Allow setting XHR.responseType before open() Review of attachment 707601 [details] [diff] [review]: ----------------------------------------------------------------- r=me if you also add a test.

👁 Image	Tillmann Karras
	Comment 3 • 13 years ago

HRs were not asynchronous by default. I also added a test.

👁 Image	Jonas Sicking (:sicking) No longer reading bugmail consistently
	Comment 4 • 13 years ago

Comment on attachment 708091 [details] [diff] [review] Allow setting XHR.responseType before open() Review of attachment 708091 [details] [diff] [review]: ----------------------------------------------------------------- r=me with that fixed. ::: content/base/test/test_XHR.html @@ +90,5 @@ > try { xhr.responseXML } catch (e) { didthrow = true; } > ok(didthrow, "should have thrown when accessing responseXML"); > } > +function checkSetResponseTypeThrows(xhr, type, shouldThrow) { > + var shouldThrow = shouldThrow === undefined ? true : shouldThrow; shouldThrow = !!shouldThrow; @@ +101,3 @@ > } > +function checkOpenThrows(xhr, method, url, async, shouldThrow) { > + var shouldThrow = shouldThrow === undefined ? true : shouldThrow; Same @@ +118,5 @@ > +checkSetResponseTypeThrows(xhr, "moz-chunked-text", false); > +checkSetResponseTypeThrows(xhr, "moz-chunked-arraybuffer", false); > +checkOpenThrows(xhr, "GET", "file_XHR_pass2.txt", false, true); > +checkSetResponseTypeThrows(xhr, "", false); > +checkOpenThrows(xhr, "GET", "file_XHR_pass2.txt", false, false); Also add a test that checks that setting the reponseType to something before calling .open() actually works. I.e. that it interprets the response according to the set responseType.

👁 Image	Masatoshi Kimura [:emk] Reporter
	Comment 5 • 13 years ago

Is it safe to change .responseType in HEADER_RECEIVED state?

👁 Image	Jonas Sicking (:sicking) No longer reading bugmail consistently
	Comment 6 • 12 years ago

yup, that should already work fine.

👁 Image	Hallvord R. M. Steen [:hallvors]
	Comment 7 • 12 years ago

Setting responseType throws an unexpected error in these test cases: http://w3c-test.org/web-platform-tests/master/XMLHttpRequest/open-method-responsetype-set-sync.htm http://w3c-test.org/web-platform-tests/master/XMLHttpRequest/response-json.htm http://w3c-test.org/web-platform-tests/master/XMLHttpRequest/responsexml-non-document-types.htm I'm going to assume this bug is the reason.

👁 Image	Hallvord R. M. Steen [:hallvors]
	Comment 8 • 12 years ago

Here's a withCredentials test case: http://w3c-test.org/web-platform-tests/master/XMLHttpRequest/withcredentials-set.htm

👁 Image	Hallvord R. M. Steen [:hallvors]
	Updated • 12 years ago

👁 Image	Masatoshi Kimura [:emk] Reporter
	Comment 9 • 12 years ago

Tillmann, could you post a new patch with review comments resolved?

👁 Image	:Ms2ger (he/him; ⌚ UTC+1/+2) Assignee
	Comment 10 • 11 years ago

👁 Image	:Ms2ger (he/him; ⌚ UTC+1/+2) Assignee
	Comment 11 • 11 years ago

👁 Image	:Ms2ger (he/him; ⌚ UTC+1/+2) Assignee
	Comment 12 • 11 years ago

👁 Image	:Ms2ger (he/him; ⌚ UTC+1/+2) Assignee
	Updated • 11 years ago

👁 Image	:Ms2ger (he/him; ⌚ UTC+1/+2) Assignee
	Comment 13 • 11 years ago

This is Tillmann's patch rebased to trunk. I removed the > checkSetResponseTypeThrows(xhr, "", false); > checkOpenThrows(xhr, "GET", "file_XHR_pass2.txt", false, false); bit from the test; it's already covered by the wpt tests. I left the rest in because it also tests proprietary values that the wpt tests can't.

👁 Image	Jean-Yves Perrier [:teoli]
	Updated • 11 years ago

👁 Image	Olli Pettay [:smaug][bugs@pettay.fi]
	Updated • 11 years ago

👁 Image	:Ms2ger (he/him; ⌚ UTC+1/+2) Assignee
	Comment 14 • 11 years ago

👁 Image	Carsten Book [:Tomcat]
	Comment 15 • 11 years ago

👁 Image	:Ms2ger (he/him; ⌚ UTC+1/+2) Assignee
	Comment 16 • 11 years ago

Tillmann, thanks for the patch!