Bookmarks and History - should respect the "When you open a link, image or media in a new tab, switch to it immediately" setting

👁 Image	Nikki Sharpley (:nikkis) (she/her) Reporter
	Description • 2 months ago • Edited

For Sidebar Bookmarks and History - have Open in New Tab context menu item open the link in the new background tab by default and respect the When you open a link, image or media in a new tab, switch to it immediately setting (if it's ON, the links should open in the new foreground tab). The setting is reflected by the browser.tabs.loadInBackground pref.

👁 Image	Jira Integration Bot
	Updated • 2 months ago

👁 Image	konyhéa
	Comment 1 • 2 months ago

Hii :nikki, noticed this hasn't been assigned to anyone, can i pick it up?

👁 Image	Nikki Sharpley (:nikkis) (she/her) Reporter
	Comment 2 • 2 months ago

:konyhèa, unfortunately I did talk to another candidate yesterday about picking this up. But thank you!

👁 Image	Jak Assignee
	Comment 3 • 2 months ago

"Patch to respect browser.tabs.loadInBackground when opening history links from sidebar"

👁 Image	Jak Assignee
	Comment 4 • 2 months ago

" PATCH to Respect browser.tabs.loadInBackground when opening history links from the side bar"

👁 Image	Nikki Sharpley (:nikkis) (she/her) Reporter
	Comment 5 • 2 months ago

Hi Jak,

As I mentioned before, you'll need to submit your patch using moz-phab. You can find a step by step here. I'm unable to review it otherwise.

Thanks!

👁 Image	Jak Assignee
	Comment 6 • 2 months ago

👁 Image	Nikki Sharpley (:nikkis) (she/her) Reporter
	Updated • 2 months ago

👁 Image	aoia7rz7l
	Comment 7 • 2 months ago

(In reply to Nikki Sharpley (:nikkis) (she/her) from comment #0)

For Sidebar Bookmarks and History

The setting is reflected by the browser.tabs.loadInBackground pref.

FWIW this has always been controlled by browser.tabs.loadBookmarksInBackground in both the library and the old sidebar.

👁 Image	Kelly Cochrane [:kcochrane]
	Updated • 1 month ago

👁 Image	Jak Assignee
	Comment 9 • 1 month ago

👁 Image	Phabricator Automation
	Updated • 1 month ago

👁 Image	Pulsebot
	Comment 10 • 1 month ago

Pushed by nsharpley@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/9743a3ddbf16 https://hg.mozilla.org/integration/autoland/rev/3f46a50c43e5 Respect browser.tabs.loadInBackground when opening history in sidebar r=nsharpley

👁 Image	Silaghi Andreea
	Comment 11 • 1 month ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/3f46a50c43e5

👁 Image	Mihai Boldan, Desktop QA [:mboldan]
	Updated • 27 days ago