Fix a ruff warning in js/src/frontend/align_stack_comment.py

👁 Image	Sylvestre Ledru [:Sylvestre] Reporter
	Description • 2 months ago

Filing as a good first bug to learn workflows.

js/src/frontend/align_stack_comment.py
 41:13 warning `for` loop variable `line` overwritten by assignment target PLW2901 (ruff)

Link to the code:
https://searchfox.org/mozilla-central/source/js/src/frontend/align_stack_comment.py#41

To run the linter:

./mach lint -W -l ruff js/src/frontend/align_stack_comment.py

As the change is trivial, it is just to learn how to contribute to Firefox.

Tutorial to contribute:
https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html
https://firefox-source-docs.mozilla.org/contributing/stack_quickref.html

Please don't ask for the bug to be assigned. It will be automatically assigned to the first patch.

👁 Image	Sylvestre Ledru [:Sylvestre] Reporter
	Updated • 2 months ago

👁 Image	vyofgod Assignee
	Comment 1 • 1 month ago

👁 Image	Phabricator Automation
	Updated • 1 month ago

👁 Image	Pulsebot
	Comment 2 • 1 month ago

Pushed by arai_a@mac.com: https://github.com/mozilla-firefox/firefox/commit/22e548652af6 https://hg.mozilla.org/integration/autoland/rev/2ff65b4325d7 Fix ruff PLW2901 by not overwriting loop variable in align_stack_comment.py. r=arai

👁 Image	Cosmin Sabou [:CosminS]
	Comment 3 • 1 month ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/2ff65b4325d7