Fix a clippy warning in toolkit/components/gecko-trace/src/collector.rs

👁 Image	Sylvestre Ledru [:Sylvestre] Reporter
	Description • 2 months ago

Filing as a good first bug to learn workflows.

toolkit/components/gecko-trace/src/collector.rs
 119:9 warning you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` clippy::single_match (clippy)

Link to the code:
https://searchfox.org/mozilla-central/source/toolkit/components/gecko-trace/src/collector.rs#119

To run the linter:

./mach lint -W -l clippy toolkit/components/gecko-trace/src/collector.rs

As the change is trivial, it is just to learn how to contribute to Firefox.

Tutorial to contribute:
https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html
https://firefox-source-docs.mozilla.org/contributing/stack_quickref.html

Please don't ask for the bug to be assigned. It will be automatically assigned to the first patch.

👁 Image	vyofgod Assignee
	Comment 1 • 1 month ago

👁 Image	Phabricator Automation
	Updated • 1 month ago

👁 Image	BugBot [:suhaib / :marco/ :calixte]
	Comment 2 • 1 month ago

There is an r+ patch which didn't land and no activity in this bug for 2 weeks.
:ffhpno1, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit BugBot documentation.

👁 Image	Greg Stoll :gstoll
	Comment 3 • 1 month ago

I'll go ahead and land this. Thanks :vyofgod!

👁 Image	Pulsebot
	Comment 4 • 1 month ago

Pushed by gstoll@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/e3c5423c4f29 https://hg.mozilla.org/integration/autoland/rev/26a1725e5b7b Replace match with if let for single pattern in collector.rs. r=gstoll

👁 Image	Serban Stanca [:SerbanS]
	Comment 5 • 1 month ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/26a1725e5b7b