VOOZH about

URL: https://bugzilla.mozilla.org/2031599

⇱ 2031599 - Fix browsingContext.sys.mjs to assign to #contextCreatedHandled instead of contextCreatedHandled


Closed Bug 2031599 Opened 2 months ago Closed 1 month ago

Fix browsingContext.sys.mjs to assign to #contextCreatedHandled instead of contextCreatedHandled

Fix browsingContext.sys.mjs to assign to #contextCreatedHandled instead of contextCreatedHandled
Remote Protocol
Agent
unspecified
Unspecified
Unspecified
task
Points:
---
RESOLVED FIXED
RESOLVED
FIXED
152 Branch
Accessibility Severity
Tracking Status
firefox152 --- fixed
Tracking Status
relnote-firefox
firefox-esr115
firefox-esr140
firefox-esr153
firefox152
firefox153
firefox154
---
[webdriver:m20][lang=js][webdriver:external][webdriver:relnote]
QA Whiteboard:
---
Change Request:
---
Bug Flags:
Signature:
None
This bug is publicly visible.

 

https://searchfox.org/firefox-main/rev/8332a06d47ce7d66623d807068b3410061cd29d3/remote/webdriver-bidi/modules/windowglobal/browsingContext.sys.mjs#38-49

constructor(messageHandler) {
 super(messageHandler);

 // Setup the LoadListener as early as possible.
 this.#loadListener = new lazy.LoadListener(this.messageHandler.window);
 this.#loadListener.on("DOMContentLoaded", this.#onDOMContentLoaded);
 this.#loadListener.on("load", this.#onLoad);

 // Set of event names which have active subscriptions.
 this.#subscribedEvents = new Set();
 this.contextCreatedHandled = false;
}

We should simply update contextCreatedHandled to be #contextCreatedHandled here. Completely straightforward, if anyone wants to use this to setup their environment, this is a good first bug.

Priority: -- β†’ P3
Whiteboard: [lang=js] β†’ [webdriver:backlog][lang=js]

Comment 1

β€’
1 month ago

Hi Julian, I’m new to Firefox contribution and I’d like to work on this bug.

I checked that it is unassigned, and I’d like to take it if that’s okay. Could I be assigned to it?

Thanks!

(In reply to Amin Amir from comment #1)

Hi Julian, I’m new to Firefox contribution and I’d like to work on this bug.

I checked that it is unassigned, and I’d like to take it if that’s okay. Could I be assigned to it?

Thanks!

Hi Amin, the bug will automatically be assigned to you when you submit a patch on Phabricator.

Take a look at https://firefox-source-docs.mozilla.org/setup/index.html to setup your environment and let us know if you have any question!

Assignee: nobody β†’ amin208975
Status: NEW β†’ ASSIGNED

Comment 5

β€’
1 month ago
bugherder
Status: ASSIGNED β†’ RESOLVED
Closed: 1 month ago
Resolution: --- β†’ FIXED
Target Milestone: --- β†’ 152 Branch
Whiteboard: [webdriver:backlog][lang=js] β†’ [webdriver:m20][lang=js][webdriver:external]
Whiteboard: [webdriver:m20][lang=js][webdriver:external] β†’ [webdriver:m20][lang=js][webdriver:external][webdriver:relnote]
You need to log in before you can comment on or make changes to this bug.