Fix missing WITHOUT ROWID SQLite performance optimization in SERPCategorization.sys.mjs

👁 Image	Stephanie Cunnane [:scunnane] Reporter
	Description • 1 month ago

When we initially create the domain_to_categories table here, we make use of the WITHOUT ROWID SQLite performance optimization. But we've overlooked adding that same optimization if we need to recreate the table here.

👁 Image	Amin Amir
	Comment 1 • 1 month ago

Hi Stephanie, I’m new to Firefox contribution and I’d like to work on this good-first-bug.

I see it is currently unassigned. Could I be assigned to it?

I’ll look into adding the missing WITHOUT ROWID optimization when the domain_to_categories table is recreated in SERPCategorization.sys.mjs.

Thanks!

👁 Image	Amin Amir Assignee
	Comment 2 • 1 month ago

I have the fix ready locally and I’m preparing to submit it to Phabricator.

Who should I request review from for this patch?

Thanks!

👁 Image	Stephanie Cunnane [:scunnane] Reporter
	Comment 3 • 1 month ago

Hi Amin, thanks very much for working on this bug. You can add me (scunnane) as the patch reviewer.

👁 Image	Mark Banner (:standard8)
	Updated • 1 month ago

👁 Image	Amin Amir Assignee
	Comment 4 • 1 month ago

👁 Image	Phabricator Automation
	Updated • 1 month ago

👁 Image	Pulsebot
	Comment 5 • 1 month ago

Pushed by scunnane@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/1087f61fbacb https://hg.mozilla.org/integration/autoland/rev/5a78477aa37b Add WITHOUT ROWID to recreated SERP categorization table. r=scunnane,search-reviewers

👁 Image	Cosmin Sabou [:CosminS]
	Comment 6 • 1 month ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/5a78477aa37b

👁 Image	Petruta Horea [:phorea]
	Updated • 1 month ago