VOOZH about

URL: https://bugzilla.mozilla.org/2035252

⇱ 2035252 - Remove commented-out code in SearchService.sys.mjs


Closed Bug 2035252 Opened 1 month ago Closed 1 month ago

Remove commented-out code in SearchService.sys.mjs

Remove commented-out code in SearchService.sys.mjs
Firefox
Search
unspecified
Unspecified
Unspecified
task
Points:
---
RESOLVED FIXED
RESOLVED
FIXED
152 Branch
Iteration:
---
a11y-review
Accessibility Severity
Performance Impact
Webcompat Priority
Webcompat Score
Tracking Status
firefox152 --- fixed
Tracking Status
relnote-firefox
firefox-esr115
firefox-esr140
firefox-esr153
firefox152
firefox153
firefox154
---
QA Whiteboard:
[search] [qa-triage-done-c152/b151]
Has STR:
---
Change Request:
---
Bug Flags:
Signature:
None
This bug is publicly visible.

 

I noticed this commented-out line was accidentally left in the search service code. This would be a nice "hello world" type bug for a new contributor.

Assignee

Comment 1

1 month ago

Hi, I’m a new contributor and I’d like to work on this bug.
I’ve set up the Firefox source locally and identified the commented-out line in SearchService.sys.mjs. I’m preparing a patch and will submit it for review shortly.

Sounds great, thank you. You can add me (scunnane) as a reviewer when you submit the patch.

Assignee: nobody → akeemomosanya98
Status: NEW → ASSIGNED

Comment 4

1 month ago
Pushed by scunnane@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/55a1d10f7eea https://hg.mozilla.org/integration/autoland/rev/e779fb77f0bf Remove commented-out code in SearchService.sys.mjs. r=scunnane,search-reviewers DONTBUILD

Comment 5

1 month ago
bugherder
Status: ASSIGNED → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
Target Milestone: --- → 152 Branch
QA Whiteboard: [search] [qa-triage-done-c152/b151]
You need to log in before you can comment on or make changes to this bug.