VOOZH about

URL: https://bugzilla.mozilla.org/2039309

⇱ 2039309 - dom/media/platforms/ffmpeg/FFmpegVulkanVideoDecoder.cpp:481:26: error: major was not declared in this scope


Closed Bug 2039309 Opened 1 month ago Closed 1 month ago

dom/media/platforms/ffmpeg/FFmpegVulkanVideoDecoder.cpp:481:26: error: major was not declared in this scope

dom/media/platforms/ffmpeg/FFmpegVulkanVideoDecoder.cpp:481:26: error: major was not declared in this scope
Core
Audio/Video: Playback
Trunk
Unspecified
Unspecified
defect
Points:
---
RESOLVED FIXED
RESOLVED
FIXED
152 Branch
Iteration:
---
a11y-review
Accessibility Severity
Performance Impact
Size Estimate
Webcompat Priority
Webcompat Score
Tracking Status
firefox-esr140 --- unaffected
firefox150 --- unaffected
firefox151 --- unaffected
firefox152 --- fixed
Tracking Status
relnote-firefox
thunderbird_esr115
thunderbird_esr140
firefox-esr115
firefox-esr140
firefox-esr153
firefox150
firefox151
firefox152
firefox153
firefox154
---
QA Whiteboard:
[qa-triage-done-c153/b152]
Has STR:
---
Change Request:
---
Bug Flags:
Signature:
None
This bug is publicly visible.

 
Reporter

Description

1 month ago

Steps to reproduce:

Build on Solaris fails with:

26:13.07 dom/media/platforms/ffmpeg/libav54
26:21.01 E ../../../../../../../mozilla-central-git-build/dom/media/platforms/ffmpeg/FFmpegVulkanVideoDecoder.cpp:481:26: error: ?major? was not declared in this scope
26:21.01 E 481 | rendererDrmMajor = major(st.st_rdev);
26:21.01 E | ^~~~~
26:21.05 E ../../../../../../../mozilla-central-git-build/dom/media/platforms/ffmpeg/FFmpegVulkanVideoDecoder.cpp:482:26: error: ?minor? was not declared in this scope
26:21.05 E 482 | rendererDrmMinor = minor(st.st_rdev);
26:21.05 E | ^~~~~
26:22.06 E ../../../../../../../mozilla-central-git-build/dom/media/platforms/ffmpeg/FFmpegVulkanVideoDecoder.cpp:481:26: error: ?major? was not declared in this scope
26:22.06 E 481 | rendererDrmMajor = major(st.st_rdev);
26:22.06 E | ^~~~~
26:22.11 E ../../../../../../../mozilla-central-git-build/dom/media/platforms/ffmpeg/FFmpegVulkanVideoDecoder.cpp:482:26: error: ?minor? was not declared in this scope
26:22.11 E 482 | rendererDrmMinor = minor(st.st_rdev);
26:22.11 E | ^~~~~
26:22.38 E ../../../../../../../mozilla-central-git-build/dom/media/platforms/ffmpeg/FFmpegVulkanVideoDecoder.cpp:481:26: error: ?major? was not declared in this scope
26:22.38 E 481 | rendererDrmMajor = major(st.st_rdev);
26:22.38 E | ^~~~~
26:22.43 E ../../../../../../../mozilla-central-git-build/dom/media/platforms/ffmpeg/FFmpegVulkanVideoDecoder.cpp:482:26: error: ?minor? was not declared in this scope
26:22.43 E 482 | rendererDrmMinor = minor(st.st_rdev);
26:22.43 E | ^~~~~
26:22.57 dom/media/platforms/ffmpeg/libav55
26:24.65 dom/media/platforms/ffmpeg
26:29.72 E gmake[4]: *** [/builds/psumbera/mozilla-central-git-build/config/rules.mk:668: Unified_cpp_ffmpeg_ffmpeg600.o] Error 1
26:29.72 E gmake[3]: *** [/builds/psumbera/mozilla-central-git-build/config/recurse.mk:72: dom/media/platforms/ffmpeg/ffmpeg60/target-objects] Error 2
26:29.73 E gmake[3]: *** Waiting for unfinished jobs....
26:30.02 E gmake[4]: *** [/builds/psumbera/mozilla-central-git-build/config/rules.mk:668: Unified_cpp_ffmpeg_ffmpeg620.o] Error 1
26:30.02 E gmake[3]: *** [/builds/psumbera/mozilla-central-git-build/config/recurse.mk:72: dom/media/platforms/ffmpeg/ffmpeg62/target-objects] Error 2
26:30.39 E gmake[4]: *** [/builds/psumbera/mozilla-central-git-build/config/rules.mk:668: Unified_cpp_ffmpeg_ffmpeg610.o] Error 1
26:30.39 E gmake[3]: *** [/builds/psumbera/mozilla-central-git-build/config/recurse.mk:72: dom/media/platforms/ffmpeg/ffmpeg61/target-objects] Error 2
Reporter

Updated

1 month ago
Keywords: regression
Regressed by: 2021722
Reporter

Comment 1

1 month ago

3939001b6bf5156e8fa0f56387ad4103d81de105 is the first bad commit
commit 3939001b6bf5156e8fa0f56387ad4103d81de105
Author: Tymur Boiko <tboiko@nvidia.com>
Date: Tue May 12 14:29:08 2026 +0000

Bug 2021722 - DOM Media - FFmpeg Vulkan Video decode in RDD. r=stransky,alwu

Decoder and tests:

- Vulkan video decode in FFmpegVideoDecoder using FFmpeg Vulkan API, with
 DRM modifier handling.
- DRM modifier output: direct DMA-BUF export when FFmpeg supports
 VK_IMAGE_TILING_DRM_FORMAT_MODIFIER_EXT, otherwise copy path; pass modifier
 lists via hw_device_ctx->user_opaque as needed.
- Direct vs copy paths for same-GPU vs cross-GPU scenarios.
- Poll fallback when android_native_fence_fd sync is not available.

Differential Revision: https://phabricator.services.mozilla.com/D290522

The Bugbug bot thinks this bug should belong to the 'Core::Audio/Video: Playback' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Component: Untriaged → Audio/Video: Playback
Product: Firefox → Core

:tboiko, since you are the author of the regressor, bug 2021722, could you take a look?

For more information, please visit BugBot documentation.

Flags: needinfo?(tboiko)
Assignee

Comment 4

1 month ago

Linux already includes <sys/sysmacros.h> for major()/minor() on st_rdev.
Solaris/illumos need <sys/mkdev.h>. Apply in FFmpegVulkanVideoDecoder.cpp
and widget/gtk/vulkantest/vulkantest.cpp where the same pattern is used.

Assignee: nobody → tboiko
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Attachment #9586019 - Attachment description: Bug 2039309 - Include <sys/mkdev.h> on Solaris for major()/minor() in Vulkan video DRM render-node stat. r?stransky → Bug 2039309 - Declare major()/minor() for DRM render-node stat on Solaris and BSD. r?stransky

Comment 6

1 month ago
bugherder
Status: ASSIGNED → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
Target Milestone: --- → 152 Branch
QA Whiteboard: [qa-triage-done-c153/b152]
You need to log in before you can comment on or make changes to this bug.