dom/media/platforms/ffmpeg/FFmpegVulkanVideoDecoder.cpp:481:26: error: major was not declared in this scope
| Tracking | Status | |
|---|---|---|
| firefox-esr140 | --- | unaffected |
| firefox150 | --- | unaffected |
| firefox151 | --- | unaffected |
| firefox152 | --- | fixed |
| Reporter | |
Description•1 month ago
|
Steps to reproduce:
Build on Solaris fails with:
26:13.07 dom/media/platforms/ffmpeg/libav54
26:21.01 E ../../../../../../../mozilla-central-git-build/dom/media/platforms/ffmpeg/FFmpegVulkanVideoDecoder.cpp:481:26: error: ?major? was not declared in this scope
26:21.01 E 481 | rendererDrmMajor = major(st.st_rdev);
26:21.01 E | ^~~~~
26:21.05 E ../../../../../../../mozilla-central-git-build/dom/media/platforms/ffmpeg/FFmpegVulkanVideoDecoder.cpp:482:26: error: ?minor? was not declared in this scope
26:21.05 E 482 | rendererDrmMinor = minor(st.st_rdev);
26:21.05 E | ^~~~~
26:22.06 E ../../../../../../../mozilla-central-git-build/dom/media/platforms/ffmpeg/FFmpegVulkanVideoDecoder.cpp:481:26: error: ?major? was not declared in this scope
26:22.06 E 481 | rendererDrmMajor = major(st.st_rdev);
26:22.06 E | ^~~~~
26:22.11 E ../../../../../../../mozilla-central-git-build/dom/media/platforms/ffmpeg/FFmpegVulkanVideoDecoder.cpp:482:26: error: ?minor? was not declared in this scope
26:22.11 E 482 | rendererDrmMinor = minor(st.st_rdev);
26:22.11 E | ^~~~~
26:22.38 E ../../../../../../../mozilla-central-git-build/dom/media/platforms/ffmpeg/FFmpegVulkanVideoDecoder.cpp:481:26: error: ?major? was not declared in this scope
26:22.38 E 481 | rendererDrmMajor = major(st.st_rdev);
26:22.38 E | ^~~~~
26:22.43 E ../../../../../../../mozilla-central-git-build/dom/media/platforms/ffmpeg/FFmpegVulkanVideoDecoder.cpp:482:26: error: ?minor? was not declared in this scope
26:22.43 E 482 | rendererDrmMinor = minor(st.st_rdev);
26:22.43 E | ^~~~~
26:22.57 dom/media/platforms/ffmpeg/libav55
26:24.65 dom/media/platforms/ffmpeg
26:29.72 E gmake[4]: *** [/builds/psumbera/mozilla-central-git-build/config/rules.mk:668: Unified_cpp_ffmpeg_ffmpeg600.o] Error 1
26:29.72 E gmake[3]: *** [/builds/psumbera/mozilla-central-git-build/config/recurse.mk:72: dom/media/platforms/ffmpeg/ffmpeg60/target-objects] Error 2
26:29.73 E gmake[3]: *** Waiting for unfinished jobs....
26:30.02 E gmake[4]: *** [/builds/psumbera/mozilla-central-git-build/config/rules.mk:668: Unified_cpp_ffmpeg_ffmpeg620.o] Error 1
26:30.02 E gmake[3]: *** [/builds/psumbera/mozilla-central-git-build/config/recurse.mk:72: dom/media/platforms/ffmpeg/ffmpeg62/target-objects] Error 2
26:30.39 E gmake[4]: *** [/builds/psumbera/mozilla-central-git-build/config/rules.mk:668: Unified_cpp_ffmpeg_ffmpeg610.o] Error 1
26:30.39 E gmake[3]: *** [/builds/psumbera/mozilla-central-git-build/config/recurse.mk:72: dom/media/platforms/ffmpeg/ffmpeg61/target-objects] Error 2
| Reporter | |
Updated•1 month ago
|
| Reporter | |
Comment 1•1 month ago
|
3939001b6bf5156e8fa0f56387ad4103d81de105 is the first bad commit
commit 3939001b6bf5156e8fa0f56387ad4103d81de105
Author: Tymur Boiko <tboiko@nvidia.com>
Date: Tue May 12 14:29:08 2026 +0000
Bug 2021722 - DOM Media - FFmpeg Vulkan Video decode in RDD. r=stransky,alwu
Decoder and tests:
- Vulkan video decode in FFmpegVideoDecoder using FFmpeg Vulkan API, with
DRM modifier handling.
- DRM modifier output: direct DMA-BUF export when FFmpeg supports
VK_IMAGE_TILING_DRM_FORMAT_MODIFIER_EXT, otherwise copy path; pass modifier
lists via hw_device_ctx->user_opaque as needed.
- Direct vs copy paths for same-GPU vs cross-GPU scenarios.
- Poll fallback when android_native_fence_fd sync is not available.
Differential Revision: https://phabricator.services.mozilla.com/D290522
Comment 2•1 month ago
|
The Bugbug bot thinks this bug should belong to the 'Core::Audio/Video: Playback' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.
Comment 3•1 month ago
|
:tboiko, since you are the author of the regressor, bug 2021722, could you take a look?
For more information, please visit BugBot documentation.
| Assignee | |
Comment 4•1 month ago
|
Linux already includes <sys/sysmacros.h> for major()/minor() on st_rdev.
Solaris/illumos need <sys/mkdev.h>. Apply in FFmpegVulkanVideoDecoder.cpp
and widget/gtk/vulkantest/vulkantest.cpp where the same pattern is used.
Updated•1 month ago
|
Updated•1 month ago
|
Comment 6•1 month ago
|
|
| bugherder | |
Updated•1 month ago
|
Updated•23 days ago
|
