Differential D77881
Bug 1623971 - P5: The arguments to `SetMusicMetadata` must be non-null ClosedPublic Authored by chunmin on Jun 2 2020, 7:11 PM. Tags None Referenced Files
Subscribers
Details
Summary must be constructed with a non-null . The
Diff Detail
Event Timelinechunmin created this revision.Jun 2 2020, 7:11 PM phab-bot requested review of this revision.Jun 2 2020, 7:11 PM phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)". phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)". phab-bot removed a project: secure-revision. chunmin added a child revision: D77882: Bug 1623971 - P6: No need to update metadata upon opening SMTC.Jun 2 2020, 7:11 PM alwu added a comment.Jun 4 2020, 5:05 PM Comment ActionsWhy can we assert this? We don't ensure that we would always get artist name and album artist. The default metadata only contains title and artwork. chunmin added a comment.Jun 10 2020, 12:44 AM Comment ActionsFor an empty by default, would return a non-null buffer, so it's ok. On the other hand, if or could be , we would have a segmentation fault now at [1] since HStringReference cannot be constructed by a nullptr. chunmin edited the summary of this revision. (Show Details) alwu accepted this revision.Jun 10 2020, 1:00 AM This revision is now accepted and ready to land.Jun 10 2020, 1:00 AM Closed by commit rMOZILLACENTRALcaca22b92048: Bug 1623971 - P5: The arguments to `SetMusicMetadata` must be non-null r=alwu (authored by Chun-Min Chang <chun.m.chang@gmail.com>). · Explain WhyJun 19 2020, 12:28 AM This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 298953 |
 |
VOOZH | about |