Differential D77885
Bug 1623971 - P9: Assert mControls instead of mInitialized ClosedPublic Authored by chunmin on Jun 2 2020, 7:12 PM. Tags None Referenced Files
Subscribers
Details
Summary By assert mConrols instread of mInitialized in SetControlAttributes, we
Diff Detail
Event Timelinechunmin created this revision.Jun 2 2020, 7:12 PM chunmin added a child revision: D77886: Bug 1623971 - P10: Assert mDisplay instead of mInitialized.Jun 2 2020, 7:12 PM phab-bot requested review of this revision.Jun 2 2020, 7:13 PM phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)". phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)". phab-bot removed a project: secure-revision. alwu added a comment.Jun 4 2020, 5:19 PM Comment ActionsIf you want to do so, you have to clear when fails to make sure that would only exist when initialization succeeded. But that would cause unnecessary reinitialization for and if we fail on line#208 or line#214. chunmin added a comment.Jun 10 2020, 12:44 AM Comment Actionswould become so it won't be called when fails. The functionality in can work properly once is initialized even fails. (BTW, button-click callback stuff works well without the virtual control interface) I can leave in if the intention is to make sure can only be called when succeeds. chunmin edited the summary of this revision. (Show Details) alwu accepted this revision.Jun 10 2020, 1:15 AM This revision is now accepted and ready to land.Jun 10 2020, 1:15 AM chunmin edited the summary of this revision. (Show Details) Closed by commit rMOZILLACENTRAL3c572c417823: Bug 1623971 - P9: Assert mControls instead of mInitialized r=alwu (authored by Chun-Min Chang <chun.m.chang@gmail.com>). · Explain WhyJun 19 2020, 12:28 AM This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 298956 |
 |
VOOZH | about |