VOOZH

URL: https://phabricator.services.mozilla.com/D77887

⇱ ⚙ D77887 Bug 1623971 - P11: Make methods used privately private

Page Menu HomePhabricator

Differential D77887

Bug 1623971 - P11: Make methods used privately private
ClosedPublic
Actions

Authored by chunmin on Jun 2 2020, 7:12 PM.

Tags

None

Referenced Files

Unknown Object (File)

Thu, Jun 11, 2:56 AM

Unknown Object (File)

Sat, May 23, 5:09 PM

Unknown Object (File)

Apr 14 2026, 12:34 PM

Unknown Object (File)

Apr 9 2026, 7:35 PM

Unknown Object (File)

Apr 5 2026, 8:22 PM

Unknown Object (File)

Apr 4 2026, 2:43 PM

Unknown Object (File)

Apr 4 2026, 10:48 AM

Unknown Object (File)

Apr 1 2026, 5:56 PM

View All 38 Files

Subscribers

Details

Reviewers

Commits

rMOZILLACENTRALac69b774f094: Bug 1623971 - P11: Make methods used privately private r=alwu

Bugzilla Bug ID

Summary

Some functions are listed as public methods but they are only used
privately. It's better to make them private.

Diff Detail

Repository: rMOZILLACENTRAL mozilla-central

Event Timeline

chunmin created this revision.Jun 2 2020, 7:12 PM

Herald added a project: secure-revision. · View Herald TranscriptJun 2 2020, 7:12 PM

Harbormaster completed remote builds in B204540: Diff 289392.Jun 2 2020, 7:12 PM

chunmin added a child revision: D77888: Bug 1623971 - P12: Reorganize member functions.Jun 2 2020, 7:12 PM

phab-bot requested review of this revision.Jun 2 2020, 7:13 PM

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".

phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".

phab-bot removed a project: secure-revision.

Herald added a subscriber: emilio. · View Herald TranscriptJun 2 2020, 7:13 PM

chunmin added a reviewer: alwu.Jun 3 2020, 9:51 PM

alwu accepted this revision.Jun 4 2020, 5:21 PM

This revision is now accepted and ready to land.Jun 4 2020, 5:21 PM

chunmin updated this revision to Diff 293683.Jun 10 2020, 12:48 AM

chunmin edited the summary of this revision. (Show Details)

Harbormaster completed remote builds in B207540: Diff 293683.Jun 10 2020, 12:48 AM

chunmin updated this revision to Diff 296755.Jun 15 2020, 8:50 PM

Harbormaster completed remote builds in B209745: Diff 296755.Jun 15 2020, 8:50 PM

chunmin updated this revision to Diff 298939.Jun 19 2020, 12:20 AM

Harbormaster completed remote builds in B211308: Diff 298939.Jun 19 2020, 12:20 AM

Closed by commit rMOZILLACENTRALac69b774f094: Bug 1623971 - P11: Make methods used privately private r=alwu (authored by Chun-Min Chang <chun.m.chang@gmail.com>). · Explain WhyJun 19 2020, 12:28 AM

This revision was automatically updated to reflect the committed changes.

chunmin added a commit: rMOZILLACENTRALac69b774f094: Bug 1623971 - P11: Make methods used privately private r=alwu.

Revision Contents
Changeset List

Path

Size

widget/

windows/

WindowsSMTCProvider.h

28 lines

Commit	Parents	Author	Summary	Date
ac69b774f094	Chun-Min Chang	Bug 1623971 - P11: Make methods used privately private r=alwu (Show More…)

	Status	Author	Revision
Closed	chunmin	D79736 Bug 1623971 - P19: Resolve fetching upon image is ready
Closed	chunmin	D79222 Bug 1623971 - P18: Fetch next available image if fetching fails
Closed	chunmin	D77893 Bug 1623971 - P17: Set media-session's MediaImage to the SMTC interface
Closed	chunmin	D77892 Bug 1623971 - P16: Add a method to set image to SMTC thumbnail
Closed	chunmin	D77891 Bug 1623971 - P15: Move Maybe.h from .h to .cpp
Closed	chunmin	D77890 Bug 1623971 - P14: Replace `\` by `/` in `#include`
Closed	chunmin	D77889 Bug 1623971 - P13: Apply the same format for comments
Closed	chunmin	D77888 Bug 1623971 - P12: Reorganize member functions
Closed	chunmin	D77887 Bug 1623971 - P11: Make methods used privately private
Closed	chunmin	D77886 Bug 1623971 - P10: Assert mDisplay instead of mInitialized
Closed	chunmin	D77885 Bug 1623971 - P9: Assert mControls instead of mInitialized
Closed	chunmin	D77884 Bug 1623971 - P8: Rework SMTP opening
Closed	chunmin	D77883 Bug 1623971 - P7: Rename `IMSTCDisplayUpdater` to `ISMTCDisplayUpdater`
Closed	chunmin	D77882 Bug 1623971 - P6: No need to update metadata upon opening SMTC
Closed	chunmin	D77881 Bug 1623971 - P5: The arguments to `SetMusicMetadata` must be non-null
Closed	chunmin	D77880 Bug 1623971 - P4: No need to set default metadata when initializing
Closed	chunmin	D77879 Bug 1623971 - P3: Return false when `SetMusicMetadata` fails
Closed	chunmin	D77878 Bug 1623971 - P2: Delete comments
Closed	chunmin	D77877 Bug 1623971 - P1: Replace `Maybe<const wchar_t>` by `const wchar_t`

Diff 298959

widget/windows/WindowsSMTCProvider.h

Loading...

Log In to Comment

Privacy · Cookies · Legal