VOOZH about

URL: https://phabricator.services.mozilla.com/D77888

⇱ ⚙ D77888 Bug 1623971 - P12: Reorganize member functions


Bug 1623971 - P12: Reorganize member functions
ClosedPublic

Authored by chunmin on Jun 2 2020, 7:12 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jun 12, 12:58 PM
Unknown Object (File)
Tue, May 26, 9:44 PM
Unknown Object (File)
Sat, May 23, 5:58 PM
Unknown Object (File)
Apr 4 2026, 4:42 PM
Unknown Object (File)
Apr 4 2026, 12:12 PM
Unknown Object (File)
Apr 2 2026, 11:14 AM
Unknown Object (File)
Apr 1 2026, 5:23 PM
Unknown Object (File)
Mar 30 2026, 11:26 AM
Subscribers

Details

Summary
  • Group related functions together
  • Sync the function order in .cpp and .h (except destructor)
  • Rename to

Diff Detail

Event Timeline

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: secure-revision.
Comment Actions

Instead of rewording the comment for , maybe we should rename that in order to clearly indicate what that function would do?

Comment Actions

I'll rename the to something with explicit meaning.

chunmin retitled this revision from Bug 1623971 - P12: Reorder member functions to Bug 1623971 - P12: Reorganize member functions.
chunmin edited the summary of this revision. (Show Details)
This revision is now accepted and ready to land.Jun 10 2020, 1:14 AM

Revision Contents

PathSize
widget/
windows/
8 lines
312 lines
CommitParentsAuthorSummaryDate
bba6f9948eafChun-Min Chang
Bug 1623971 - P12: Reorganize member functions r=alwu (Show More…)
StatusAuthorRevision
Closedchunmin
Closedchunmin
Closedchunmin
Closedchunmin
Closedchunmin
Closedchunmin
Closedchunmin
Closedchunmin
Closedchunmin
Closedchunmin
Closedchunmin
Closedchunmin
Closedchunmin
Closedchunmin
Closedchunmin
Closedchunmin
Closedchunmin
Closedchunmin
Closedchunmin

Diff 298960

widget/windows/WindowsSMTCProvider.h

Loading...

widget/windows/WindowsSMTCProvider.cpp

Loading...