VOOZH

URL: https://phabricator.services.mozilla.com/D77891

⇱ ⚙ D77891 Bug 1623971 - P15: Move Maybe.h from .h to .cpp

Page Menu HomePhabricator

Differential D77891

Bug 1623971 - P15: Move Maybe.h from .h to .cpp
ClosedPublic
Actions

Authored by chunmin on Jun 2 2020, 7:12 PM.

Tags

None

Referenced Files

Unknown Object (File)

Fri, Jun 12, 1:53 PM

Unknown Object (File)

Mon, May 25, 3:58 AM

Unknown Object (File)

Apr 21 2026, 6:39 AM

Unknown Object (File)

Apr 17 2026, 11:12 PM

Unknown Object (File)

Apr 6 2026, 1:51 PM

Unknown Object (File)

Apr 6 2026, 1:00 PM

Unknown Object (File)

Apr 5 2026, 1:39 PM

Unknown Object (File)

Apr 5 2026, 4:06 AM

View All 30 Files

Subscribers

Details

Reviewers

Commits

rMOZILLACENTRALae2df4d87725: Bug 1623971 - P15: Move Maybe.h from .h to .cpp r=alwu

Bugzilla Bug ID

Summary

is used in the .cpp file only.

Diff Detail

Repository: rMOZILLACENTRAL mozilla-central

Event Timeline

chunmin created this revision.Jun 2 2020, 7:12 PM

Herald added a project: secure-revision. · View Herald TranscriptJun 2 2020, 7:12 PM

Harbormaster completed remote builds in B204545: Diff 289397.Jun 2 2020, 7:12 PM

chunmin added a child revision: D77892: Bug 1623971 - P16: Add a method to set image to SMTC thumbnail.Jun 2 2020, 7:12 PM

phab-bot requested review of this revision.Jun 2 2020, 7:13 PM

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".

phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".

phab-bot removed a project: secure-revision.

Herald added a subscriber: emilio. · View Herald TranscriptJun 2 2020, 7:13 PM

chunmin added a reviewer: alwu.Jun 3 2020, 9:52 PM

alwu accepted this revision.Jun 4 2020, 5:27 PM

This revision is now accepted and ready to land.Jun 4 2020, 5:27 PM

chunmin updated this revision to Diff 293687.Jun 10 2020, 12:49 AM

chunmin edited the summary of this revision. (Show Details)

Harbormaster completed remote builds in B207544: Diff 293687.Jun 10 2020, 12:49 AM

chunmin updated this revision to Diff 296759.Jun 15 2020, 8:50 PM

Harbormaster completed remote builds in B209749: Diff 296759.Jun 15 2020, 8:50 PM

chunmin updated this revision to Diff 298944.Jun 19 2020, 12:20 AM

Harbormaster completed remote builds in B211312: Diff 298944.Jun 19 2020, 12:20 AM

Closed by commit rMOZILLACENTRALae2df4d87725: Bug 1623971 - P15: Move Maybe.h from .h to .cpp r=alwu (authored by Chun-Min Chang <chun.m.chang@gmail.com>). · Explain WhyJun 19 2020, 12:29 AM

This revision was automatically updated to reflect the committed changes.

chunmin added a commit: rMOZILLACENTRALae2df4d87725: Bug 1623971 - P15: Move Maybe.h from .h to .cpp r=alwu.

Revision Contents
Changeset List

Path

Size

widget/

windows/

WindowsSMTCProvider.h

1 line

WindowsSMTCProvider.cpp

1 line

Commit	Parents	Author	Summary	Date
ae2df4d87725	Chun-Min Chang	Bug 1623971 - P15: Move Maybe.h from .h to .cpp r=alwu (Show More…)

	Status	Author	Revision
Closed	chunmin	D79736 Bug 1623971 - P19: Resolve fetching upon image is ready
Closed	chunmin	D79222 Bug 1623971 - P18: Fetch next available image if fetching fails
Closed	chunmin	D77893 Bug 1623971 - P17: Set media-session's MediaImage to the SMTC interface
Closed	chunmin	D77892 Bug 1623971 - P16: Add a method to set image to SMTC thumbnail
Closed	chunmin	D77891 Bug 1623971 - P15: Move Maybe.h from .h to .cpp
Closed	chunmin	D77890 Bug 1623971 - P14: Replace `\` by `/` in `#include`
Closed	chunmin	D77889 Bug 1623971 - P13: Apply the same format for comments
Closed	chunmin	D77888 Bug 1623971 - P12: Reorganize member functions
Closed	chunmin	D77887 Bug 1623971 - P11: Make methods used privately private
Closed	chunmin	D77886 Bug 1623971 - P10: Assert mDisplay instead of mInitialized
Closed	chunmin	D77885 Bug 1623971 - P9: Assert mControls instead of mInitialized
Closed	chunmin	D77884 Bug 1623971 - P8: Rework SMTP opening
Closed	chunmin	D77883 Bug 1623971 - P7: Rename `IMSTCDisplayUpdater` to `ISMTCDisplayUpdater`
Closed	chunmin	D77882 Bug 1623971 - P6: No need to update metadata upon opening SMTC
Closed	chunmin	D77881 Bug 1623971 - P5: The arguments to `SetMusicMetadata` must be non-null
Closed	chunmin	D77880 Bug 1623971 - P4: No need to set default metadata when initializing
Closed	chunmin	D77879 Bug 1623971 - P3: Return false when `SetMusicMetadata` fails
Closed	chunmin	D77878 Bug 1623971 - P2: Delete comments
Closed	chunmin	D77877 Bug 1623971 - P1: Replace `Maybe<const wchar_t>` by `const wchar_t`

Diff 298963

widget/windows/WindowsSMTCProvider.h

Loading...

widget/windows/WindowsSMTCProvider.cpp

Loading...

Log In to Comment

Privacy · Cookies · Legal