VOOZH about

URL: https://phabricator.services.mozilla.com/D79736

⇱ ⚙ D79736 Bug 1623971 - P19: Resolve fetching upon image is ready


Bug 1623971 - P19: Resolve fetching upon image is ready
ClosedPublic

Authored by chunmin on Jun 15 2020, 8:51 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Jun 14, 10:56 PM
Unknown Object (File)
Sat, Jun 13, 1:34 AM
Unknown Object (File)
May 17 2026, 8:34 PM
Unknown Object (File)
May 17 2026, 8:34 PM
Unknown Object (File)
Apr 27 2026, 5:44 AM
Unknown Object (File)
Mar 29 2026, 1:55 PM
Unknown Object (File)
Mar 13 2026, 6:52 AM
Unknown Object (File)
Nov 16 2025, 1:59 AM
Subscribers

Details

Summary

The FetchImageHelp doesn't need to decode the fetched image before
handing the image to its caller since the decoded raw data won't be used
in the caller. The ImagePromise can be resolved upon image is fetched
(ready) instead.

Diff Detail

Event Timeline

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: secure-revision.
Comment Actions

Code analysis found 1 defect in the diff 296764:

  • 1 defect found by code coverage analysis

In our previous code coverage analysis run, we found some files which had no coverage and are being modified in this patch:
Should they have tests, or are they dead code ?

  • You can file a bug blocking Bug 1415824 for untested files that should be tested.
  • You can file a bug blocking Bug 1415819 for untested files that should be removed.

If you see a problem in this automated review, please report it here.

You can view these defects on the code-review frontend and on Treeherder.

This revision is now accepted and ready to land.Jun 18 2020, 4:15 PM
chunmin edited the summary of this revision. (Show Details)
Comment Actions

Code analysis found 1 defect in the diff 298948:

  • 1 defect found by code coverage analysis

In our previous code coverage analysis run, we found some files which had no coverage and are being modified in this patch:
Should they have tests, or are they dead code ?

  • You can file a bug blocking Bug 1415824 for untested files that should be tested.
  • You can file a bug blocking Bug 1415819 for untested files that should be removed.

If you see a problem in this automated review, please report it here.

You can view these defects on the code-review frontend and on Treeherder.

Revision Contents

PathSize
dom/
media/
mediacontrol/
9 lines
34 lines
CommitParentsAuthorSummaryDate
aec24340c84fChun-Min Chang
Bug 1623971 - P19: Resolve fetching upon image is ready r=alwu (Show More…)
StatusAuthorRevision
Closedchunmin
Closedchunmin
Closedchunmin
Closedchunmin
Closedchunmin
Closedchunmin
Closedchunmin
Closedchunmin
Closedchunmin
Closedchunmin
Closedchunmin
Closedchunmin
Closedchunmin
Closedchunmin
Closedchunmin
Closedchunmin
Closedchunmin
Closedchunmin
Closedchunmin

Diff 298967

dom/media/mediacontrol/FetchImageHelper.h

Loading...

dom/media/mediacontrol/FetchImageHelper.cpp

Loading...