In our previous code coverage analysis run, we found some files which had no coverage and are being modified in this patch:
Should they have tests, or are they dead code?

You can file a bug blocking Bug 1415824 for untested files that should be tested.
You can file a bug blocking Bug 1415819 for untested files that should be removed.

If you see a problem in this automated review, please report it here.

You can view these defects on the code-review frontend and on Treeherder.

def00111 updated this revision to Diff 566647.Apr 12 2022, 4:23 PM

Harbormaster completed remote builds in B413923: Diff 566647.Apr 12 2022, 4:23 PM

reviewbot added a comment.Apr 12 2022, 4:42 PM

Comment Actions

Code analysis found 1 defect in the diff 566647:

1 defect found by code coverage analysis

In our previous code coverage analysis run, we found some files which had no coverage and are being modified in this patch:
Should they have tests, or are they dead code?

You can file a bug blocking Bug 1415824 for untested files that should be tested.
You can file a bug blocking Bug 1415819 for untested files that should be removed.

If you see a problem in this automated review, please report it here.

You can view these defects on the code-review frontend and on Treeherder.

def00111 updated this revision to Diff 566725.Apr 12 2022, 7:07 PM

Harbormaster completed remote builds in B413979: Diff 566725.Apr 12 2022, 7:07 PM

reviewbot added a comment.Apr 12 2022, 7:25 PM

Comment Actions

Code analysis found 1 defect in the diff 566725:

1 defect found by code coverage analysis

In our previous code coverage analysis run, we found some files which had no coverage and are being modified in this patch:
Should they have tests, or are they dead code?

You can file a bug blocking Bug 1415824 for untested files that should be tested.
You can file a bug blocking Bug 1415819 for untested files that should be removed.

If you see a problem in this automated review, please report it here.

You can view these defects on the code-review frontend and on Treeherder.

def00111 edited reviewers, added: robwu; removed: zombie.May 26 2022, 11:21 AM

Comment Actions

Can you review the patch?

robwu added a comment.May 26 2022, 12:00 PM

Comment Actions

This patch changes the behavior observable to extensions. Previously they could see whatever limit was available, but with this patch it's capped at 25.
For this reason, let's land this patch next week (after the version bump).

browser/components/extensions/test/browser/browser_ext_sessions_getRecentlyClosed_max_results.js
15	Remove the message, it's not checked anywhere since you're calling without any parameters.
28	Add another test where this value is set to a lower value than 25, and repeat the test. If the relation between this pref and the API behavior is exactly as you described, then the test will ensure that this relation is tested & verified, instead of just being a comment that can become out-of-date. Let's also add a unit test that confirms the value of the constant has the expected number. Currently, while the default is the same as the pref, it is still possible for MAX_SESSION_RESULTS to be out-of-sync with the actual maximum, which could result in surprising test results.

robwu requested changes to this revision.May 26 2022, 12:01 PM

This revision now requires changes to proceed.May 26 2022, 12:01 PM

def00111 added a comment.May 26 2022, 12:04 PM

Comment Actions

In D143391#4819355, @robwu wrote:

This patch changes the behavior observable to extensions. Previously they could see whatever limit was available, but with this patch it's capped at 25.
For this reason, let's land this patch next week (after the version bump).

I created https://bugzilla.mozilla.org/show_bug.cgi?id=1764376.

def00111 requested review of this revision.Jun 2 2022, 7:36 PM

def00111 updated this revision to Diff 585854.

Harbormaster completed remote builds in B429352: Diff 585854.Jun 2 2022, 7:36 PM

def00111 marked 2 inline comments as done.Jun 2 2022, 7:38 PM

robwu accepted this revision.Jul 11 2022, 3:50 PM

robwu added a project: testing-approved.

This revision is now accepted and ready to land.Jul 11 2022, 3:50 PM

Closed by commit rMOZILLACENTRAL8d3cd97887d1: Bug 1392125 - Fix MAX_SESSION_RESULTS is not defined. r=robwu (authored by def00111). · Explain WhyJul 11 2022, 3:56 PM

This revision was automatically updated to reflect the committed changes.

def00111 added a commit: rMOZILLACENTRAL8d3cd97887d1: Bug 1392125 - Fix MAX_SESSION_RESULTS is not defined. r=robwu.

abutkovits reopened this revision.Jul 11 2022, 5:24 PM