VOOZH about

URL: https://phabricator.services.mozilla.com/D171514

⇱ ⚙ D171514 Bug 1820058: Enable about:config pref for CSS 'content-visibility' on Nightly. r?emilio

Paths

Bug 1820058: Enable about:config pref for CSS 'content-visibility' on Nightly. r?emilio
ClosedPublic

Authored by dholbert on Mar 2 2023, 11:30 PM.
Referenced Files
Unknown Object (File)
Tue, Jun 2, 3:20 AM
Unknown Object (File)
May 3 2026, 7:41 AM
Unknown Object (File)
May 1 2026, 7:56 AM
Unknown Object (File)
Apr 30 2026, 11:52 PM
Unknown Object (File)
Apr 30 2026, 1:00 PM
Unknown Object (File)
Apr 30 2026, 11:27 AM
Unknown Object (File)
Apr 30 2026, 5:40 AM
Unknown Object (File)
Apr 30 2026, 4:08 AM
Subscribers
None

Details

Summary

Also update the devtools CSS db (using ./mach devtools-css-db), and update a
DOM test to make it aware of newly-exposed (and
Nightly-specific for now) ContentVisibilityAutoStateChangeEvent.

Event Timeline

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: secure-revision.
This revision is now accepted and ready to land.Mar 3 2023, 9:10 AM
Comment Actions

Note, this can't land until we've addressed some test-failures, as noted in https://bugzilla.mozilla.org/show_bug.cgi?id=1820058#c3 .

dholbert edited the summary of this revision. (Show Details)
dom/tests/mochitest/general/test_interfaces.js
260–261

Note: emilio (acting as DOM peer) r+'d this in https://phabricator.services.mozilla.com/D172137?id=690788#inline-950291 , and then I moved it over here to couple it more tightly with the pref default-value flip.

This revision is now accepted and ready to land.Mar 13 2023, 7:56 PM
dholbert edited the summary of this revision. (Show Details)
This revision now requires review to proceed.Mar 13 2023, 9:39 PM
Comment Actions

Test failures addressed. Notes:

  • The devtools test failure was just me forgetting that I needed to do a Try run with xpcshell tests. Whoops. :) (just needed to run the command to auto-update the devtools db)
  • The test_interfaces failure was me misunderstanding emilio's review nit in https://phabricator.services.mozilla.com/D172137?id=690788#inline-950291 -- I had swapped in there, but I think he meant to just add that. @emilio if you could confirm that this looks good now, that'd be great - thanks! (The test does now pass locally. I haven't tested it in nightly-as-beta config, but I assume handles that properly.)
dom/tests/mochitest/general/test_interfaces.js
260–261

Yeah, looks good!

This revision is now accepted and ready to land.Mar 14 2023, 6:24 AM

Revision Contents

PathSizeCoverage (All)Coverage (Touched)
devtools/
shared/
css/
generated/
17 lines100%
Loading...
dom/
tests/
mochitest/
general/
6 lines--
modules/
libpref/
init/
2 lines--
CommitParentsAuthorSummaryDate
1262759dcc6fDaniel Holbert
Bug 1820058: Enable about:config pref for CSS 'content-visibility' on Nightly. (Show More…)

Diff 692905

devtools/shared/css/generated/properties-db.js

Loading...

dom/tests/mochitest/general/test_interfaces.js

Loading...

modules/libpref/init/StaticPrefList.yaml

Loading...