• testing-approved

Reviewers

dmeehan

Group Reviewers

release-managers

Commits

rFIREFOXRELEASE099e04744386: Bug 2017049 - Part 3: Revive contentSearchUI styles and inline newtab style…

Bugzilla Bug ID

2017049

Uplift Request form

• User impact if declined Clients that were relying on the unsupported pref for accessibility reasons will find that it doesn't work anymore, resulting in enough of an accessibility problem that we've decided to revive support temporarily until the inline search experience is ready.
• Code covered by automated testing yes
• Fix verified in Nightly yes
• Needs manual QE test yes
• Steps to reproduce for manual QE testing To be clear, the handoff mode is tested in automation. This new non-handoff mode is not tested, and we've made an intentional choice not to revive the tests that had existed previously, since that would really complicate our current search testing code for the handoff mode.

We've made the deliberate decision to rely on manual testing for this unsupported mode.

Testing instructions here: https://bugzilla.mozilla.org/show_bug.cgi?id=2017049#c15

• Risk associated with taking this patch low
• Explanation of risk level We've got plenty of automated test coverage for the handoff case, which accounts for the vast majority of searches in Firefox. This patch adds the unsupported pref back and the old prior experience, mainly using revived code that we've moved into a more appropriate place as a stopgap. The new code doesn't run unless the pref is set to the non-default setting.
• String changes made/needed None.
• Is Android affected? no

This is pretty ham-fisted, but it's also a temporary kludge until we can get the inline
search mechanism done and we can remove all of this.

Essentially, this revives and inlines the old non-handoff CSS from contentSearchUI.css into
contentSearchHandoffUI.css, but only uses it in non-handoff mode. It also includes a bunch
of additional overrides that newtab had historically been applying to contentSearchUI.css,
but those are now inlined directly. This way, we can get the behaviour and appearance that
we want without relying on newtab needing to update its sheets / send out a train-hop release
to support this revived mode.

The CSS rules have not been de-duplicated / simplified, beyond the inlining of various variables
that historically had lived within activity-stream.css. I honestly don't think such a
simplification / cleanup is worth the effort since this is so temporary.

Original Revision: https://phabricator.services.mozilla.com/D284291