VOOZH about

URL: https://phabricator.services.mozilla.com/D302996

⇱ ⚙ D302996 Bug 2039932 - Remove network.cookie.cookieBehavior.trackerCookieBlocking pref r=#anti-tracking


Bug 2039932 - Remove network.cookie.cookieBehavior.trackerCookieBlocking pref r=#anti-tracking
ClosedPublic

Authored by manuel on Thu, May 28, 10:34 AM.
Referenced Files
Unknown Object (File)
Tue, Jun 9, 1:35 PM
Unknown Object (File)
Sat, Jun 6, 3:13 AM
Unknown Object (File)
Fri, Jun 5, 11:12 PM
Unknown Object (File)
Wed, Jun 3, 3:27 AM

Diff Detail

Event Timeline

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: secure-revision.
Comment Actions

Summary

Intent

The goal of this change is to remove the preference entirely from the Firefox codebase. This preference was used to optionally block (rather than partition) third-party tracker cookies and storage access when was set to (value 5). By removing it, the code is simplified so that trackers under are always partitioned rather than having a toggle to fully block them.

Solution

The changes span multiple layers of the codebase:

  1. Preference removal: The static preference definition for is removed from , eliminating it from the preference system entirely.
  1. Nimbus experiment feature removal: The Nimbus feature entry is removed from , along with its associated Nimbus integration test (), since the preference it controlled no longer exists.
  1. Storage access logic simplification (): In both the window-based and channel-based storage access checks for , the code previously had separate branches for third-party trackers (which could either block or partition based on the pref) and non-tracker third parties (which were always partitioned). These are now unified into a single condition — both trackers and non-tracker third parties are treated the same way and always partitioned with .
  1. Cookie service simplification (): The logic that chose between and rejection reasons based on the pref value is removed. When partition-foreign mode is active, tracker cookies are now always partitioned (with as the reason) rather than potentially fully blocked.
  1. Test cleanup: The dedicated test file that tested blocking and allowing tracker cookies/storage/indexedDB based on the pref is entirely removed. References to the pref in other test files (, , ) are removed, and expected test outcomes are updated to reflect that trackers are now always partitioned rather than blocked. The runtime check that overrode expected blocking notifications based on the pref value is also removed.
  1. Documentation update: The tracker cookie blocking entry is removed from the ETP (Enhanced Tracking Protection) matrix documentation generator ().

Automated review completed with no comments.
This revision is now accepted and ready to land.Mon, Jun 1, 6:50 PM

Revision Contents

CommitTreeParentsAuthorSummaryDate
b7d20e85f967b99bee032788Manuel Bucher
Bug 2039932 - Remove network.cookie.cookieBehavior.trackerCookieBlocking pref… (Show More…)

Diff 1288772

browser/base/content/test/protectionsUI/browser_protectionsUI_tracker_cookies_subview.js

Loading...

docs/_addons/etp_matrix.py

Loading...

modules/libpref/init/StaticPrefList.yaml

Loading...

netwerk/cookie/CookieService.cpp

Loading...

toolkit/components/antitracking/StorageAccess.cpp

Loading...

toolkit/components/antitracking/test/browser/browser-blocking.toml

Loading...

toolkit/components/antitracking/test/browser/browser.toml

Loading...

toolkit/components/antitracking/test/browser/browser_hasStorageAccess_alwaysPartition.js

Loading...

toolkit/components/antitracking/test/browser/browser_nimbus_thirdPartyTrackerCookieBlocking.js

Loading...

toolkit/components/antitracking/test/browser/browser_noStorageAccessAutoGrant_thirdPartyTracker.js

Loading...

toolkit/components/antitracking/test/browser/browser_trackerCookieBlocking.js

Loading...

toolkit/components/nimbus/FeatureManifest.yaml

Loading...