VOOZH about

URL: https://chromiumcodereview.appspot.com/10825183

⇱ Issue 10825183: net: disable TLS compression with OpenSSL. - Code Review

Keyboard Shortcuts
File
u :up to issue
j / k :jump to file after / before current file
J / K :jump to next file with a comment after / before current file
Side-by-side diff
i :toggle intra-line diffs
e :expand all comments
c :collapse all comments
s :toggle showing all comments
n / p :next / previous diff chunk or comment
N / P :next / previous comment
<Up> / <Down> :next / previous line
Issue
u :up to list of issues
j / k :jump to patch after / before current patch
o / <Enter> :open current patch in side-by-side view
i :open current patch in unified diff view
Issue List
j / k :jump to issue after / before current issue
o / <Enter> :open current issue
👁 Image
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issues Search
    My Issues | Starred     Open | Closed | All

👁 Image
 Issue 10825183: net: disable TLS compression with OpenSSL. (Closed)

Created:
8 years, 4 months ago by agl
Modified:
8 years, 3 months ago
Reviewers:
joth, wtc, klobag.chromium
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org, joth
Visibility:
Public.

Description

net: disable TLS compression with OpenSSL. BUG=139744 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149947

Patch Set 1 #

Created: 8 years, 4 months ago
Download [raw] [tar.bz2]
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
👁 Image
 M net/socket/ssl_client_socket_openssl.cc View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
agl 8 years, 4 months ago (2012-08-03 18:27:52 UTC) #1 

 

 
 


 

 
 

 

 

 

 
 joth
 
 
 

 

 
 
 Lgtm I can't see the linked bug , but guess this is necessary :-)
 
 
 

 

 		
 
 8 years, 4 months ago
		(2012-08-03 18:39:32 UTC)
 #2
 
 

 

 


 

 

 
 
Lgtm 
I can't see the linked bug , but guess this is necessary :-)

 

 
 


 

 
 

 

 

 

 
 commit-bot: I haz the power
 
 
 

 

 
 
 CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/agl@chromium.org/10825183/1
 
 
 

 

 		
 
 8 years, 4 months ago
		(2012-08-03 19:43:17 UTC)
 #3
 
 

 

 


 

 

 
 

 

 

 

 
 klobag.chromium
 
 
 

 

 
 
 lgtm
 
 
 

 

 		
 
 8 years, 4 months ago
		(2012-08-03 21:00:36 UTC)
 #4
 
 

 

 


 

 

 
 
lgtm

 

 
 


 

 
 

 

 

 

 
 wtc
 
 
 

 

 
 
 LGTM.
 
 
 

 

 		
 
 8 years, 4 months ago
		(2012-08-03 21:16:24 UTC)
 #5
 
 

 

 


 

 

 
 
LGTM.

 

 
 


 

 
 

 

 

 

 
 commit-bot: I haz the power
 
 
 

 

 
 
 Change committed as 149947
 
 
 

 

 		
 
 8 years, 4 months ago
		(2012-08-03 22:35:15 UTC)
 #6
 
 

 

 


 

 

 
 
Change committed as 149947

 

 
 


 

 
 

 

 

 

 
 indutny
 
 
 

 

 
 
 Now, almost every aware person on internet has pulled your change in one's project, it's ...
 
 
 

 

 		
 
 8 years, 3 months ago
		(2012-09-12 19:11:44 UTC)
 #7
 
 

 

 


 

 

 
 
Now, almost every aware person on internet has pulled your change in one's
project, it's time to revert this commit just to troll everyone!

 

 
 


 

 
 

 

 

 

 
 joost
 
 
 

 

 
 
 The reason is this?: http://arstechnica.com/security/2012/09/crime-hijacks-https-sessions/
 
 
 

 

 		
 
 8 years, 3 months ago
		(2012-09-13 09:35:31 UTC)
 #8
 
 

 

 


 

 

 

 

 











 		
 

 





 
 
 





 👁 Powered by Google App Engine






 
This is Rietveld 408576698