VOOZH about

URL: https://chromiumcodereview.appspot.com/21680002

⇱ Issue 21680002: Up the window.localstorage limit to 10M from 5M. - Code Review

Keyboard Shortcuts
File
u :up to issue
j / k :jump to file after / before current file
J / K :jump to next file with a comment after / before current file
Side-by-side diff
i :toggle intra-line diffs
e :expand all comments
c :collapse all comments
s :toggle showing all comments
n / p :next / previous diff chunk or comment
N / P :next / previous comment
<Up> / <Down> :next / previous line
Issue
u :up to list of issues
j / k :jump to patch after / before current patch
o / <Enter> :open current patch in side-by-side view
i :open current patch in unified diff view
Issue List
j / k :jump to issue after / before current issue
o / <Enter> :open current issue
👁 Image
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(721)

Issues Search
    My Issues | Starred     Open | Closed | All

👁 Image
 Issue 21680002: Up the window.localstorage limit to 10M from 5M. (Closed)

Created:
7 years, 4 months ago by michaeln
Modified:
7 years, 4 months ago
Reviewers:
ericu, Eric U.
CC:
chromium-reviews, darin-cc_chromium.org
Visibility:
Public.

Description

Up the window.localstorage limit to 10M from 5M. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=215402

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Created: 7 years, 4 months ago
Download [raw] [tar.bz2]
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
👁 Image
 M webkit/common/dom_storage/dom_storage_types.h View 1 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
michaeln
like we've talked about, just bump the number a little
7 years, 4 months ago (2013-08-02 01:05:39 UTC) #1 
like we've talked about, just bump the number a little
ericu
lgtm https://codereview.chromium.org/21680002/diff/1/webkit/common/dom_storage/dom_storage_types.h File webkit/common/dom_storage/dom_storage_types.h (right): https://codereview.chromium.org/21680002/diff/1/webkit/common/dom_storage/dom_storage_types.h#newcode20 webkit/common/dom_storage/dom_storage_types.h:20: // This value is enforced in renderer processes. ...
7 years, 4 months ago (2013-08-02 03:46:22 UTC) #2 
lgtm

https://codereview.chromium.org/21680002/diff/1/webkit/common/dom_storage/dom...
File webkit/common/dom_storage/dom_storage_types.h (right):

https://codereview.chromium.org/21680002/diff/1/webkit/common/dom_storage/dom...
webkit/common/dom_storage/dom_storage_types.h:20: // This value is enforced in
renderer processes.
Isn't it also enforced in the browser? If so, could you update the comment
while you're in there?
michaeln
https://codereview.chromium.org/21680002/diff/1/webkit/common/dom_storage/dom_storage_types.h File webkit/common/dom_storage/dom_storage_types.h (right): https://codereview.chromium.org/21680002/diff/1/webkit/common/dom_storage/dom_storage_types.h#newcode20 webkit/common/dom_storage/dom_storage_types.h:20: // This value is enforced in renderer processes. On ...
7 years, 4 months ago (2013-08-02 19:15:17 UTC) #3 
https://codereview.chromium.org/21680002/diff/1/webkit/common/dom_storage/dom...
File webkit/common/dom_storage/dom_storage_types.h (right):

https://codereview.chromium.org/21680002/diff/1/webkit/common/dom_storage/dom...
webkit/common/dom_storage/dom_storage_types.h:20: // This value is enforced in
renderer processes.
On 2013/08/02 03:46:22, ericu wrote:
> Isn't it also enforced in the browser? If so, could you update the comment
> while you're in there?

done
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/michaeln@chromium.org/21680002/11001
7 years, 4 months ago (2013-08-02 19:16:09 UTC) #4
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) remoting_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=155646
7 years, 4 months ago (2013-08-02 20:19:05 UTC) #5 
Retried try job too often on mac_rel for step(s) remoting_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...
michaeln
cq doesn't work well in practice, which is why i never used it with gcl/svn ...
7 years, 4 months ago (2013-08-02 20:23:55 UTC) #6 
cq doesn't work well in practice, which is why i never used it with gcl/svn
checkouts

looks like i'm not going to use it with my git checkouts either, time to lookup
kungfu git cl dcommit voodoo command to perform the impossible... commit a one
line change
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/michaeln@chromium.org/21680002/11001
7 years, 4 months ago (2013-08-02 20:33:03 UTC) #7
commit-bot: I haz the power
Change committed as 215402
7 years, 4 months ago (2013-08-02 23:20:51 UTC) #8
Message was sent while issue was closed. 
Change committed as 215402
👁 Powered by Google App Engine
This is Rietveld 408576698