`Ctrl+Space` interferes with keyboard navigation #241

New issue

Open

opened by manan-gup · 4 comments

👁 manan-gup

👁 manan-gup
manan-gup commented

Contributor

Copy link

The Ctrl+Space shortcut for play/pause interferes with keyboard navigation as that's the exact key combination you'd use for multi-selecting in lists. Right now you can multi-select via keyboard if you navigate via Ctrl+Up/Down Arrow and then unpress Ctrl and press Space.

GNOME HIG suggests using Ctrl+Letter for shortcuts and Amberol uses Ctrl+P:

👁 image

Fig: Shortcut dialog from Amberol

The `Ctrl+Space` shortcut for play/pause interferes with keyboard navigation as that's the exact key combination you'd use for multi-selecting in lists. Right now you can multi-select via keyboard if you navigate via `Ctrl+Up/Down Arrow` and then unpress `Ctrl` and press `Space`. [GNOME HIG](https://developer.gnome.org/hig/guidelines/keyboard.html) suggests using `Ctrl+Letter` for shortcuts and Amberol uses `Ctrl+P`: ![image](/attachments/e7f38db9-eb3d-48aa-8130-f32daac0a96a) Fig: *Shortcut dialog from Amberol*

image.png

25 KiB

👁 manan-gup

👁 manan-gup
manan-gup commented

Author

Contributor

Copy link

Just noticed that Ctrl+Space is used in another context as well:

👁 image

Probably should be changed as well and also this doesn't currently work anyway as Ctrl+Space just play/pauses. Unless I'm missing something.

EDIT 2: It does works in the edit lyrics dialog. I was mistaken about what the shortcut is for. Maybe the tab title in the shortcuts dialog can be changed to "Synced Lyrics Editor" or something like that. Otherwise, this works fine and doesn't clash with the player controls.

Just noticed that `Ctrl+Space` is used in another context as well: ![image](/attachments/dc0940e0-3f34-4941-9b18-06cf09dbfb71) Probably should be changed as well and also this doesn't currently work anyway as `Ctrl+Space` just play/pauses. Unless I'm missing something. ~~EDIT: Are these even set anywhere? I can't find them in the codebase. Or are they set by gtk/libadwaita?~~ EDIT 2: It does works in the edit lyrics dialog. I was mistaken about what the shortcut is for. Maybe the tab title in the shortcuts dialog can be changed to "Synced Lyrics Editor" or something like that. Otherwise, this works fine and doesn't clash with the player controls.

image.png

28 KiB

👁 manan-gup

👁 manan-gup
manan-gup commented

Author

Contributor

Copy link

Another option could be to use the focus-in-event/focus-out-event on the search entry widget to disable/enable global shortcuts. This way single key shortcuts would be possible to use (though I'm not sure if this would be completely unproblematic).
Setting the propagation phase to None might be a way to disable a ShortcutController.

Another option could be to use the `focus-in-event`/`focus-out-event` on the search entry widget to disable/enable global shortcuts. This way single key shortcuts would be possible to use (though I'm not sure if this would be completely unproblematic). Setting the [propagation phase](https://gtk-rs.org/gtk4-rs/stable/latest/docs/gtk4/prelude/trait.EventControllerExt.html#method.set_propagation_phase) to `None` might be a way to disable a `ShortcutController`.

👁 Emmett de St. Croix

👁 Emmett de St. Croix
edestcroix commented

Owner

Copy link

I'll think I'll change it to Ctrl+P like Amberol then, probably the best option to avoid any more conflicts. Single key shortcuts are generally problematic, and I also vaguely remember trying to do something like using the search entry focus events to disable global shortcuts and it ended up being more trouble than it would've been worth.

And yeah I should make it clear those shortcuts are for the editor and not the viewer, I'll switch that too.

I'll think I'll change it to `Ctrl+P` like Amberol then, probably the best option to avoid any more conflicts. Single key shortcuts are generally problematic, and I also vaguely remember trying to do something like using the search entry focus events to disable global shortcuts and it ended up being more trouble than it would've been worth. And yeah I should make it clear those shortcuts are for the editor and not the viewer, I'll switch that too.

👁 manan-gup

👁 manan-gup
manan-gup commented

Author

Contributor

Copy link