VOOZH about

URL: https://codereview.chromium.org/11125002/diff/11031/net/quic/crypto/null_decrypter.cc

⇱ net/quic/crypto/null_decrypter.cc - Issue 11125002: Add QuicFramer and friends. - Code Review


Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Keyboard Shortcuts

File
u :up to issue
j / k :jump to file after / before current file
J / K :jump to next file with a comment after / before current file
Side-by-side diff
i :toggle intra-line diffs
e :expand all comments
c :collapse all comments
s :toggle showing all comments
n / p :next / previous diff chunk or comment
N / P :next / previous comment
<Up> / <Down> :next / previous line
Issue
u :up to list of issues
j / k :jump to patch after / before current patch
o / <Enter> :open current patch in side-by-side view
i :open current patch in unified diff view
Issue List
j / k :jump to issue after / before current issue
o / <Enter> :open current issue
👁 Image
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(504)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: net/quic/crypto/null_decrypter.cc

👁 Image
Issue 11125002: Add QuicFramer and friends. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: narrowing in Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« net/quic/crypto/crypto_framer_test.cc ('K') | « net/quic/crypto/null_decrypter.h ('k') | net/quic/crypto/null_decrypter_test.cc » ('j') | net/quic/crypto/null_encrypter_test.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
(Empty)
// Copyright (c) 2012 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "net/quic/crypto/null_decrypter.h"
#include "net/quic/quic_utils.h"
#include "net/quic/quic_data_reader.h"
using base::StringPiece;
using std::string;
namespace net {
QuicData* NullDecrypter::Decrypt(StringPiece associated_data,
StringPiece ciphertext) {
LOG(INFO) << "here!";
jar (doing other things) 2012/10/14 23:04:38 nit: Do we want DLOG?
Ryan Hamilton 2012/10/15 21:22:08 Left over from some troubleshooting I'm doing. Wi
QuicDataReader reader(ciphertext.data(), ciphertext.length());
uint128 hash;
if (!reader.ReadUInt128(&hash)) {
return NULL;
}
LOG(INFO) << "here!";
StringPiece plaintext = reader.ReadRemainingPayload();
// TODO(rch): avoid buffer copy here
string buffer = associated_data.as_string();
plaintext.AppendToString(&buffer);
LOG(INFO) << "here!";
if (hash != QuicUtils::FNV1a_128_Hash(buffer.data(), buffer.length())) {
return NULL;
}
LOG(INFO) << "here!";
return new QuicData(plaintext.data(), plaintext.length());
}
} // namespace net
OLDNEW
« net/quic/crypto/crypto_framer_test.cc ('K') | « net/quic/crypto/null_decrypter.h ('k') | net/quic/crypto/null_decrypter_test.cc » ('j') | net/quic/crypto/null_encrypter_test.cc » ('J')
👁 Powered by Google App Engine
This is Rietveld 408576698