VOOZH about

URL: https://codereview.chromium.org/11125002/diff/11031/net/quic/quic_protocol.cc

⇱ net/quic/quic_protocol.cc - Issue 11125002: Add QuicFramer and friends. - Code Review


Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Keyboard Shortcuts

File
u :up to issue
j / k :jump to file after / before current file
J / K :jump to next file with a comment after / before current file
Side-by-side diff
i :toggle intra-line diffs
e :expand all comments
c :collapse all comments
s :toggle showing all comments
n / p :next / previous diff chunk or comment
N / P :next / previous comment
<Up> / <Down> :next / previous line
Issue
u :up to list of issues
j / k :jump to patch after / before current patch
o / <Enter> :open current patch in side-by-side view
i :open current patch in unified diff view
Issue List
j / k :jump to issue after / before current issue
o / <Enter> :open current issue
👁 Image
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: net/quic/quic_protocol.cc

👁 Image
Issue 11125002: Add QuicFramer and friends. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: narrowing in Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« net/quic/quic_protocol.h ('K') | « net/quic/quic_protocol.h ('k') | net/quic/quic_utils.h » ('j') | net/quic/quic_utils.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
(Empty)
// Copyright (c) 2012 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "net/quic/quic_protocol.h"
using base::StringPiece;
namespace net {
QuicStreamFragment::QuicStreamFragment() {}
QuicStreamFragment::QuicStreamFragment(QuicStreamId stream_id,
bool fin,
uint64 offset,
StringPiece data)
: stream_id(stream_id), fin(fin), offset(offset), data(data) {
jar (doing other things) 2012/10/14 23:04:38 nit: one member init per line (once you can't fit
Ryan Hamilton 2012/10/15 21:22:08 Done.
}
ReceivedPacketInfo::ReceivedPacketInfo() {}
ReceivedPacketInfo::~ReceivedPacketInfo() {}
SentPacketInfo::SentPacketInfo() {}
SentPacketInfo::~SentPacketInfo() {}
QuicFecData::QuicFecData() {}
QuicData::~QuicData() {
if (owns_buffer_) {
delete [] const_cast<char*>(buffer_);
}
jar (doing other things) 2012/10/14 23:04:38 nit: silly(?) personal pref to assign null to buff
Ryan Hamilton 2012/10/15 21:22:08 Leaving it.
}
} // namespace net
OLDNEW
« net/quic/quic_protocol.h ('K') | « net/quic/quic_protocol.h ('k') | net/quic/quic_utils.h » ('j') | net/quic/quic_utils.h » ('J')
👁 Powered by Google App Engine
This is Rietveld 408576698