VOOZH about

URL: https://phabricator.services.mozilla.com/D299375

⇱ ⚙ D299375 Bug 2037056 - Fix extra large VPN Status Checkbox in Overflow Menu. r=#ip-protection-reviewers


Bug 2037056 - Fix extra large VPN Status Checkbox in Overflow Menu. r=#ip-protection-reviewers
ClosedPublic

Authored by mhynson on May 8 2026, 2:09 PM.
Referenced Files
Unknown Object (File)
Tue, Jun 16, 9:38 AM
Unknown Object (File)
Mon, Jun 1, 10:27 AM
Unknown Object (File)
Mon, Jun 1, 7:16 AM
Unknown Object (File)
Mon, Jun 1, 7:16 AM
Unknown Object (File)
Mon, Jun 1, 5:48 AM
Unknown Object (File)
Mon, Jun 1, 5:48 AM
Unknown Object (File)
Mon, Jun 1, 4:30 AM
Unknown Object (File)
Sun, May 31, 7:15 PM
Subscribers

Diff Detail

Event Timeline

phab-bot published this revision for review.May 8 2026, 2:09 PM
phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: secure-revision.
dao requested changes to this revision.May 8 2026, 2:54 PM
dao added a subscriber: dao.
dao added inline comments.
browser/themes/shared/toolbarbutton-icons.css
334

Can this be instead?

This revision now requires changes to proceed.May 8 2026, 2:54 PM
mhynson updated this revision to Diff 1270254.
mhynson added inline comments.
browser/themes/shared/toolbarbutton-icons.css
334

Sure. This variable was an override of the original icon variable. Changing this to alone doesn't fix the issue so I updated the original value in

kpatenio added a subscriber: kpatenio.
kpatenio added inline comments.
browser/themes/shared/toolbarbutton-icons.css
333

Just wondering, is there a reason why we're hardcoding the 16px instead of using a token?

dao requested changes to this revision.May 8 2026, 7:53 PM
dao added inline comments.
browser/themes/shared/toolbarbutton-icons.css
333

Yeah, is already a token, defaulting to . Doesn't seem like you should have to override it here?

333–334

perhaps update these to referencing as well, for consistency

This revision now requires changes to proceed.May 8 2026, 7:53 PM
mhynson updated this revision to Diff 1270521.
mhynson marked an inline comment as done.
mhynson marked 2 inline comments as not done.
browser/themes/shared/toolbarbutton-icons.css
334

Disregard this comment. I'm going to work on a solution to focus on using existing tokens without conflict between the overflow and normal icons.

mhynson updated this revision to Diff 1271518.
Comment Actions

This is updated this to remove the use of and use more specificity to ensure the overflow icon is using .

dao requested changes to this revision.May 12 2026, 7:37 AM
dao added inline comments.
browser/themes/shared/toolbarbutton-icons.css
333–334

isn't needed here, please remove it

browser/themes/shared/toolbarbuttons.css
733

This seems to duplicate the rule in ? Surely one of the two should be redundant?

739–740

This also seems to duplicate the rule in . What's the actual DOM structure here, or ?

746–750

Is this still needed now that you're setting ?

This revision now requires changes to proceed.May 12 2026, 7:37 AM
mhynson updated this revision to Diff 1273051.
mhynson added inline comments.
browser/themes/shared/toolbarbuttons.css
739–740

I've reworked this to exclude the overflow state as opposed to setting the icon size here and then resetting it for the overflow state in toolbar-icons.css

746–750

Yes, this is still needed, specifically in the toolbar customization panel.

This revision is now accepted and ready to land.May 13 2026, 4:19 PM
Comment Actions

This revision requires a Testing Policy Project Tag to be set before landing. Please apply one of , , , , . Tip: this Firefox add-on makes it easy!

Revision Contents

PathSize
browser/
themes/
shared/
5 lines
11 lines
CommitTreeParentsAuthorSummaryDate
9b4cfc5b3f896b01dee79515Michael Hynson
Bug 2037056 - Fix extra large VPN Status Checkbox in Overflow Menu. r=ip… (Show More…)

Diff 1274443

browser/themes/shared/toolbarbutton-icons.css

Loading...

browser/themes/shared/toolbarbuttons.css

Loading...