note: @sthompson I have a try locally with this patch and D301960 applied locally, the icons that are being refreshed looks good to me (I try out manually how they looked like with and without nova, and confirmed the nova one to be shown when nova is enabled, nova + dark mode, nova + bidi, a non default theme light and dark and an addon card for an extension without any icon that would use the extensionGeneric.svg fallback icon, also regular and zoomed page).

And so I'm approving this patch as r+wc, where the comments are related to a few icons that are used by about:addons but not being refreshed in any of the patches in this patch stack (to double-check if they should, where to ask and track them). In a separate section at the end of this phabricator comment I'm also going to highlight a few that are being refreshed in the first patch from this patch stack (D301960) for completeness.

note: I'm mainly interested into determining what we should be doing with the ones that are not being refreshed in any of the patches in this patch stack:

to determine if there should be a followup for them (either in this patch or in a separate one), but beside that this patch looks good to me (and unless I'm mistaken non of the icons refreshed in this patch have any of the issues highlighted by Dao in D301960).

about:addons icons not refreshed in any of the patches in this patch stack

This one is used in the about:addons sidebar to represent the add-on type (and also the add-on type, where it is called but it is actually generated from at build time).

This icon will be shown in the about:addons sidebar when a dictionary or a langpack are installed.

I assume that we would like to refresh this icon for nova, sthompson should I ask in a specific nova slack channel?

I'd be ok with handling it in a separate phabricator revision if we prefer, as long as we are tracking it and highlighted the need to refresh this icon in the appropriate channels / docs.

This is basically a 180 degrees rotate version of , given that the icon refreshed for Nova is still a circle with an upward arrow like it currently is then I'd expect to also be refreshed but staying quite similar to the current icon.

Before porting the sidebar to moz-page-nav/moz-page-nav-button we used to be controlling the icon from the CSS side, and we could have opted to remove category-recent.svg and just rotate category-available.svg from the CSS rules, but now it is set by moz-page-nav-button as the src of an img tag inside moz-page-nav-button shadow DOM and so that wouldn't be possible anymore from aboutaddons.css.

At this point I guess the quickest option would be to refresh too as we are doing for .

this is used in the about:addons sidebar for the recommended view and for the badge shown on the recommended extensions (e.g. in a uBlock origin add-on card):

It doesn't seem to be used anywhere else (at least not anymore, it seems it was originally called competitiveness.svg and used in the now removed shopping component)

Questions for the short term:

• should we refresh this icon for nova?
• (as a potential short term followup on our side) should we rename into so that it is clear this is an about:addons specific icon while we are still keeping it around?

This one is used for the badge shown on the line extensions (the extensions owned by Mozilla, e.g. multi account containers):

It is basically a Firefox logo: https://searchfox.org/firefox-main/source/toolkit/themes/shared/extensions/line.svg

I'm not sure if this would need to be refreshed, I guess it depends if we are going to refresh the Firefox application icon.

about:addons icons refreshed by other patches in this patch stack

The following icons also used by about:addons page which are not in this revision but are still refreshed in another patch in this same patch stack (D301960):

• : this one is the one used for the mlmodel add-on type (it was the one chosen because it is also the one used to represent AI features elsewhere)
• : used fro the link to the nightly settings link in the sidebar (secondary-nav part of the moz-page-nav sidebar) and it is also currently used by the page options icon in the top-right corner of the about:addons page
• : used for the SUMO link in the sidebar (also in the secondary-nav part of the moz-page-nav sidebar)