Differential D303133
Bug 2043341: Add telemetry for innerHTML fragment parser. r=smaug Needs RevisionPublic Authored by bas on Thu, May 28, 5:30 PM. Tags
Referenced Files
Subscribers None
Diff Detail
Unit TestsUnsound
Event Timelinebas created this revision.Thu, May 28, 5:30 PM phab-bot published this revision for review.Thu, May 28, 5:30 PM phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)". phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)". phab-bot removed a project: secure-revision. Comment Actions This revision changes how Firefox collects data, so it needs a #data-classification tag. If you (the patch author) are adding new or modifying existing data collection, you and your reviewer(s) should judge how sensitive this data is, using the data collection categories Mozilla uses. If the data you are collecting fits in either the Category 1 “technical data” or Category 2 “interaction data” described there, please add the #data-classification-low tag. If it’s any other category, or you and your reviewer(s) disagree, please add the #data-classification-high tag, and go through the sensitive data collection review process. If you think that the data in question fits in “technical” or “interaction” data but would benefit from additional review, you can also explicitly choose to use the #data-classification-high tag and thereby opt in to the sensitive data collection review process. When using Glean for the data collection, the data classification of the new or expanded data collections should match the property in the metric definitions. If you are removing data collection, or are making mechanical changes to these files that do not add or modify what data is collected, change when or how it is collected, please add the data-classification-unnecessary tag. If you are unsure or feel uncomfortable making this assessment yourself, please ask the data-stewards group for help. Whichever tag is used, please leave a comment explaining this choice. Note that Lando will not be able to land this revision until the revision has one of these tags and you remove the #needs-data-classification tag. Finally, you as a patch author are encouraged to add the right tags yourself, but your reviewers are responsible for making sure the right tag is used. bas edited projects, added Restricted Project, testing-exception-unchanged (Doesn't change behavior for users); removed Restricted Project.Thu, May 28, 5:32 PM smaug requested changes to this revision.Thu, May 28, 7:17 PM Comment ActionsThis will most likely show up in sp3 results. Ask review again once there are some sp3 tests results proving me wrong. This revision now requires changes to proceed.Thu, May 28, 7:17 PM
Revision Contents
Diff 1285774 |
