VOOZH about

URL: https://phabricator.services.mozilla.com/D303133

⇱ ⚙ D303133 Bug 2043341: Add telemetry for innerHTML fragment parser. r=smaug


Bug 2043341: Add telemetry for innerHTML fragment parser. r=smaug
Needs RevisionPublic

Authored by bas on Thu, May 28, 5:30 PM.
Referenced Files
Unknown Object (File)
Wed, Jun 10, 3:07 PM
Unknown Object (File)
Sun, Jun 7, 6:07 AM
Unknown Object (File)
Sat, Jun 6, 10:18 PM
Unknown Object (File)
Thu, Jun 4, 5:19 AM
Unknown Object (File)
Thu, Jun 4, 4:53 AM
Unknown Object (File)
Thu, Jun 4, 12:11 AM
Unknown Object (File)
Wed, Jun 3, 10:08 PM
Unknown Object (File)
Mon, Jun 1, 5:56 PM
Subscribers
None

Details

Reviewers
smaug
Bugzilla Bug ID
2043341

Diff Detail

Repository
rFIREFOXAUTOLAND firefox-autoland
Branch
HEAD

Unit TestsUnsound

TimeTest
0 mscode-review::mercurial
WARNING: The base revision of your patch is not available in the current repository. Your patch has been rebased on central (revision default): issues may be positioned at the wrong lines.

Event Timeline

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: secure-revision.
Comment Actions

This revision changes how Firefox collects data, so it needs a #data-classification tag.

If you (the patch author) are adding new or modifying existing data collection, you and your reviewer(s) should judge how sensitive this data is, using the data collection categories Mozilla uses. If the data you are collecting fits in either the Category 1 “technical data” or Category 2 “interaction data” described there, please add the #data-classification-low tag. If it’s any other category, or you and your reviewer(s) disagree, please add the #data-classification-high tag, and go through the sensitive data collection review process. If you think that the data in question fits in “technical” or “interaction” data but would benefit from additional review, you can also explicitly choose to use the #data-classification-high tag and thereby opt in to the sensitive data collection review process.

When using Glean for the data collection, the data classification of the new or expanded data collections should match the property in the metric definitions.

If you are removing data collection, or are making mechanical changes to these files that do not add or modify what data is collected, change when or how it is collected, please add the data-classification-unnecessary tag.

If you are unsure or feel uncomfortable making this assessment yourself, please ask the data-stewards group for help.

Whichever tag is used, please leave a comment explaining this choice. Note that Lando will not be able to land this revision until the revision has one of these tags and you remove the #needs-data-classification tag.

Finally, you as a patch author are encouraged to add the right tags yourself, but your reviewers are responsible for making sure the right tag is used.

smaug requested changes to this revision.Thu, May 28, 7:17 PM
Comment Actions

This will most likely show up in sp3 results. Ask review again once there are some sp3 tests results proving me wrong.
Also, what would we do with this information?

This revision now requires changes to proceed.Thu, May 28, 7:17 PM

Revision Contents

PathSize
dom/
base/
10 lines
15 lines
CommitTreeParentsAuthorSummaryDate
1a3dacbc0dd69c8a1c05276593356bb24b19Bas Schouten
Bug 2043341: Add telemetry for innerHTML fragment parser. r=smaug (Show More…)
Thu, May 28, 5:24 PM

Diff 1285774

dom/base/FragmentOrElement.cpp

Loading...

dom/metrics.yaml

Loading...