Differential D303238
Bug 2035251 - Add shared toolkit pdf.svg icon and use for the save-as-pdf Quick Action. r?#desktop-theme-reviewers,calixte ClosedPublic Authored by sfoster on Fri, May 29, 12:24 AM. Referenced Files
Subscribers None
Details
Diff Detail
Event Timelinesfoster planned changes to this revision.Fri, May 29, 12:24 AM sfoster created this revision. phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".Fri, May 29, 12:26 AM phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)". phab-bot removed a project: secure-revision. sfoster planned changes to this revision.Fri, May 29, 12:30 AM sfoster updated this revision to Diff 1286194. sfoster added a comment.Fri, May 29, 12:37 AM Comment Actionssfoster requested review of this revision.Fri, May 29, 5:49 PM sfoster updated this revision to Diff 1286978. sfoster retitled this revision from WIP: Bug 2035251 - Add shared toolkit pdf.svg icon, use it in pdfjs viewer.html. to Bug 2035251 - Add shared toolkit pdf.svg icon for use in pdfjs. r?#desktop-theme-reviewers. sfoster added a reviewer: desktop-theme-reviewers. Herald added 1 blocking reviewer(s): desktop-theme-reviewers. · View Herald TranscriptFri, May 29, 5:49 PM sfoster added a comment.Fri, May 29, 6:01 PM Comment ActionsWe had some discussion about where the icon should live. AIUI the plan is for it to be a shared icon, in toolkit. I put it in the desktop manifest for now. If gecko-view wants to use it, we can move it to the other manifest. The pdf.js viewer.html changes to use the new icon will be a PR for that repo and get merged back once this icon has landed. sfoster retitled this revision from Bug 2035251 - Add shared toolkit pdf.svg icon for use in pdfjs. r?#desktop-theme-reviewers to Bug 2035251 - Add shared toolkit pdf.svg icon for use in pdfjs. r?#desktop-theme-reviewers,calixte. calixte accepted this revision.Fri, May 29, 7:04 PM calixte added a project: testing-exception-ui (Only changes ui styling, images, or localized strings). Comment ActionsThank you for doing this. sfoster added inline comments.Mon, Jun 1, 6:55 PM
sfoster retitled this revision from Bug 2035251 - Add shared toolkit pdf.svg icon for use in pdfjs. r?#desktop-theme-reviewers,calixte to Bug 2035251 - Add shared toolkit pdf.svg icon and use for the save-as-pdf Quick Action. r?#desktop-theme-reviewers,calixte. sfoster added a comment.Mon, Jun 1, 10:30 PM Comment ActionsI redrew the icon a bit. The document shape was a bit uneven with different corner radii. I made the dog-ear filled with the stroke color (so, white on black) instead of being transparent. I obviously don't feel super strongly about the icon details but it is more legible now I think (we were losing the "f" in PDF) and we can easily iterate on the SVG itself - the main thing is to get it in-tree. sfoster added a comment.Mon, Jun 1, 10:32 PM Comment ActionsOh and made use of the new icon in the save-as-pdf quick action at Dao's suggestion, which is more appropriate there vs. the print icon we were using, and removes the need for the unused asset test exception. sfoster added a comment.Mon, Jun 1, 10:34 PM Comment ActionsHere's the result again with vertical tabs + theme sfoster attached a referenced file: F71754515: pdfjs-icon-lwt-vertical-tabs.png. (Show Details)Mon, Jun 1, 10:35 PM dao accepted this revision.Tue, Jun 2, 8:39 AM This revision is now accepted and ready to land.Tue, Jun 2, 8:39 AM Closed by commit rFIREFOXAUTOLAND41d3cd66fd2f: Bug 2035251 - Add shared toolkit pdf.svg icon and use for the save-as-pdf Quick… (authored by sfoster). · Explain WhyTue, Jun 2, 9:31 PM This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 1289942 | ||||||||||||||||||||||||||||||||||||||||||||||||||||||
 |
VOOZH | about |
