Differential D303684

Bug 2043958 - Increase status panel padding on macOS Tahoe. r?#desktop-theme-reviewers
ClosedPublic
Actions

Authored by sam on Mon, Jun 1, 12:41 AM.

Details

Reviewers

dao

Group Reviewers

desktop-theme-reviewers

tabbrowser-reviewers

Commits

rFIREFOXAUTOLAND99336de52cfe: Bug 2043958 - Increase status panel padding on macOS Tahoe. r=desktop-theme…

Bugzilla Bug ID

2043958

Summary

On macOS Tahoe, it is very difficult to correctly identify the first letter on the status panel, because it is obscured by the large window corner radius. For example, it is nearly impossible to tell whether a link starts with a "j" or "i", or if it starts with a "o" or "p". Increasing the padding slightly is enough to make the letter fully visible.

Diff Detail

Repository: rFIREFOXAUTOLAND firefox-autoland

Event Timeline

sam created this revision.Mon, Jun 1, 12:41 AM

Herald added a project: secure-revision. · View Herald TranscriptMon, Jun 1, 12:42 AM

phab-bot published this revision for review.Mon, Jun 1, 12:42 AM

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".

phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".

phab-bot removed a project: secure-revision.

Herald added a reviewer: tabbrowser-reviewers. · View Herald TranscriptMon, Jun 1, 12:42 AM

Herald added 1 blocking reviewer(s): desktop-theme-reviewers. · View Herald Transcript

Harbormaster completed remote builds in B978354: Diff 1287816.Mon, Jun 1, 1:13 AM

dao accepted this revision.Mon, Jun 1, 8:27 AM

dao added a project: testing-exception-ui (Only changes ui styling, images, or localized strings).

dao added a subscriber: dao.

dao added inline comments.

browser/themes/shared/tabbrowser/content-area.css
504	Could you please add a bit of documentation here, perhaps just a shortened version of what you said in the commit message? Something like: "Slightly increasing the padding to prevent the first letter from partially getting cut off by the large window corner radius." Thanks!

This revision is now accepted and ready to land.Mon, Jun 1, 8:27 AM

sam updated this revision to Diff 1288482.Mon, Jun 1, 4:35 PM

Harbormaster failed remote builds in B978865: Diff 1288482!Mon, Jun 1, 5:09 PM

sam marked an inline comment as done.Mon, Jun 1, 5:23 PM

This revision was landed with ongoing or failed builds.Mon, Jun 1, 8:10 PM

Closed by commit rFIREFOXAUTOLAND99336de52cfe: Bug 2043958 - Increase status panel padding on macOS Tahoe. r=desktop-theme… (authored by sam). · Explain Why

This revision was automatically updated to reflect the committed changes.

sam added a commit: rFIREFOXAUTOLAND99336de52cfe: Bug 2043958 - Increase status panel padding on macOS Tahoe. r=desktop-theme….

sam mentioned this in D304288: Bug 2043958 - Increase status panel padding on macOS Tahoe..Tue, Jun 2, 9:39 PM

rvandermeulen@mozilla.com <rvandermeulen@mozilla.com> mentioned this in rFIREFOXBETA03732134d0a0: Bug 2043958 - Increase status panel padding on macOS Tahoe. a=RyanVM DONTBUILD.Wed, Jun 3, 1:49 AM

rvandermeulen@mozilla.com <rvandermeulen@mozilla.com> mentioned this in rFIREFOXRELEASE03732134d0a0: Bug 2043958 - Increase status panel padding on macOS Tahoe. a=RyanVM DONTBUILD.Wed, Jun 10, 6:42 PM

sam mentioned this in rFIREFOXBETA99336de52cfe: Bug 2043958 - Increase status panel padding on macOS Tahoe. r=desktop-theme….Mon, Jun 15, 12:18 PM