VOOZH about

URL: https://phabricator.services.mozilla.com/D305789

⇱ ⚙ D305789 Bug 2045993: Apply proper colors for the search mode switcher


Bug 2045993: Apply proper colors for the search mode switcher
Needs ReviewPublic

Authored by daisuke on Wed, Jun 10, 7:30 AM.
Tags
None
Referenced Files
F72923954: D305789.1781795516.diff
Wed, Jun 17, 3:11 PM
Unknown Object (File)
Sun, Jun 14, 10:49 PM
F72436205: Screenshot 2026-06-10 at 6.07.55 PM.png
Thu, Jun 11, 1:21 AM
Subscribers
None

Details

Reviewers
adw
dao
Group Reviewers
desktop-theme-reviewers
urlbar-reviewers
Bugzilla Bug ID
2045993

Diff Detail

Repository
rFIREFOXAUTOLAND firefox-autoland
Branch
HEAD

Event Timeline

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: secure-revision.
Comment Actions

Figma doesn't specify per-state colors (hover/active/focus), and the button color doesn't change between states in Proton, so I made the search mode switcher button color unchanged across states. If it should change per state, let me know!
https://www.figma.com/design/PqfaOcMGbX5liEXTTUzeYX/Nova-Components--Experimental-?node-id=538-20813&p=f&t=NwPou4zaWa94tvWA-0

daisuke retitled this revision from Bug 2045993: Not change the search mode switcher button color by the status to Bug 2045993: Don't change the search mode switcher button color per state.
Comment Actions

Thanks Daisuke, the Components Figma does show different states for the switcher: default, hover, active, and focused. See the "Searchmode Switcher" card here (hope this is the right link): https://www.figma.com/design/PqfaOcMGbX5liEXTTUzeYX/Nova-Components--Experimental-?node-id=538-30073&m=dev

Each state uses a different member of the token group for its background color, e.g., .

However, the chevron and "X" have the same color in all four states afaict: . I've asked Jessica in a Figma comment if that's correct. I guess we should wait and see what she says before continuing with this patch.

If you want to fix the background color for each state as part of that patch, feel free. Otherwise could you file a new bug please?

Comment Actions

Oh, thank you very much!
I will update the background now, then wait for the X color.

daisuke retitled this revision from Bug 2045993: Don't change the search mode switcher button color per state to Bug 2045993: Apply proper colors for the search mode switcher.
Comment Actions

I talked with Jules and they have a large tokens patch in D306443 that fixes this bug, the bg color per state, and multiple other things. It's still marked WIP but hopefully we will end up taking it, and if so, we can abandon this revision. Thanks for your work on it Daisuke!

Revision Contents

PathSize
browser/
themes/
shared/
29 lines
CommitTreeParentsAuthorSummaryDate
1ee4a29d8b48e361e39e7773be8973051d82Daisuke Akatsuka
Bug 2045993: Apply proper colors for the search mode switcher (Show More…)
Wed, Jun 10, 7:42 AM

Diff 1297272

browser/themes/shared/urlbar-searchbar.css

Loading...