VOOZH about

URL: https://phabricator.services.mozilla.com/D306523

⇱ ⚙ D306523 Bug 2046132 - additional Nova icon updates r=#desktop-theme-reviewers!


Bug 2046132 - additional Nova icon updates r=#desktop-theme-reviewers!
ClosedPublic

Authored by sthompson on Fri, Jun 12, 7:58 PM.

Details

Summary

14 more icons plus 3 reversions based on:

  • mappings I missed but the icon designers flagged
  • icon assets updated by icon designers
  • redrawn icons added to the acorn-icons repo
  • revert icons that need to be redrawn in order to land without visual regressions

Diff Detail

Event Timeline

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: secure-revision.
sfoster added a subscriber: sfoster.
Comment Actions

The changes look sensible & correct. I've not done a visual inspection of each in-situ. Hopefully someone has? Its not always easy to find where each icon is used.

sthompson edited the summary of this revision. (Show Details)
Comment Actions

Needed to make some updates:

  • promote fill/fill-opacity attributes from <path> to <svg> on device-phone, device-vr, and forget so that the right CSS colors apply to Nova paths
  • don't update warning-fill-12 because it's a duotone icon (some paths use the fill color, some paths use the stroke color) and the acorn-icons version doesn't support that yet. Need to file a bug to follow up on it
Standard8 added a subscriber: Standard8.
Comment Actions

r=me for the places changes.

This revision is now accepted and ready to land.Tue, Jun 16, 8:50 PM
Comment Actions

This revision requires a Testing Policy Project Tag to be set before landing. Please apply one of , , , , . Tip: this Firefox add-on makes it easy!

Revision Contents

PathSize
browser/
themes/
shared/
icons/
13 lines
17 lines
20 lines
18 lines
17 lines
13 lines
2 lines
13 lines
13 lines
places/
14 lines
14 lines
tabbrowser/
2 lines
toolkit/
themes/
shared/
icons/
14 lines
14 lines
13 lines
15 lines
13 lines
CommitTreeParentsAuthorSummaryDate
f82937bc5f455e31ec2636e3Stephen Thompson
Bug 2046132 - additional Nova icon updates r=desktop-theme-reviewers,tabbrowser… (Show More…)

Diff 1302537

browser/themes/shared/icons/bookmark-12.svg

Loading...

browser/themes/shared/icons/device-phone.svg

Loading...

browser/themes/shared/icons/device-vr.svg

Loading...

browser/themes/shared/icons/forget.svg

Loading...

browser/themes/shared/icons/pin-12.svg

Loading...

browser/themes/shared/icons/privateBrowsing.svg

Loading...

browser/themes/shared/icons/sync.svg

Loading...

browser/themes/shared/icons/thumb-down.svg

Loading...

browser/themes/shared/icons/translations.svg

Loading...

browser/themes/shared/places/folder-smart.svg

Loading...

browser/themes/shared/places/tag.svg

Loading...

browser/themes/shared/tabbrowser/tab-audio-playing-small.svg

Loading...

toolkit/themes/shared/icons/eye-slash.svg

Loading...

toolkit/themes/shared/icons/eye.svg

Loading...

toolkit/themes/shared/icons/minus.svg

Loading...

toolkit/themes/shared/icons/tab-notes-12.svg

Loading...

toolkit/themes/shared/icons/trophy.svg

Loading...