VOOZH about

URL: https://phabricator.services.mozilla.com/D306887

⇱ ⚙ D306887 Bug 2043516 - Update confirmation hint to use design tokens (Nova). r=mtigley

Paths

Bug 2043516 - Update confirmation hint to use design tokens (Nova). r=mtigley
Needs RevisionPublic

Authored by tmanku on Mon, Jun 15, 11:49 PM.

Details

Reviewers
mtigley
dao
Group Reviewers
desktop-theme-reviewers
Bugzilla Bug ID
2043516

Diff Detail

Repository
rFIREFOXAUTOLAND firefox-autoland
Branch
HEAD

Unit TestsBroken

TimeTest
0 mscode-review::general
WARNING: A generic error occurred in the code review bot.
0 mscode-review::mercurial
WARNING: The base revision of your patch is not available in the current repository. Your patch has been rebased on central (revision default): issues may be positioned at the wrong lines.

Event Timeline

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: secure-revision.
Itiel added inline comments.
browser/themes/shared/customizableui/panelUI-shared.css
388

These can also be tokenized

389

I don't think this works in chrome yet? See D306865

dao requested changes to this revision.Tue, Jun 16, 8:53 AM
dao added a subscriber: dao.
Comment Actions

Requesting changes as per @Itiel's comments. Thanks!

This revision now requires changes to proceed.Tue, Jun 16, 8:53 AM
browser/themes/shared/customizableui/panelUI-shared.css
388

Thank you so much, @Itiel! I'm not seeing an appropriate design token to replace the hard-coded padding values. Would it be best to round both up or down to the nearest token or use with fractional multipliers?

--panel-padding: var(--space-xsmall) var(--space-small); // round down, approx. 4px 8px
--panel-padding: var(--space-small) var(--space-medium); // round up, approx. 8px 12px
--panel-padding: calc(0.375*var(--space-large)) calc(0.625*var(--space-large)); // approx. 6px 10px
browser/themes/shared/customizableui/panelUI-shared.css
388

I was referring to rounding up/down, whatever looks better and not too cramped/spacious.
Using calc() to get the previous non-token values defeats the purpose of these tokens...

Revision Contents

PathSize
browser/
themes/
shared/
customizableui/
8 lines
CommitTreeParentsAuthorSummaryDate
6efa4b6aa3f035d1b929e76eac8f36a95301Tanvi Manku
Bug 2043516 - Update confirmation hint to use design tokens (Nova). r=mtigley (Show More…)
Mon, Jun 15, 11:43 PM

Diff 1300741

browser/themes/shared/customizableui/panelUI-shared.css

Loading...