| • dmaza |
| Mar 18 2019, 4:17 PM |
| F28420850: (PNG Image, 586 × 308 pixels).png |
| Mar 19 2019, 3:11 PM |
Description
This measurement is not being used anymore. We should maybe look at it one last time and remove the existing code for it
https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/core/+/master/includes/user/User.php#1419
This is a snapshot of the data produced.
https://graphite.wikimedia.org/render/?width=586&height=308&target=MediaWiki.block.ipblock.setCookie.success.sum
This was added as part of T152462: Add cookie when blocking anonymous users
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Remove block cookie stats measurement implementation | mediawiki/core | master | +0 -4 |
Related Objects
Event Timeline
Change 497507 had a related patch set uploaded (by Dmaza; owner: Dmaza):
[mediawiki/core@master] Remove block cookie stats measurement implementation
@dmaza Will this also remove the existing data? If so, do you think it's worth keeping a copy of it?
@Niharika the patch will not remove the data but I'm not sure for how long we keep those metrics around. I can't find anything on wikitech about it.
Change 497507 merged by jenkins-bot:
[mediawiki/core@master] Remove block cookie stats measurement implementation
@dmaza I think we might only be keeping the last 90 days worth of data. So 90 days later, all the data will be gone. That's my guess.
That would make sense. IMO I don't think this data is worth keeping. Pinging @Tchanders @dbarratt @aezell for their thoughts.