VOOZH about

URL: https://reviews.freebsd.org/D3739

⇱ ⚙ D3739 devel/boost-*: convert to more option helpers

Paths

devel/boost-*: convert to more option helpers
ClosedPublic

Authored by jbeich on Sep 27 2015, 10:38 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 8, 10:41 PM
Unknown Object (File)
Wed, Apr 8, 6:36 AM
Unknown Object (File)
Wed, Apr 8, 1:55 AM
Unknown Object (File)
Mon, Apr 6, 3:28 PM
Unknown Object (File)
Sat, Apr 4, 4:12 AM
Unknown Object (File)
Sat, Apr 4, 2:10 AM
Unknown Object (File)
Mon, Mar 23, 4:45 PM
Unknown Object (File)
Mon, Mar 23, 4:53 AM
Subscribers
None

Details

Summary

For simplicity it's better to avoid conditionals that rely on stuff in
bsd.port.pre.mk or bsd.port.options.mk. Also, as no one complained
about non-working *FLAGS, so I've removed them instead of:

CXXFLAGS_amd64=		-fPIC
CXXFLAGS_sparc64=	-O0

amd64 tried to pass via more than once while
sparc64 cannot be fixed without altering sanitizing in

BJAM_ARGS+= cxxflags="${CXXFLAGS:N-O*}" cflags="${CFLAGS:N-O*}"
Test Plan

should probably enable option by
default to make it easier to see which *FLAGS are used during build.
For the following builds I've put it into make.conf.

logs:

logs:

with some inverted options logs:

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jbeich retitled this revision from to devel/boost-*: convert to more option helpers.
jbeich updated this object.
jbeich edited the test plan for this revision. (Show Details)
jbeich added a reviewer: office.
truckman added a reviewer: truckman.
truckman edited edge metadata.
truckman removed a subscriber: truckman.
Comment Actions

Looks good to me.

This revision is now accepted and ready to land.Sep 27 2015, 6:25 PM
bapt added a reviewer: bapt.
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
head/
devel/
boost-all/
4 lines
boost-python-libs/
4 lines

Diff 8956

head/devel/boost-all/compiled.mk

Loading...

head/devel/boost-python-libs/Makefile

Loading...