Introduction
StringBuffer is a synchronized class for mutable strings. The main problem with making it synchronized is that
- It was usually used as a local variable so making it synchronized just made it slower.
- It was never a good idea to use it in a multi-threaded way. This problem is that developers assumed that methods which used StringBuffer were themselves thread safe when they were not.
The problem with StringBuffer
This is an example from a real class which is used in production in many trading systems. It’s not a commonly used but you might assume that StringBuffer gives you thread safety, when it doesn’t.
public void addProperty(String name, String value) {
if (value != null && value.length() > 0) {
if (sb.length() > 0) {
sb.append(',');
}
sb.append(name).append('=').append(value);
}
}While individual calls are thread safe, multiple calls are not. It is almost impossible to find a good use for StringBuffer that doesn’t involve multiple calls (including toString)
A puzzle
Imagine three threads call (in no particular order)
T1: addProperty("a", "b");
T2: addProperty("c", "d");
T3: sb.toString();write a program which will generate every possible output of T3’s sb.toString() I found 89. With thread safety, you might reduce this to 4.
Note
If you used StringBuilder it would be worse, but at least you might not assume your method is thread safe when it is not. e.g. SimpleDateFormat uses StringBuffer
Reference: Why a synchronized StringBuffer was never a good idea from our JCG partner Peter Lawrey at the Vanilla Java blog.
Do you want to know how to develop your skillset to become a Java Rockstar?
Subscribe to our newsletter to start Rocking right now!
To get you started we give you our best selling eBooks for FREE!
1. JPA Mini Book
2. JVM Troubleshooting Guide
3. JUnit Tutorial for Unit Testing
4. Java Annotations Tutorial
5. Java Interview Questions
6. Spring Interview Questions
7. Android UI Design
and many more ....
I agree to the Terms and Privacy Policy
Thank you!
We will contact you soon.
Tags
Concurrency
👁 Photo of Peter Lawrey
Peter LawreyApril 26th, 2013Last Updated: April 26th, 2013
Peter LawreyApril 26th, 2013Last Updated: April 26th, 2013
2 104 1 minute read

This site uses Akismet to reduce spam. Learn how your comment data is processed.
>While individual calls are thread safe, multiple calls are not.
It would be better for understanding to name them not multiple but chained calls.
They do not necessarily need to be chained[1]. How about ‘consecutive’?
[1] http://en.wikipedia.org/wiki/Method_chaining