VOOZH about

URL: https://bugzilla.mozilla.org/1875083

⇱ 1875083 - Create test to ensure maxRenderCountEstimate is never being set to Infinity in virtual-list component in Fx View


Closed Bug 1875083 Opened 2 years ago Closed 1 month ago

Create test to ensure maxRenderCountEstimate is never being set to Infinity in virtual-list component in Fx View

Create test to ensure maxRenderCountEstimate is never being set to Infinity in virtual-list component in Fx View
Firefox
Firefox View
unspecified
Unspecified
Unspecified
task
Points:
---
RESOLVED FIXED
RESOLVED
FIXED
152 Branch
Iteration:
---
a11y-review
Accessibility Severity
Performance Impact
Webcompat Priority
Webcompat Score
Tracking Status
firefox152 --- fixed
Tracking Status
relnote-firefox
firefox-esr115
firefox-esr140
firefox-esr153
firefox152
firefox153
firefox154
---
[fidefe-firefox-view][outreachy-sidebar-2026]
QA Whiteboard:
[qa-triage-done-c153/b152]
Has STR:
---
Change Request:
---
Bug Flags:
Signature:
None
This bug is publicly visible.

 

Adding this as a follow-up to bug 1870141. We should add a test to make sure we don't fall into the same scenario in the future.

These were the original STR before the fix was added in bug 1870141:
With lots of open tabs (at least 100 or so), you can scroll down in the list so that it loads a few more of the sublists, then switch to another page in Fx View and then back to Open Tabs, and then you see the issue. When it returns to that page, it's initially getting 0 for the itemHeightEstimate (potentially due to changes from bug 1857634), and maxRenderCountEstimate is then being set to Infinity.

The test should recreate this scenario and make sure maxRenderCountEstimate is never being set to Infinity.

Priority: -- → P2
Mentor: kcochrane
Keywords: good-first-bug
Whiteboard: [fidefe-firefox-view] → [fidefe-firefox-view][outreachy-sidebar-2026]
Assignee: nobody → kelvinasante706
Status: NEW → ASSIGNED

Kindly assign it to me :kcochrane, I'd love to get my hands dirty with this

Assignee

Comment 2

2 months ago

can this be reassigned to me? it is over 24 hours already

Attachment #9559198 - Attachment is obsolete: true
Assignee

Comment 6

2 months ago
Flags: needinfo?(kcochrane)

There's no need to need info me or comment with the patch link. It automatically adds it to my review queue and adds it as an attachment in this bug.

Flags: needinfo?(kcochrane)
Assignee: kelvinasante706 → koladeelizabeth01
Assignee

Comment 8

2 months ago
Attachment #9567669 - Attachment description: Bug 1875083 - test for maxRenderCountEstimate r=kcochrane → Bug 1875083 - Create test to ensure maxRenderCountEstimate is never being set to Infinity r=Kelly Cochrane[:kcochrane]
Attachment #9568122 - Attachment is obsolete: true
Attachment #9567669 - Attachment description: Bug 1875083 - Create test to ensure maxRenderCountEstimate is never being set to Infinity r=Kelly Cochrane[:kcochrane] → Bug 1875083 - Create test to ensure maxRenderCountEstimate is never being set to Infinity r=kcochrane
Attachment #9567669 - Attachment description: Bug 1875083 - Create test to ensure maxRenderCountEstimate is never being set to Infinity r=kcochrane → Bug 1875083 - Create test to ensure maxRenderCountEstimate is never being set to Infinity r=kcochrane.

Comment 9

2 months ago
Pushed by kcochrane@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/b2ad6bca8c49 https://hg.mozilla.org/integration/autoland/rev/25eac62e323d Create test to ensure maxRenderCountEstimate is never being set to Infinity r=kcochrane,fxview-reviewers.

Comment 10

2 months ago
Pushed by sstanca@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/8abc00160d62 https://hg.mozilla.org/integration/autoland/rev/03e9ceeccea5 Revert "Bug 1875083 - Create test to ensure maxRenderCountEstimate is never being set to Infinity r=kcochrane,fxview-reviewers." for causing mochitests failures in browser_firefoxview_virtual_list.js.

Reverted this because it was causing mochitests failures in browser_firefoxview_virtual_list.js.

  • Revert link
  • Push with failures
  • Failure Log
  • Failure line: TEST-UNEXPECTED-FAIL | browser/components/firefoxview/tests/browser/browser_firefoxview_virtual_list.js | test_max_render_count_never_infinity - maxRenderCountEstimate should be finite when itemHeightEstimate is 0, got Infinity - false == true
Flags: needinfo?(koladeelizabeth01)
Pushed by kcochrane@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/bb3b34dcc3d2 https://hg.mozilla.org/integration/autoland/rev/cc2d48f6c50b Create test to ensure maxRenderCountEstimate is never being set to Infinity r=fxview-reviewers,nsharpley.

Comment 13

1 month ago
bugherder
Status: ASSIGNED → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
Target Milestone: --- → 152 Branch
QA Whiteboard: [qa-triage-done-c153/b152]
You need to log in before you can comment on or make changes to this bug.