Differential D290420
Bug 1875083 - Create test to ensure maxRenderCountEstimate is never being set to Infinity r=kcochrane AbandonedPublic Authored by flod on Mar 27 2026, 12:45 PM. Tags
Referenced Files
Details
Diff Detail
Event Timelinekoladeelizabeth01 created this revision.Mar 27 2026, 12:45 PM phab-bot published this revision for review.Mar 27 2026, 12:45 PM phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)". phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)". phab-bot removed a project: secure-revision. Comment Actions This revision changes how Firefox collects data, so it needs a #data-classification tag. If you (the patch author) are adding new or modifying existing data collection, you and your reviewer(s) should judge how sensitive this data is, using the data collection categories Mozilla uses. If the data you are collecting fits in either the Category 1 “technical data” or Category 2 “interaction data” described there, please add the #data-classification-low tag. If it’s any other category, or you and your reviewer(s) disagree, please add the #data-classification-high tag, and go through the sensitive data collection review process. If you think that the data in question fits in “technical” or “interaction” data but would benefit from additional review, you can also explicitly choose to use the #data-classification-high tag and thereby opt in to the sensitive data collection review process. When using Glean for the data collection, the data classification of the new or expanded data collections should match the property in the metric definitions. If you are removing data collection, or are making mechanical changes to these files that do not add or modify what data is collected, change when or how it is collected, please add the data-classification-unnecessary tag. If you are unsure or feel uncomfortable making this assessment yourself, please ask the data-stewards group for help. Whichever tag is used, please leave a comment explaining this choice. Note that Lando will not be able to land this revision until the revision has one of these tags and you remove the #needs-data-classification tag. Finally, you as a patch author are encouraged to add the right tags yourself, but your reviewers are responsible for making sure the right tag is used. phab-bot removed reviewers: Restricted Project, anti-tracking-reviewers-rotation, reusable-components-reviewers-rotation, sidebar-reviewers-rotation, toolkit-telemetry-reviewers-rotation. phab-bot added subscribers: Restricted Project, anti-tracking-reviewers-rotation, reusable-components-reviewers-rotation and 2 others. Comment Actions You've pushed a patch that is making changes in areas of Performance Testing. Please ensure that all the documentation related to this change is updated. Additionally, please ensure that documentation is added for any new features, workarounds, or enhancements. You can find the existing documentation for Performance Testing here: https://firefox-source-docs.mozilla.org/testing/perfdocs/ Comment Actions @koladeelizabeth01 can you please provide a mach try perf push link for these changes ? Thanks! jcristau requested changes to this revision.Mar 27 2026, 12:59 PM Comment ActionsThis makes a lot of changes that are presumably unintended. This revision now requires changes to proceed.Mar 27 2026, 12:59 PM Comment Actions Code analysis found 2 defects in diff 1235060:
WARNING: Found 2 defects (warning level) that can be dismissed.
You can run this analysis locally with: NOTE: 21 documentation files were modified in diff 1235060
They can be previewed for one week: NOTE: Tasks were added or removed in diff 1235060.
The following parameter sets have differences: If you see a problem in this automated review, please report it here. You can view these defects in the Diff Detail section of Phabricator diff 1235060. bwc requested changes to this revision.Mar 27 2026, 3:06 PM Comment ActionsIt looks like a large number of recent changes to mozilla-central were somehow rolled up into this patch, possibly due to operator error with git. sparky requested changes to this revision.Mar 31 2026, 7:03 PM Comment ActionsIt might be simpler to abandon this patch and recreate it with your actual changes. There are a ton of unrelated changes here from other patches that have already landed. flod commandeered this revision.Apr 1 2026, 5:33 AM flod added a reviewer: koladeelizabeth01. Comment ActionsGoing to take over and abandon, at this point this is creating unnecessary noise for a ton of people. flod abandoned this revision.Apr 1 2026, 5:34 AM Large DiffThis large diff affects 708 files. Files without inline comments have been collapsed. Expand All Files
Revision Contents
Diff 1235060 browser/components/aiwindow/models/tests/xpcshell/ai-window-prompts-remote-settings-snapshot.jsonbrowser/components/aiwindow/ui/components/website-chip-container/website-chip-container.cssbrowser/components/defaultwindowslaunchonlogin/DefaultWindowsLaunchOnLogin.sys.mjsbrowser/components/defaultwindowslaunchonlogin/tests/test_nimbus_defaultWindowsLaunchOnLogin_firstStartup.jsbrowser/components/firefoxview/tests/browser/browser_firefoxview_virtual_list.jsbrowser/components/preferences/tests/browser_experimental_features_hidden_when_not_public.jsbrowser/components/preferences/tests/browser_experimental_features_studies_disabled.jsbrowser/components/preferences/tests/browser_no_id_collision_between_categories_and_mainPane.jsbrowser/components/profiles/tests/browser/browser_update_profile_on_window_switch.jsbrowser/components/tabbrowser/test/browser/tabs/browser_tab_splitview_telemetry.jsdevtools/client/inspector/computed/test/browser_computed_matched-selectors_01.jsdevtools/client/inspector/rules/test/browser_rules_add-rule-then-property-edit-selector.jsdom/webgpu/tests/cts/checkout/src/webgpu/shader/execution/shader_io/compute_builtins.spec.tsdom/webgpu/tests/cts/checkout/src/webgpu/shader/validation/extension/readonly_and_readwrite_storage_textures.spec.tsdom/webgpu/tests/cts/checkout/src/webgpu/shader/validation/shader_io/builtins.spec.tslayout/reftests/scrolling/webkit-scrollbar-display-none-scrollbar-width-thin-ref.htmllayout/reftests/scrolling/webkit-scrollbar-display-none-scrollbar-width-thin.htmllayout/reftests/scrolling/webkit-scrollbar-display-none-with-scrollbar-width-none.htmlmobile/android/android-components/components/browser/state/src/main/java/mozilla/components/browser/state/action/BrowserAction.ktmobile/android/android-components/components/browser/state/src/main/java/mozilla/components/browser/state/reducer/TranslationsStateReducer.ktmobile/android/android-components/components/browser/state/src/main/java/mozilla/components/browser/state/state/TranslationsBrowserState.ktmobile/android/android-components/components/browser/state/src/test/java/mozilla/components/browser/state/action/TranslationsActionTest.ktmobile/android/android-components/components/compose/awesomebar/src/main/res/values-is/strings.xmlmobile/android/android-components/components/compose/awesomebar/src/main/res/values-sl/strings.xmlmobile/android/android-components/components/feature/addons/src/main/res/values-am/strings.xmlmobile/android/android-components/components/feature/addons/src/main/res/values-ar/strings.xmlmobile/android/android-components/components/feature/addons/src/main/res/values-ast/strings.xmlmobile/android/android-components/components/feature/addons/src/main/res/values-be/strings.xmlmobile/android/android-components/components/feature/addons/src/main/res/values-bg/strings.xmlmobile/android/android-components/components/feature/addons/src/main/res/values-bqi/strings.xmlmobile/android/android-components/components/feature/addons/src/main/res/values-br/strings.xmlmobile/android/android-components/components/feature/addons/src/main/res/values-bs/strings.xmlmobile/android/android-components/components/feature/addons/src/main/res/values-ca/strings.xmlmobile/android/android-components/components/feature/addons/src/main/res/values-co/strings.xmlmobile/android/android-components/components/feature/addons/src/main/res/values-cs/strings.xmlmobile/android/android-components/components/feature/addons/src/main/res/values-cy/strings.xmlmobile/android/android-components/components/feature/addons/src/main/res/values-da/strings.xmlmobile/android/android-components/components/feature/addons/src/main/res/values-de/strings.xmlmobile/android/android-components/components/feature/addons/src/main/res/values-dsb/strings.xmlmobile/android/android-components/components/feature/addons/src/main/res/values-el/strings.xmlmobile/android/android-components/components/feature/addons/src/main/res/values-en-rCA/strings.xmlmobile/android/android-components/components/feature/addons/src/main/res/values-en-rGB/strings.xmlmobile/android/android-components/components/feature/addons/src/main/res/values-eo/strings.xmlmobile/android/android-components/components/feature/addons/src/main/res/values-es-rAR/strings.xmlmobile/android/android-components/components/feature/addons/src/main/res/values-es-rCL/strings.xmlmobile/android/android-components/components/feature/addons/src/main/res/values-es-rES/strings.xmlmobile/android/android-components/components/feature/addons/src/main/res/values-es-rMX/strings.xmlmobile/android/android-components/components/feature/addons/src/main/res/values-et/strings.xmlmobile/android/android-components/components/feature/addons/src/main/res/values-eu/strings.xmlmobile/android/android-components/components/feature/addons/src/main/res/values-fa/strings.xmlmobile/android/android-components/components/feature/addons/src/main/res/values-fi/strings.xmlmobile/android/android-components/components/feature/addons/src/main/res/values-fr/strings.xmlmobile/android/android-components/components/feature/addons/src/main/res/values-fur/strings.xmlmobile/android/android-components/components/feature/addons/src/main/res/values-fy-rNL/strings.xmlmobile/android/android-components/components/feature/addons/src/main/res/values-gd/strings.xmlmobile/android/android-components/components/feature/addons/src/main/res/values-gl/strings.xmlmobile/android/android-components/components/feature/addons/src/main/res/values-gn/strings.xmlmobile/android/android-components/components/feature/addons/src/main/res/values-hr/strings.xmlmobile/android/android-components/components/feature/addons/src/main/res/values-hsb/strings.xmlmobile/android/android-components/components/feature/addons/src/main/res/values-hu/strings.xmlmobile/android/android-components/components/feature/addons/src/main/res/values-hy-rAM/strings.xmlmobile/android/android-components/components/feature/addons/src/main/res/values-ia/strings.xmlmobile/android/android-components/components/feature/addons/src/main/res/values-in/strings.xmlmobile/android/android-components/components/feature/addons/src/main/res/values-is/strings.xmlmobile/android/android-components/components/feature/addons/src/main/res/values-it/strings.xmlmobile/android/android-components/components/feature/addons/src/main/res/values-iw/strings.xmlmobile/android/android-components/components/feature/addons/src/main/res/values-ja/strings.xmlmobile/android/android-components/components/feature/addons/src/main/res/values-ka/strings.xmlmobile/android/android-components/components/feature/addons/src/main/res/values-kab/strings.xmlmobile/android/android-components/components/feature/addons/src/main/res/values-kk/strings.xmlmobile/android/android-components/components/feature/addons/src/main/res/values-km/strings.xmlmobile/android/android-components/components/feature/addons/src/main/res/values-kmr/strings.xmlmobile/android/android-components/components/feature/addons/src/main/res/values-ko/strings.xmlmobile/android/android-components/components/feature/addons/src/main/res/values-lo/strings.xmlmobile/android/android-components/components/feature/addons/src/main/res/values-ml/strings.xmlmobile/android/android-components/components/feature/addons/src/main/res/values-nb-rNO/strings.xmlmobile/android/android-components/components/feature/addons/src/main/res/values-nl/strings.xmlmobile/android/android-components/components/feature/addons/src/main/res/values-nn-rNO/strings.xmlmobile/android/android-components/components/feature/addons/src/main/res/values-oc/strings.xmlmobile/android/android-components/components/feature/addons/src/main/res/values-pa-rIN/strings.xmlmobile/android/android-components/components/feature/addons/src/main/res/values-pl/strings.xmlmobile/android/android-components/components/feature/addons/src/main/res/values-pt-rBR/strings.xmlmobile/android/android-components/components/feature/addons/src/main/res/values-pt-rPT/strings.xmlmobile/android/android-components/components/feature/addons/src/main/res/values-rm/strings.xmlmobile/android/android-components/components/feature/addons/src/main/res/values-ro/strings.xmlmobile/android/android-components/components/feature/addons/src/main/res/values-ru/strings.xmlmobile/android/android-components/components/feature/addons/src/main/res/values-sat/strings.xmlmobile/android/android-components/components/feature/addons/src/main/res/values-sc/strings.xmlmobile/android/android-components/components/feature/addons/src/main/res/values-scn/strings.xmlmobile/android/android-components/components/feature/addons/src/main/res/values-sk/strings.xmlmobile/android/android-components/components/feature/addons/src/main/res/values-sl/strings.xmlmobile/android/android-components/components/feature/addons/src/main/res/values-sq/strings.xmlmobile/android/android-components/components/feature/addons/src/main/res/values-sr/strings.xmlmobile/android/android-components/components/feature/addons/src/main/res/values-sv-rSE/strings.xmlmobile/android/android-components/components/feature/addons/src/main/res/values-tg/strings.xmlmobile/android/android-components/components/feature/addons/src/main/res/values-th/strings.xmlmobile/android/android-components/components/feature/addons/src/main/res/values-tl/strings.xmlmobile/android/android-components/components/feature/addons/src/main/res/values-tok/strings.xmlmobile/android/android-components/components/feature/addons/src/main/res/values-tr/strings.xmlmobile/android/android-components/components/feature/addons/src/main/res/values-trs/strings.xmlmobile/android/android-components/components/feature/addons/src/main/res/values-tt/strings.xmlmobile/android/android-components/components/feature/addons/src/main/res/values-ug/strings.xmlmobile/android/android-components/components/feature/addons/src/main/res/values-uk/strings.xmlmobile/android/android-components/components/feature/addons/src/main/res/values-vi/strings.xmlmobile/android/android-components/components/feature/addons/src/main/res/values-yua/strings.xmlmobile/android/android-components/components/feature/addons/src/main/res/values-zh-rCN/strings.xmlmobile/android/android-components/components/feature/addons/src/main/res/values-zh-rTW/strings.xmlmobile/android/android-components/components/feature/app-links/src/main/res/values-cs/strings.xmlmobile/android/android-components/components/feature/app-links/src/main/res/values-is/strings.xmlmobile/android/android-components/components/feature/app-links/src/main/res/values-pt-rBR/strings.xmlmobile/android/android-components/components/feature/app-links/src/main/res/values-sq/strings.xmlmobile/android/android-components/components/feature/app-links/src/main/res/values-trs/strings.xmlmobile/android/android-components/components/feature/app-links/src/main/res/values-zh-rCN/strings.xmlmobile/android/android-components/components/lib/crash/src/androidTest/java/mozilla/components/lib/crash/service/GleanCrashReporterServiceTest.ktmobile/android/android-components/components/lib/crash/src/main/java/mozilla/components/lib/crash/service/GleanCrashReporterService.ktmobile/android/android-components/components/lib/crash/src/main/java/mozilla/components/lib/crash/service/MozillaSocorroService.ktmobile/android/android-components/components/lib/crash/src/test/java/mozilla/components/lib/crash/service/MozillaSocorroServiceTest.ktmobile/android/android-components/components/ui/icons/src/main/res/drawable/mozac_ic_private_mode_24.xmlmobile/android/android-components/components/ui/icons/src/main/res/drawable/mozac_ic_private_mode_fill_24.xmlmobile/android/android-components/components/ui/tabcounter/src/main/java/mozilla/components/ui/tabcounter/TabCounterMenu.ktmobile/android/fenix/app/src/main/java/org/mozilla/fenix/browser/TranslationsBinding.ktmobile/android/fenix/app/src/main/java/org/mozilla/fenix/browser/tabstrip/TabCounterMenuItem.ktmobile/android/fenix/app/src/main/java/org/mozilla/fenix/components/metrics/AdjustMetricsService.ktmobile/android/fenix/app/src/main/java/org/mozilla/fenix/components/metrics/Event.ktmobile/android/fenix/app/src/main/java/org/mozilla/fenix/components/metrics/GrowthDataWorker.ktmobile/android/fenix/app/src/main/java/org/mozilla/fenix/components/metrics/MetricController.ktmobile/android/fenix/app/src/main/java/org/mozilla/fenix/components/metrics/MetricsMiddleware.ktmobile/android/fenix/app/src/main/java/org/mozilla/fenix/components/metrics/MetricsStorage.ktmobile/android/fenix/app/src/main/java/org/mozilla/fenix/components/toolbar/BrowserToolbarMiddleware.ktmobile/android/fenix/app/src/main/java/org/mozilla/fenix/customtabs/WebAppSiteControlsBuilder.ktmobile/android/fenix/app/src/main/java/org/mozilla/fenix/home/PocketMiddleware.ktmobile/android/fenix/app/src/main/java/org/mozilla/fenix/home/store/HomepageState.ktmobile/android/fenix/app/src/main/java/org/mozilla/fenix/home/toolbar/BrowserToolbarMiddleware.ktmobile/android/fenix/app/src/main/java/org/mozilla/fenix/home/ui/ExperimentalHomepageHeader.ktmobile/android/fenix/app/src/main/java/org/mozilla/fenix/home/ui/HomepageHeader.ktmobile/android/fenix/app/src/main/java/org/mozilla/fenix/home/ui/HomepagePillButton.ktmobile/android/fenix/app/src/main/java/org/mozilla/fenix/home/ui/MiddleSearchHomepage.ktmobile/android/fenix/app/src/main/java/org/mozilla/fenix/session/PrivateNotificationService.ktmobile/android/fenix/app/src/main/java/org/mozilla/fenix/telemetry/TelemetryMiddleware.ktmobile/android/fenix/app/src/main/java/org/mozilla/fenix/trackingprotection/TrackersBlockedFeature.ktmobile/android/fenix/app/src/main/res/layout/fragment_installed_add_on_details.xmlmobile/android/fenix/app/src/test/java/org/mozilla/fenix/browser/TranslationsBindingTest.ktmobile/android/fenix/app/src/test/java/org/mozilla/fenix/components/metrics/DefaultMetricsStorageTest.ktmobile/android/fenix/app/src/test/java/org/mozilla/fenix/components/metrics/InstallReferrerMetricsServiceTest.ktmobile/android/fenix/app/src/test/java/org/mozilla/fenix/components/toolbar/BrowserToolbarMiddlewareTest.ktmobile/android/fenix/app/src/test/java/org/mozilla/fenix/home/toolbar/BrowserToolbarMiddlewareTest.ktmobile/android/fenix/app/src/test/java/org/mozilla/fenix/telemetry/TelemetryMiddlewareTest.kttesting/web-platform/meta/css/css-conditional/container-queries/container-rule-cssom.html.initesting/web-platform/meta/dom/events/scrolling/scrollend-event-fired-after-instant-scroll-in-microtask.html.initesting/web-platform/mozilla/meta/webgpu/cts/webgpu/shader/execution/shader_io/compute_builtins/cts.https.html.initesting/web-platform/mozilla/meta/webgpu/cts/webgpu/shader/validation/extension/readonly_and_readwrite_storage_textures/cts.https.html.initesting/web-platform/mozilla/meta/webgpu/cts/webgpu/shader/validation/parse/requires/cts.https.html.initesting/web-platform/mozilla/meta/webgpu/cts/webgpu/shader/validation/shader_io/builtins/cts.https.html.initesting/web-platform/mozilla/tests/webgpu/webgpu/shader/execution/shader_io/compute_builtins.spec.jstesting/web-platform/mozilla/tests/webgpu/webgpu/shader/validation/extension/readonly_and_readwrite_storage_textures.spec.jstesting/web-platform/mozilla/tests/webgpu/webgpu/shader/validation/shader_io/builtins.spec.jstesting/web-platform/tests/css/css-conditional/container-queries/container-rule-cssom.htmltesting/web-platform/tests/dom/events/scrolling/scrollend-event-fired-after-instant-scroll-in-microtask.htmlthird_party/aom/third_party/googletest/src/googletest/cmake/internal_utils.cmakethird_party/aom/third_party/googletest/src/googletest/include/gtest/gtest-assertion-result.hthird_party/aom/third_party/googletest/src/googletest/include/gtest/gtest-death-test.hthird_party/aom/third_party/googletest/src/googletest/include/gtest/gtest-matchers.hthird_party/aom/third_party/googletest/src/googletest/include/gtest/gtest-message.hthird_party/aom/third_party/googletest/src/googletest/include/gtest/gtest-param-test.hthird_party/aom/third_party/googletest/src/googletest/include/gtest/gtest-printers.hthird_party/aom/third_party/googletest/src/googletest/include/gtest/gtest-spi.hthird_party/aom/third_party/googletest/src/googletest/include/gtest/gtest-test-part.hthird_party/aom/third_party/googletest/src/googletest/include/gtest/gtest-typed-test.hthird_party/aom/third_party/googletest/src/googletest/include/gtest/internal/custom/gtest-port.hthird_party/aom/third_party/googletest/src/googletest/include/gtest/internal/gtest-death-test-internal.hthird_party/aom/third_party/googletest/src/googletest/include/gtest/internal/gtest-filepath.hthird_party/aom/third_party/googletest/src/googletest/include/gtest/internal/gtest-internal.hthird_party/aom/third_party/googletest/src/googletest/include/gtest/internal/gtest-param-util.hthird_party/aom/third_party/googletest/src/googletest/include/gtest/internal/gtest-port-arch.hthird_party/aom/third_party/googletest/src/googletest/include/gtest/internal/gtest-port.hthird_party/aom/third_party/googletest/src/googletest/include/gtest/internal/gtest-string.hthird_party/aom/third_party/googletest/src/googletest/include/gtest/internal/gtest-type-util.hthird_party/aom/third_party/googletest/src/googletest/src/gtest-assertion-result.cctoolkit/components/antitracking/test/browser/browser_partitionkey_mediasourceurl.jstoolkit/components/messaging-system/schemas/SpecialMessageActionSchemas/test/browser/browser_sma_open_tab_in_splitview.jstoolkit/components/url-classifier/tests/unit/test_urlClassifierExceptionList.js |
