Differential D134238

Bug 1325637 removed browser.preferences.instantApply and its code r?jaws
AbandonedPublic
Actions

Authored by mpj.5 on Dec 19 2021, 7:48 AM.

Details

Reviewers

jaws

Gijs

Group Reviewers

Restricted Project

Bugzilla Bug ID

1325637

Diff Detail

Repository: rMOZILLACENTRAL mozilla-central
Branch: default

Event Timeline

mpj.5 created this revision.Dec 19 2021, 7:48 AM

Herald added a project: secure-revision. · View Herald TranscriptDec 19 2021, 7:48 AM

Harbormaster completed remote builds in B382899: Diff 521337.Dec 19 2021, 7:48 AM

phab-bot published this revision for review.Dec 19 2021, 7:48 AM

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".

phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".

phab-bot removed a project: secure-revision.

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 19 2021, 7:48 AM

mpj.5 added a reviewer: Gijs.Dec 19 2021, 7:51 AM

mpj.5 added a child revision: D134257: Bug 1742312 removed NPAPI related flags r?saschanaz.Dec 20 2021, 3:12 AM

Gijs requested changes to this revision.Dec 20 2021, 1:49 PM

Comment Actions

Thanks for working on this! I think in a number of cases, the removals are not quite right and need some more work. Feel free to ask questions in #fx-desktop-dev on Mozilla's matrix if anything is unclear! It's probably a good idea to make sure that after you re-run and , the preferences/settings page in Firefox still loads and works. :-)

browser/components/preferences/preferences.js
181	You need to keep this line, or the prefs won't load. :-)
browser/components/preferences/tests/browser_languages_subdialog.js
12	I suspect this test will now fail - did you try rebuilding and then running this test?
browser/components/preferences/tests/privacypane_tests_perwindow.js
382	This needs to keep the line, and the statement, but you can indeed remove the call.
toolkit/content/preferencesBindings.js
81–105	The result here is no longer valid JS. We should keep the getter on this object, but it should return if , and otherwise.
271–277	This should probably all stay.
405–408	We should keep this.
531–539	We should keep this too
toolkit/content/tests/chrome/test_preferences.xhtml
438–451	We should keep the test coverage here but stop writing the pref. I think we should remove the "non instant" tests below, and the functions those test, but ensure that the child window code covers the non-instant-apply case.
toolkit/content/tests/chrome/test_preferences_beforeaccept.xhtml
13–48	We'd need to change this test so it opens the dialog as a window.

This revision now requires changes to proceed.Dec 20 2021, 1:49 PM

Gijs removed a child revision: D134257: Bug 1742312 removed NPAPI related flags r?saschanaz.Dec 20 2021, 1:50 PM

mpj.5 marked 6 inline comments as done.Dec 20 2021, 11:45 PM

mpj.5 marked 2 inline comments as done.Dec 21 2021, 12:04 AM

mpj.5 added inline comments.

browser/components/preferences/tests/browser_languages_subdialog.js
12	Run failed - output: Unexpected Results browser/components/preferences/tests/browser_languages_subdialog.js FAIL The 'Request English' checkbox is checked. - Stack trace: chrome://mochikit/content/browser-test.js:test_ok:1375 chrome://mochitests/content/browser/browser/components/preferences/tests/browser_languages_subdialog.js:null:71 FAIL The privacy.spoof_english pref is set to 2. - Got +0, expected 2 Stack trace: chrome://mochikit/content/browser-test.js:test_is:1403 chrome://mochitests/content/browser/browser/components/preferences/tests/browser_languages_subdialog.js:null:75 FAIL The privacy.spoof_english pref is set to 1. - Got +0, expected 1 Stack trace: chrome://mochikit/content/browser-test.js:test_is:1403 chrome://mochitests/content/browser/browser/components/preferences/tests/browser_languages_subdialog.js:null:103