VOOZH about

URL: https://bugzilla.mozilla.org/show_bug.cgi?id=1325637

⇱ 1325637 - Remove browser.preferences.instantApply and its code

Closed Bug 1325637 Opened 9 years ago Closed 3 years ago

Remove browser.preferences.instantApply and its code

Remove browser.preferences.instantApply and its code
Toolkit
Preferences
unspecified
All
All
task
Points:
---
VERIFIED FIXED
VERIFIED
FIXED
103 Branch
Iteration:
---
a11y-review
Accessibility Severity
Performance Impact
Webcompat Priority
Webcompat Score
Tracking Status
firefox103 --- verified
Tracking Status
relnote-firefox
thunderbird_esr115
thunderbird_esr140
firefox-esr115
firefox-esr140
firefox-esr153
firefox103
firefox152
firefox153
firefox154
---
QA Whiteboard:
qa-not-actionable
Has STR:
---
Change Request:
---
Bug Flags:
Signature:
None
This bug is publicly visible. 

 












 
 

 

 
 
 
 
47 bytes,
 text/x-phabricator-request 

 		
 
 
 Details |
 Review
 

 

 
 
 
 
48 bytes,
 text/x-phabricator-request 

 		
 
 
 Details |
 Review
 

 

 
 
 
 
48 bytes,
 text/x-phabricator-request 

 		
 
 
 Details |
 Review
 





 
















Remove "browser.preferences.instantApply" preference from about:config and its code,
especially when patches from bug #1140495 and bug #738797 landed very long time ago and made "browser.preferences.instantApply" preference irrelevant in Options.
Has Regression Range: --- → irrelevant
Has STR: --- → irrelevant
The comm-central apps (IB, SM and TB) still use this pref.
Besides being vestigial, the pref causes openPrefsHelp in utilityOverlay.js to open help pages for the Fonts, Colors, Languages, Connections, and "Settings for Clearing History" subdialogs in a new window on Windows (because "prefwindows are usually modal"), even though those subdialogs are *not* modal, and the help pages could be opened in the same window.

This pref really should be removed, and openPrefsHelp should use a different mechanism to determine whether it is being called from a modal prefwindow (of which the only one remaining in Firefox is the Clear Recent History… dialog).
You would need to remove/update the following places:
https://searchfox.org/mozilla-central/search?q=instantapply&path=
Flags: needinfo?(jaws)
I want to work on this. Can you please assign it to me.

 

 

 
 
 
 
 
 

 

 
 

 Updated
 

 •
 
7 years ago
 

 		
 

 

 
Flags: needinfo?(jaws)
Please feel free to work on this. I will mark the bug assigned when a patch is uploaded for review. Please ask any questions you may have while working on the bug.
Flags: needinfo?(jaws)
Hi @Jaws Can i take this up?


Thanks


Flags: needinfo?(jaws)
(In reply to Shivam Singhal [ :championshuttler ] from comment #7)




Hi @Jaws Can i take this up?


Thanks




Please feel free to work on this. I will mark the bug assigned when a patch is uploaded for review. Please ask any questions you may have while working on the bug.


Flags: needinfo?(jaws)
Type: defect → task
Hello, May I submit a patch for this bug?


We are not determining if the function is being called from a model perfwindow anywhere https://searchfox.org/mozilla-central/search?q=openhelplink&case=false&regexp=false&path= . So should I just remove all cases of instantapply?


Flags: needinfo?(Virtual)
Assignee: nobody → gaurijove
Status: NEW → ASSIGNED
Flags: needinfo?(jaws)

 

 

 
 
 
 
 
 

 

 
 

 Updated
 

 •
 
4 years ago
 

 		
 

 

 
QA Whiteboard: qa-not-actionable
Clearing assignee, because we haven't heard from them since April 19 2020 in Phabricator.


Assignee: gaurijove → nobody
Status: ASSIGNED → NEW
Mentor: jaws, gijskruitbosch+bugs
Severity: major → N/A
Priority: -- → P3
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED

 Attachment #9141562 -
 Attachment is obsolete: true
Assignee: gijskruitbosch+bugs → nobody
Status: ASSIGNED → NEW
Assignee: nobody → mpj.5
Status: NEW → ASSIGNED

 Attachment #9256059 -
 Attachment is obsolete: true
This one has turned out to be beyond my abilities


Status: ASSIGNED → NEW
Assignee: mpj.5 → nobody
Assignee: nobody → mathew.hodson
Status: NEW → ASSIGNED

 

 

 
 
 
 Assignee
 
 
 

 

 
 

 Updated
 

 •
 
3 years ago
 

 		
 

 

 
Blocks: 1775386
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/309fa7dcf0ee
Remove browser.preferences.instantApply pref. r=Gijs,preferences-reviewers
See Also: → 1775474
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 103 Branch

 

 

 
 
 
 Assignee
 
 
 

 

 
 

 Updated
 

 •
 
3 years ago
 

 		
 

 

 
Product: Firefox → Toolkit
No longer blocks: 1188411

 

 

 
 
 
 Assignee
 
 
 

 

 
 

 Updated
 

 •
 
2 years ago
 

 		
 

 

 
Has STR: irrelevant → ---
Depends on: 1880616

 

 

 
 
 
 Assignee
 
 
 

 

 
 

 Updated
 

 •
 
2 years ago
 

 		
 

 

 
No longer depends on: 1880616

 You need to log in
 before you can comment on or make changes to this bug.