VOOZH about

URL: https://phabricator.services.mozilla.com/D193856

⇱ ⚙ D193856 Bug 1715158 - Remove traces of snippets from source documentation. r?pdahiya!


Bug 1715158 - Remove traces of snippets from source documentation. r?pdahiya!
ClosedPublic

Authored by mconley on Nov 16 2023, 10:37 PM.
Referenced Files
Unknown Object (File)
Mon, Jun 15, 3:22 PM
Unknown Object (File)
Mon, Jun 15, 11:35 AM
Unknown Object (File)
Mon, Jun 15, 9:07 AM
Unknown Object (File)
Mon, Jun 15, 4:37 AM
Unknown Object (File)
Sun, Jun 14, 9:17 PM
Unknown Object (File)
Sun, Jun 14, 8:03 PM
Unknown Object (File)
Sun, Jun 14, 7:17 PM
Unknown Object (File)
Sun, Jun 14, 4:25 PM

Event Timeline

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: secure-revision.
mconley edited the summary of this revision. (Show Details)
Comment Actions

Rebase, fix linting issues.

Comment Actions

Rebase, add patches for moving ASRouterAdmin out of about:newtab.

Comment Actions

Will be good to remove refrence of snippets in UserActions documnent page, should be safe to remove from this list as its removed with snippets

Comment Actions

And noticed a comment in BrowserGlue that can be updated to remove snippets reference and similar in talos here

Comment Actions

SpecialMessageActionSchemas refer to Snippets in its documentation, with feedback addressed LGTM! thanks

This revision is now accepted and ready to land.Dec 1 2023, 11:43 PM
Comment Actions

This revision requires a Testing Policy Project Tag to be set before landing. Please apply one of , , , , . Tip: this Firefox add-on makes it easy!

Comment Actions

Rebase, address review feedback, add patches for removing Enterprise Policy support for snippets, and some more lingering uses of the snippets prefs.

Comment Actions

Remove unused CSS to fix browser_parsable_css, update some SpecialMessageActions documentation, and get rid of more snippets references in the code.

This revision now requires review to proceed.Dec 5 2023, 3:55 PM
This revision is now accepted and ready to land.Dec 5 2023, 4:46 PM
Comment Actions

Rebase onto latest mozilla-central.

Comment Actions

You've pushed a patch that is making changes in areas of Performance Testing.

Please ensure that all the documentation related to this change is updated. Additionally, please ensure that documentation is added for any new features, workarounds, or enhancements.

You can find the existing documentation for Performance Testing here: https://firefox-source-docs.mozilla.org/testing/perfdocs/

Revision Contents

PathSizeCoverage (All)Coverage (Touched)
browser/
components/
4 lines80%
Loading...
newtab/
content-src/
asrouter/
13 lines--
docs/
30 lines--
7 lines--
schemas/
32 lines--
2 lines--
docs/
v2-system-addon/
6 lines--
47 lines--
testing/
perfdocs/
generated/
7 lines--
talos/
perfdocs/
7 lines--
toolkit/
components/
messaging-system/
schemas/
SpecialMessageActionSchemas/
90 lines--
CommitParentsAuthorSummaryDate
9ece676ff933Mike Conley
Bug 1715158 - Remove traces of snippets from source documentation. r=pdahiya… (Show More…)

Diff 795887

browser/components/BrowserGlue.sys.mjs

Loading...

browser/components/newtab/content-src/asrouter/README.md

Loading...

browser/components/newtab/content-src/asrouter/docs/debugging-docs.md

Loading...

browser/components/newtab/content-src/asrouter/docs/targeting-attributes.md

Loading...

browser/components/newtab/content-src/asrouter/schemas/message-format.md

Loading...

browser/components/newtab/content-src/asrouter/schemas/provider-response.schema.json

Loading...

browser/components/newtab/docs/v2-system-addon/data_dictionary.md

Loading...

browser/components/newtab/docs/v2-system-addon/data_events.md

Loading...

testing/perfdocs/generated/talos.rst

Loading...

testing/talos/perfdocs/index.rst

Loading...

toolkit/components/messaging-system/schemas/SpecialMessageActionSchemas/index.md

Loading...