Differential D193856
Bug 1715158 - Remove traces of snippets from source documentation. r?pdahiya! ClosedPublic Authored by mconley on Nov 16 2023, 10:37 PM. Referenced Files
Details
Summary Depends on D193855
Diff Detail
Event Timelinemconley created this revision.Nov 16 2023, 10:37 PM phab-bot published this revision for review.Nov 16 2023, 10:38 PM phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)". phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)". phab-bot removed a project: secure-revision. Comment Actions NOTE: 4 documentation files were modified in diff 787827
They can be previewed for one week: If you see a problem in this automated review, please report it here. mconley edited the summary of this revision. (Show Details) Comment ActionsRebase, fix linting issues. reviewbot added a comment.Nov 23 2023, 7:23 PM Comment ActionsNOTE: 4 documentation files were modified in diff 790565
They can be previewed for one week: If you see a problem in this automated review, please report it here. Comment Actions Rebase, add patches for moving ASRouterAdmin out of about:newtab. reviewbot added a comment.Nov 27 2023, 10:41 PM Comment ActionsNOTE: 4 documentation files were modified in diff 791593
They can be previewed for one week: If you see a problem in this automated review, please report it here. pdahiya added a comment.Nov 30 2023, 10:13 PM Comment ActionsWill be good to remove refrence of snippets in UserActions documnent page, should be safe to remove from this list as its removed with snippets pdahiya added a comment.EditedDec 1 2023, 9:37 PM Comment ActionsAnd noticed a comment in BrowserGlue that can be updated to remove snippets reference and similar in talos here pdahiya accepted this revision.Dec 1 2023, 11:43 PM Comment ActionsSpecialMessageActionSchemas refer to Snippets in its documentation, with feedback addressed LGTM! thanks This revision is now accepted and ready to land.Dec 1 2023, 11:43 PM Comment Actions This revision requires a Testing Policy Project Tag to be set before landing. Please apply one of , , , , . Tip: this Firefox add-on makes it easy! Comment Actions Rebase, address review feedback, add patches for removing Enterprise Policy support for snippets, and some more lingering uses of the snippets prefs. reviewbot added a comment.Dec 4 2023, 5:45 PM Comment ActionsNOTE: 4 documentation files were modified in diff 794751
They can be previewed for one week: If you see a problem in this automated review, please report it here. Comment Actions Remove unused CSS to fix browser_parsable_css, update some SpecialMessageActions documentation, and get rid of more snippets references in the code. This revision now requires review to proceed.Dec 5 2023, 3:55 PM reviewbot added a comment.Dec 5 2023, 4:19 PM Comment ActionsNOTE: 6 documentation files were modified in diff 795281
They can be previewed for one week: If you see a problem in this automated review, please report it here. sparky accepted this revision.Dec 5 2023, 4:46 PM This revision is now accepted and ready to land.Dec 5 2023, 4:46 PM Comment Actions Rebase onto latest mozilla-central. mconley edited projects, added testing-exception-unchanged (Doesn't change behavior for users); removed needs-testing-tag.Dec 6 2023, 4:07 PM Closed by commit rMOZILLACENTRAL9ece676ff933: Bug 1715158 - Remove traces of snippets from source documentation. r=pdahiya… (authored by mconley). · Explain WhyDec 6 2023, 4:24 PM This revision was automatically updated to reflect the committed changes. Comment Actions You've pushed a patch that is making changes in areas of Performance Testing. Please ensure that all the documentation related to this change is updated. Additionally, please ensure that documentation is added for any new features, workarounds, or enhancements. You can find the existing documentation for Performance Testing here: https://firefox-source-docs.mozilla.org/testing/perfdocs/
Revision Contents
Diff 795887 browser/components/newtab/content-src/asrouter/schemas/provider-response.schema.jsonLoading... toolkit/components/messaging-system/schemas/SpecialMessageActionSchemas/index.mdLoading... |
