Differential D249789
Bug 1967104 - Use image light-dark() for titlebar icons. r=#theme AbandonedPublic Authored by emilio on May 16 2025, 2:41 PM. Referenced Files
Details
Summary An alternative would be to use the [brighttext] attribute and duplicate the
Diff Detail
Event Timelineemilio created this revision.May 16 2025, 2:41 PM phab-bot published this revision for review.May 16 2025, 2:43 PM phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)". phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)". phab-bot removed a project: secure-revision. Herald added 1 blocking reviewer(s): desktop-theme-reviewers. · View Herald TranscriptMay 16 2025, 2:43 PM This revision is now accepted and ready to land.May 16 2025, 2:50 PM Comment Actions Code analysis found 1 defect in diff 1035670:
IMPORTANT: Found 1 defect (error level) that must be fixed before landing.
You can run this analysis locally with: If you see a problem in this automated review, please report it here. You can view these defects in the Diff Detail section of Phabricator diff 1035670. emilio retitled this revision from Bug 1966890 - Use image light-dark() for titlebar icons. r=#theme to Bug 1967104 - Use image light-dark() for titlebar icons. r=#theme. This revision was landed with ongoing or failed builds.May 17 2025, 10:48 PM Closed by commit rFIREFOXAUTOLAND5aefdfdb325c: Bug 1967104 - Use image light-dark() for titlebar icons. r=desktop-theme… (authored by emilio, committed by ealvarez@mozilla.com <ealvarez@mozilla.com>). · Explain Why This revision was automatically updated to reflect the committed changes. smolnar reopened this revision.Jun 4 2025, 6:08 PM This revision is now accepted and ready to land.Jun 4 2025, 6:08 PM emilio abandoned this revision.Jun 5 2025, 6:43 AM
Revision Contents
Diff 1035949 |
 |
VOOZH | about |