Support light-dark for images.

👁 Image	Emilio Cobos Álvarez [:emilio] Assignee
	Description • 1 year ago

No description provided.

👁 Image	Emilio Cobos Álvarez [:emilio] Assignee
	Comment 1 • 1 year ago

Remove the light-dark() pref while at it.

👁 Image	Phabricator Automation
	Updated • 1 year ago

👁 Image	Emilio Cobos Álvarez [:emilio] Assignee
	Comment 2 • 1 year ago

See https://github.com/w3c/csswg-drafts/issues/10577 for discussion on
this. I'm hoping this gets eventually standardized but if not we can
always undo this and use if() or what not once that's available.

For now add an internal WPT reftest.

👁 Image	Emilio Cobos Álvarez [:emilio] Assignee
	Comment 3 • 1 year ago

An alternative would be to use the [brighttext] attribute and duplicate the
rules, I guess, but this is a bit nicer.

👁 Image	Pulsebot
	Comment 4 • 1 year ago

Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/09eedd93d453 Factor out the light-dark() function. r=dshin

👁 Image	Pulsebot
	Comment 5 • 1 year ago

Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/925b932a2489 Expand light-dark() to support images. r=dshin

👁 Image	Pulsebot
	Comment 6 • 1 year ago

Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3ff313ac25e5 Use image light-dark() for titlebar icons. r=desktop-theme-reviewers,dao

👁 Image	Pulsebot
	Comment 7 • 1 year ago

Pushed by ctuns@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d25b77879b34 Fix some WError warnings.

👁 Image	Pulsebot
	Comment 8 • 1 year ago

Pushed by ctuns@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/24567e11c597 Hackily fix SpecifiedValueInfo to fix test_bug877690.html.

👁 Image	agoloman
	Comment 9 • 1 year ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/09eedd93d453
https://hg.mozilla.org/mozilla-central/rev/925b932a2489
https://hg.mozilla.org/mozilla-central/rev/3ff313ac25e5
https://hg.mozilla.org/mozilla-central/rev/d25b77879b34
https://hg.mozilla.org/mozilla-central/rev/24567e11c597

👁 Image	Richard Marti (:Paenglab)
	Updated • 1 year ago

👁 Image	Mathew Hodson
	Comment 10 • 1 year ago

pref removed: layout.css.light-dark.enabled

👁 Image	Brindusa Tot, DTE
	Updated • 1 year ago

👁 Image	Emilio Cobos Álvarez [:emilio] Assignee
	Updated • 1 year ago

👁 Image	Pulsebot
	Comment 11 • 1 year ago

Pushed by smolnar@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/dc1d1b61fecd https://hg.mozilla.org/integration/autoland/rev/143c604dcfaa Revert "Bug 1967104 - Use image light-dark() for titlebar icons. r=desktop-theme-reviewers,dao" for causing bug 1968922

👁 Image	Sandor Molnar[:smolnar]
	Comment 12 • 1 year ago

Backed out https://hg.mozilla.org/integration/autoland/rev/3ff313ac25e5 for causing Bug 1968922

Backout link: https://hg-edge.mozilla.org/integration/autoland/rev/143c604dcfaa80c34e92223078e4c8f341a480bd

👁 Image	Phabricator Automation
	Updated • 1 year ago

👁 Image	Pulsebot
	Comment 13 • 1 year ago

Pushed by dmeehan@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/463efcc82142 https://hg.mozilla.org/releases/mozilla-beta/rev/6c71d2edfd44 Revert "Bug 1967104 - Use image light-dark() for titlebar icons. r=desktop-theme-reviewers,dao" for causing bug 1968922

👁 Image	Alice0775 White
	Updated • 11 months ago

👁 Image	Emilio Cobos Álvarez [:emilio] Assignee
	Updated • 3 months ago