VOOZH about

URL: https://phabricator.services.mozilla.com/D284290

⇱ ⚙ D284290 Bug 2017049 - Part 2: Wire up ContentSearchUIController to ContentSearchHandoffUI component and revive handoff pref support. r?standard8!

Paths

Bug 2017049 - Part 2: Wire up ContentSearchUIController to ContentSearchHandoffUI component and revive handoff pref support. r?standard8!
ClosedPublic

Authored by mconley on Feb 20 2026, 4:45 PM.
Referenced Files
Unknown Object (File)
Fri, Jun 5, 10:28 AM
Unknown Object (File)
Fri, Jun 5, 2:09 AM
Unknown Object (File)
Fri, Jun 5, 2:09 AM
Unknown Object (File)
Fri, Jun 5, 12:28 AM
Unknown Object (File)
Thu, Jun 4, 10:13 PM
Unknown Object (File)
Mon, Jun 1, 5:41 PM
Unknown Object (File)
Apr 27 2026, 4:12 PM
Unknown Object (File)
Apr 26 2026, 9:18 AM
Subscribers
None

Details

Summary

Alongside adding the required integration between ContentSearchHandoffUI and
ContentSearchUIController, this also adds a pref-read to SearchUIUtils for the
external widget registrar for newtab to choose whether or not to use handoff
or non-handoff mode.

Probably the most notable absence in this wiring up is a complete lack of tests.

We've decided not to revive / modify our automated tests for this mode, mainly
due to the challenge of maintaining the test support for both cases while we
work on completely replacing this mechanism down the road. So we're relying
entirely on manual testing here, and the majority of the automated testing
is really just to ensure that the handoff mode hasn't regressed somehow
from this revival.

Diff Detail

Event Timeline

mconley created this revision.
phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".Feb 20 2026, 4:45 PM
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: secure-revision.
mconley updated this revision to Diff 1209410.
mconley retitled this revision from WIP: Bug 2017049 - Part 2: Wire up ContentSearchUIController to ContentSearchHandoffUI component and revive handoff pref support. r?standard8! to Bug 2017049 - Part 2: Wire up ContentSearchUIController to ContentSearchHandoffUI component and revive handoff pref support. r?standard8!.
mconley added a reviewer: Standard8.
browser/components/search/content/contentSearchHandoffUI.mjs
430–433

Whoops, let me go ahead and remove this dead code.

Comment Actions

Address aria-label and dead code issue in D284290.

Comment Actions

Thank you, this looks good, and seems to work as well as the previous.

testing-exception-other: Temporary revert of previously removed code. As this has been "injected" into the new tab page differently, this would require rework of the testing infrastructure. As this should be short term temporary, we have decided this is acceptable, and can be manually tested.

This revision is now accepted and ready to land.Feb 23 2026, 3:47 PM

Revision Contents

PathSize
browser/
app/
profile/
3 lines
components/
search/
18 lines
content/
111 lines
CommitTreeParentsAuthorSummaryDate
4b0bd10d5a6cc6e85f08b662Mike Conley
Bug 2017049 - Part 2: Wire up ContentSearchUIController to… (Show More…)

Diff 1210275

browser/app/profile/firefox.js

Loading...

browser/components/search/SearchUIUtils.sys.mjs

Loading...

browser/components/search/content/contentSearchHandoffUI.mjs

Loading...