remove dom.caches.enabled pref

👁 Image	Ben Kelly [:bkelly, not reviewing] Reporter
	Description • 10 years ago

After Caches API has been in release for a cycle or two we should remove dom.caches.enabled pref completely.

👁 Image	Marion Daly [:mdaly]
	Updated • 7 years ago

👁 Image	Nobody; OK to take it and work on it
	Updated • 7 years ago

👁 Image	Yaron Tausky [:ytausky]
	Updated • 6 years ago

👁 Image	Jens Stutte [:jstutte]
	Updated • 6 years ago

👁 Image	Alex
	Comment 1 • 6 years ago

Here's a good reason NOT to remove it:
https://github.com/Tampermonkey/tampermonkey/issues/773

👁 Image	Jens Stutte [:jstutte]
	Comment 2 • 6 years ago

(In reply to Alex from comment #1)

Here's a good reason NOT to remove it:
https://github.com/Tampermonkey/tampermonkey/issues/773

Hi Alex, if you suspect a bug in Firefox itself causing this issue, could you please file a new bug with clear STR for this specific problem here in bugzilla? Thank you!

👁 Image	Alex
	Comment 3 • 6 years ago

(In reply to Jens Stutte [:jstutte] from comment #2)

Hi Alex, if you suspect a bug in Firefox itself causing this issue, could you please file a new bug with clear STR for this specific problem here in bugzilla? Thank you!

Hello Jens,

I opened bug https://bugzilla.mozilla.org/show_bug.cgi?id=1643405 based on reports on TamperMonkey github.

That said, given my experience with the bug system (searching for solutions for problems I encountered with FF only to find out that those are bugs that have been reported seven years ago, for example: #866522 and #850906) I respectfully request that the existing workaround not be removed until the underlying issue is addressed.

Thank you,
Alex.

👁 Image	Jens Stutte [:jstutte]
	Updated • 6 years ago

👁 Image	Kagami Rosylight 🏳️‍🌈🏳️‍⚧️ [:saschanaz] (they/them)
	Comment 4 • 3 years ago

Hey Andrew, does this also fall into the emergency pref area? https://bugzilla.mozilla.org/show_bug.cgi?id=1488583#c0 removed the pref for IndexedDB arguing that cookies and site data permissions are sufficient, but it seems it's been replaced by ETP.

👁 Image	Andrew Sutherland [:asuth] (he/him)
	Comment 5 • 3 years ago

I think we can probably remove the cache API preference as the risk profile is low (and resembles that of IndexedDB's rationale in bug 1488583 although this pref hasn't caused crashes that I know of). I think we'll want to continue to have the service workers enabling pref, though, as its moving parts do have a higher risk profile (in the abstract). Thanks for proactively looking at this!

👁 Image	Kagami Rosylight 🏳️‍🌈🏳️‍⚧️ [:saschanaz] (they/them)
	Updated • 3 years ago

👁 Image	Kagami Rosylight 🏳️‍🌈🏳️‍⚧️ [:saschanaz] (they/them)
	Comment 6 • 3 years ago • Edited

Thanks! I just found this while looking at longstanding issues.

Edit: This one is simpler as it actually hides the relevant attributes/interfaces while the IndexedDB one did not.

👁 Image	Gregory Pappas [:gregp] Assignee
	Updated • 2 years ago

👁 Image	Gregory Pappas [:gregp] Assignee
	Comment 7 • 2 years ago

👁 Image	Phabricator Automation
	Updated • 2 years ago

👁 Image	Pulsebot
	Comment 8 • 2 years ago

Pushed by gp3033@protonmail.com: https://hg.mozilla.org/integration/autoland/rev/9db33f9464a6 Remove dom.caches.enabled pref r=webidl,devtools-reviewers,saschanaz,asuth

👁 Image	Iulian Moraru
	Comment 9 • 2 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/9db33f9464a6