VOOZH about

URL: https://bugzilla.mozilla.org/show_bug.cgi?id=1191418

⇱ 1191418 - (ContextualIdentity) [META] Contextual Identity / Containers Bugs

Open Bug 1191418 (ContextualIdentity) Opened 10 years ago Updated 4 months ago

[META] Contextual Identity / Containers Bugs

[META] Contextual Identity / Containers Bugs
Core
Security
unspecified
Unspecified
Unspecified
task
Points:
---
NEW
---
Iteration:
---
a11y-review
Accessibility Severity
Performance Impact
Size Estimate
Webcompat Priority
Webcompat Score
Tracking Status
relnote-firefox
thunderbird_esr115
thunderbird_esr140
firefox-esr115
firefox-esr140
firefox-esr153
firefox152
firefox153
firefox154
userContextId_Audit, 1245262, containers_testing, 1249348, 1253006, 1257456, 1271873, 1272043, 1273058, 1280549, 1281205, 1283495, 1284985, 1285423, 1285518, 1287001, 1291672, 1292241, 1293420, 1295750, 1297973, 1298064, 1302597, 1303911, 1308527, 1308682, 1315055, 1316301, 1317544, 1318352, 1320355, 1320368, 1320378, 1320757, 1321914, 1322387, 1325505, 1325874, 1328935, 1329453, 1331595, 1333214, 1333811, 1334722, 1337937, 1338735, 1339962, 1340861, 1351155, 1375598, 1393822, 1401488, 1428241, 1442346, 1450774, 1458709, 1468119, 1484717, 1485582, 1489502, 1511449, 1521443, 1521986, 1542985, 1555367, 1574766, 1586960, 1623424, 1638554, 1711037, 1726540, 1749962, 1806732, 1835372, 1968158, 1969746, 962365, 1146401, 1179557, 1179985, 1181953, 1191442, 1191451, 1191455, 1191460, 1191494, 1193854, 1195881, 1199466, 1199471, 1211716, createCodebasePrincipal, 1225363, 1233908, createCodebasePrincipalFromOrigin, 1234672, 1237364, 1238766, 1239420, 1240094, 1240243, 1240623, 1243265, 1244340, 1244795, 1244887, 1245124, 1245184, 1246907, 1247517, 1248251, 1248302, 1248639, 1249224, 1250033, 1253538, 1254103, 1257453, 1257455, 1259169, 1260535, 1260687, 1260766, 1264556, 1264562, 1264564, 1264571, 1266022, 1267538, 1267916, 1267920, 1267921, 1267922, 1267923, 1268276, 1268726, 1268803, 1269029, 1270423, 1270471, 1270678, 1270679, 1270680, 1270681, 1270683, 1271516, 1271792, 1272067, 1272256, 1272466, 1272754, 1273215, 1274211, 1274246, 1274461, 1274567, 1275432, 1275485, 1276412, 1276877, 1276880, 1276904, 1277765, 1278177, 1279029, 1279099, 1279103, 1279140, 1279143, 1279271, 1279297, 1279337, 1279568, 1279622, 1280006, 1280253, 1280333, 1280497, 1280590, 1280626, 1280863, 1282279, 1282589, 1282655, 1282660, 1283314, 1283319, 1283325, 1283377, 1283491, 1283709, 1285513, 1285515, 1285587, 1285677, 1285772, 1285853, 1285889, 1285901, 1286357, 1287765, 1287866, 1287879, 1288029, 1288057, 1289001, 1289130, 1289131, 1289571, 1289832, 1291521, 1291524, 1292989, 1294336, 1294786, 1294866, 1297738, 1299480, 1301430, 1301523, 1301617, 1302088, 1302157, 1302566, 1302697, 1303366, 1305280, 1305592, 1306975, 1308938, 1309067, 1309735, 1310112, 1310276, 1310601, 1311645, 1312253, 1312954, 1315156, 1315673, 1316283, 1316359, 1316727, 1316739, 1316740, 1316742, 1316744, 1316747, 1316919, 1317138, 1317182, 1317185, 1317317, 1317927, 1318491, 1319045, 1319346, 1319929, 1320041, 1322856, 1324115, 1324551, 1325014, 1325886, 1325902, 1326058, 1326087, 1327947, 1328246, 1328755, 1328756, 1329456, 1329643, 1330745, 1333253, 1333395, 1334013, 1334587, 1335678, 1335706, 1338505, 1339201, 1339610, 1340450, 1340993, 1342803, 1346653, 1347604, 1348771, 1349211, 1351893, 1352189, 1352345, 1353442, 1359232, 1362928, 1367250, 1368815, 1368942, 1369053, 1373822, 1376971, 1376973, 1386627, 1387430, 1387654, 1390003, 1392514, 1398229, 1401408, 1403243, 1405542, 1405888, 1406031, 1407209, 1408391, 1419591, 1422558, 1422888, 1439237, 1442350, 1443673, 1444895, 1456161, 1463365, 1479858, 1514791, 1538128, 1549204, 1554527, 1554567, 1555166, 1581872, 1604432, 1616137, 1620757, 1630365, 1634431, 1636187, 1661472, 1661951, 1663547, 1677947, 1707085, 1710534, 1718599, 1758921, 1800971, 1814969, 1846714, 1846754, 1896127, 1918044, 1987287
Dependency tree / graph
ContextualIdentity
QA Whiteboard:
---
Has STR:
---
Change Request:
---
Bug Flags:
Signature:
None
This bug is publicly visible. 

 












 
 

 

 
 
 
 
59 bytes,
 text/x-review-board-request 

 		
 
 
 Details
 





 
















The Contextual Identity Project (see: https://wiki.mozilla.org/Security/Contextual_Identity_Project/Containers) aims to add lightweight containers/profiles into the browser to give users the ability to segregate their local state (cookies, localStorage, etc) based on the context they are browsing in.

Example uses cases:
* User has multiple accounts on websites and wants to be logged into both simultaneously. One in a personal context, the other in a work context.
* User wants a session that persists but doesn't leak information to trackers about their browsing behavior in other contexts. (Ex: doesn't want the shopping context to affect the ads they see in their work context.
* A user wants to remain logged into a social network without being tracked across the web

This meta-bug is a collection of the related bugs supporting this project.
Depends on: 1191442
Depends on: 1191451
Depends on: 1191455
Depends on: 1191460
Depends on: 1191494
Depends on: 1193854
Depends on: 1195881
Depends on: 1199466
Depends on: 1199470
Depends on: 1199471
Alias: ContextualIdentity
Depends on: 1211716
How about setting usercontext on bookmarks?
Depends on: 1213290

 
 

 

 
 

 
 

 
 


 

 
 

 Comment 2
 

 •
 
10 years ago
 

 		
 


 
 


 
 
You can look at the https://getmultifox.com/ extension as example how this works - it provide per-tab select identity (cookie and session storage) for users.
But Multifox Firefox extension will stop working after Firefox remove XPCOM support, and seems there are no ways to provide this feature via new Firefox WebExtensions API, so build-in contextual identity will be useful feature!

 
 

 

 
 

 
 

 
 


 

 
 

 Comment 3
 

 •
 
10 years ago
 

 		
 


 
 


 
 
I see that "Image Cache" is not separated by this, but a lot of tracking is done with images. Wouldn't this leak info across contexts?
(In reply to donrhummy from comment #3)
> I see that "Image Cache" is not separated by this, but a lot of tracking is
> done with images. Wouldn't this leak info across contexts?

Image Cache should be separated in the same way Necko Cache is. Is that not the case it our current implementation? Huseby, can you check on this and file a bug if needed? This may be a Desktop only issue.
Flags: needinfo?(huseby)
Depends on: 1234672
I'll check it out.
Flags: needinfo?(huseby)
Depends on: 1240243
It seems like people are starting to look into implementing this. Exciting!

I think we need to handle many of the places in the code where we store data on disk related to the user's browsing. One example is cookies. It's probably a good idea to have a consistent model everywhere.

I think the right approach should be for the user context ID to be stored alongside the data (perhaps encoded in the origin string) and in code using the data read from the disk we should be careful to not read another user's data, nor modify/delete them. This basically gives us a solid virtual per-user-context-ID container for the stored data.

Finding all of the necessary call sites to audit and handle can be daunting. I think a good starting point would be places where we check the private browsing mode, since a lot of them map to code that wants to store something about the user's browsing to disk, so that should find many of the places we need to fix, and we have covered almost all of those places over the years.

Not sure how much this matches the current thinking, and/or who to direct this too. Andrea, do you know? Thanks!
Flags: needinfo?(amarchesini)
> Not sure how much this matches the current thinking, and/or who to direct
> this too. Andrea, do you know? Thanks!

Absolutely. We are doing that using OriginAttributes everywhere. It's a big task but it has been almost fully done.
There are plenty dependences here and many depending bugs are metabugs: bug 1197283, 1153435, etc.
Cookies, localStorage, IDB, quota, all of this is already fully managed and it works.
If you are interested or you have specific questions, we have a weekly meeting on Wednesday.
I'll ping you tomorrow on IRC to tell you more :)
Flags: needinfo?(amarchesini)
No longer depends on: 1245184
Depends on: 1245184

 

 

 
 
 
 
 
 

 

 
 

 Updated
 

 •
 
10 years ago
 

 		
 

 

 
Keywords: feature, 
 
 meta
Depends on: 1264556
Depends on: 1264562
Depends on: 1268726
Depends on: 1264571
Depends on: 1264564
Depends on: 1269029
Depends on: 1146401
Depends on: 1270423
Depends on: 962365
Blocks: 962374
Depends on: 1268803
Depends on: 1270678
Depends on: 1270679
Depends on: 1270680
Depends on: 1270681
Depends on: 1270683
Depends on: 1275432

 
 

 

 
 

 
 

 
 


 

 
 

 Comment 8
 

 •
 
10 years ago
 

 		
 


 
 


 
 
Is there some documentation for addon developers? The container concept is awesome, but the default UI for containers does not reflect how I would like to use it.
Depends on: 1276412
(In reply to The 8472 from comment #8)
> Is there some documentation for addon developers? The container concept is
> awesome, but the default UI for containers does not reflect how I would like
> to use it.

We don't have much documentation yet, just https://wiki.mozilla.org/Security/Contextual_Identity_Project/Containers. If you are looking for something like Containers with different UI, you probably want documentation about OriginAttributes. But OriginAttributes are fairly new, so I'm not sure there is documentation on that yet either.

What would you like to do in your addon?
Flags: needinfo?(bugzilla.mozilla.org)

 
 

 

 
 

 
 

 
 


 

 
 

 Comment 10
 

 •
 
10 years ago
 

 		
 


 
 


 
 
(In reply to Tanvi Vyas - behind on reviews [:tanvi] from comment #9)
> What would you like to do in your addon?

a) ability to dynamically create or destroy new containers
b) assign the container on tab navigation / opening tabs
c) assign a different container to sandboxed iframes

The idea is to automatically compartmentalize things based on origin wherever reasonable.

Let's say I have the following tabs open + embedded 3rd-party content:

- a forum, turns posted links to youtube into embeds
- a blog, requires recaptcha for anonymous comments
- Youtube
- Gmail
- Google


Google, Youtube, Gmail shouldn't have to share logins or cookies even though they all load stuff from google. And since I don't want to make a conscious effort of opening google or youtube videos in the "correct" container it should determine that based on the page URL.

For the YT embed iframes I would like to choose whether they load with an anonymous container (spawned and destroyed on demand) or with my YT account.

And recaptcha needs to build some reputation if you don't want to get those terrible inkblots, so you can't just block cookies, but it doesn't need to associate my blog comment activity with my google account. Or with other sites also using recaptcha for that matter.
Flags: needinfo?(bugzilla.mozilla.org)
Depends on: 1277570
No longer depends on: 1277570
Depends on: 1279029
Depends on: 1278177
Depends on: 1279337
Depends on: 1279103
Depends on: 1280253

 

 

 
 
 
 
 
 

 

 
 

 Updated
 

 •
 
10 years ago
 

 		
 

 

 
Depends on: 1280333
Depends on: 1280590
Feature Request:
One useful feature would be to have the option to have a window be "sticky" about the context it's using, so that new tabs would automatically use a given context. I know that links from tabs in a given context stay within that context, but opening up new tabs (using the "+" or the keyboard shortcuts) open in the original, default context.
Depends on: 1282655
Depends on: 1282660
Depends on: 1283314
Depends on: 1283319
Depends on: 1283320
Depends on: 1283325
Depends on: 1280549
Depends on: 1283491
Depends on: 1283495
Depends on: 1280697
(In reply to JR Conlin [:jrconlin,:jconlin] from comment #11)
> One useful feature would be to have the option to have a window be "sticky"
> about the context it's using, so that new tabs would automatically use a
> given context.

I.e., a re-implementation of profiles, but without the separation of UI that profiles provide. If this is going to be the way of the future, I'd at least like to see the ability to separate bookmarks as well - when I go into work mode, I want to streamline away all the personal bookmarks I have and concentrate on those that are relevant to the work I'm doing. I use profiles and the bookmarks toolbar extensively to be able to get to common tasks quickly in whichever context I'm working. As I work for three different companies in addition to my freelancing and personal stuff, I consider profiles to be a much better solution, but if they're going away (bug #214675) Containers had better allow me to concentrate on one context at once instead of mixing them.
(In reply to Iain Hallam from comment #12)
> (In reply to JR Conlin [:jrconlin,:jconlin] from comment #11)
> > One useful feature would be to have the option to have a window be "sticky"
> > about the context it's using, so that new tabs would automatically use a
> > given context.
> 
> I.e., a re-implementation of profiles, but without the separation of UI that
> profiles provide. If this is going to be the way of the future, I'd at least
> like to see the ability to separate bookmarks as well - when I go into work
> mode, I want to streamline away all the personal bookmarks I have and
> concentrate on those that are relevant to the work I'm doing. I use profiles
> and the bookmarks toolbar extensively to be able to get to common tasks
> quickly in whichever context I'm working. As I work for three different
> companies in addition to my freelancing and personal stuff, I consider
> profiles to be a much better solution, but if they're going away (bug
> #214675) Containers had better allow me to concentrate on one context at
> once instead of mixing them.

Containers are not meant to replace profiles. Profiles are great and have their own set of uses cases. Containers is for a different use case, where a separate profile feels to heavy weight for the task at hand.
Depends on: 1285677
Depends on: 1285889
Depends on: 1287001
Depends on: 1288504
Depends on: 1288858
Depends on: 1289130
Depends on: 1289131
No longer depends on: 1280590
Depends on: 1294336
Depends on: 1294866
No longer depends on: 1297477
No longer blocks: 962374
No longer blocks: 1301617
Depends on: 1301617
Depends on: 1302566
Depends on: 1302697
Depends on: 1302157
Depends on: 1302597
Depends on: 1280590
Depends on: 1309067
Depends on: 1316283
Depends on: 1316359
Depends on: 1317927

 
 

 

 
 

 
 

 
 


 

 
 

 Comment 14
 

 •
 
9 years ago
 

 		
 


 
 


 
 
Containers works very well on Firefox 52 and 53 versions and very useful, thanks for this improvement! I fully switched to it from Multifox extension, and will be glad to see on stable versions.

But I miss feature to change container of already opened tab - this is unavailable in tab context menu, and via click on container icon in Location bar too :(

Please add switching container for current opened page in tab to Right-click menu on tab and to click on container icon in Location bar. Thanks!
Depends on: 1318352
No longer depends on: 1320376

 
 

 

 
 

 
 

 
 


 

 
 

 Comment 15
 

 •
 
9 years ago
 

 		
 


 
 


 
 
Also "Open in Container tab" menuitem missed on bookmark items, please add in this place too.
Depends on: 1321914

 

 

 
 
 
 
 
 

 

 
 

 Updated
 

 •
 
9 years ago
 

 		
 

 

 
Depends on: 1323873

 

 

 
 
 
 
 
 

 

 
 

 Updated
 

 •
 
9 years ago
 

 		
 

 

 
Depends on: 1325014
Depends on: 1312954
Depends on: 1324115
(In reply to Murz from comment #14)
> Containers works very well on Firefox 52 and 53 versions and very useful,
> thanks for this improvement! I fully switched to it from Multifox extension,
> and will be glad to see on stable versions.
> 
> But I miss feature to change container of already opened tab - this is
> unavailable in tab context menu, and via click on container icon in Location
> bar too :(
> 
> Please add switching container for current opened page in tab to Right-click
> menu on tab and to click on container icon in Location bar. Thanks!

I agree. The main usability issue with Containers right now is that there is currently no way to change the context of the current tab, which is supported in other implementations (Multifox, etc.)
Depends on: 1328756
Depends on: 1329411
Depends on: 1329453
Depends on: 1329456
Depends on: 1329643

 

 

 
 
 
 
 
 

 

 
 

 Updated
 

 •
 
9 years ago
 

 		
 

 

 
Depends on: 1331595
Depends on: 1334013

 
 

 

 
 

 
 

 
 


 

 
 

 Comment 17
 

 •
 
9 years ago
 

 		
 


 
 


 
 
Developers, can you provide example how we can change Container for current tab in custom script/extension via WebExtensions API or other way? Thanks
https://github.com/mdn/webextensions-examples/tree/master/contextual-identities << you can reload tab using cookieStoreId prop.
https://blog.mozilla.org/addons/2016/11/18/webextensions-in-firefox-52/

Btw, browser.contextualIdentities and browser.devtools API is still missing on https://developer.mozilla.org/en-US/Add-ons/WebExtensions, any new or experimental API should be listed there, if not a complete description of it (because they are still creating), at least with links to some other place with partial description.
Depends on: 1338505

 

 

 
 
 
 
 
 

 

 
 

 Updated
 

 •
 
9 years ago
 

 		
 

 

 
Depends on: 1360614
See Also: → 1299577
No longer depends on: 1365512
Depends on: 1325884
Depends on: 1240623
Depends on: 1273058
Depends on: 1293420
Depends on: 1309735
Depends on: 1401408
Depends on: 1401488

 

 

 
 
 
 
 
 

 

 
 

 Updated
 

 •
 
8 years ago
 

 		
 

 

 
Depends on: 1405888

 
 

 
 

 

 
 Comment hidden (mozreview-request)
 
 
 

 

 


 

 Attachment #8915986 -
 Flags: review?(gijskruitbosch+bugs)

 Attachment #8915986 -
 Flags: review?(amarchesini)

 Attachment #8915986 -
 Flags: review?(gijskruitbosch+bugs)

 Attachment #8915986 -
 Flags: review?(amarchesini)

 Attachment #8915986 -
 Attachment is obsolete: true
Depends on: 1419589
Depends on: 1419591
Depends on: 1425124
Depends on: 1442346

 

 

 
 
 
 
 
 

 

 
 

 Updated
 

 •
 
8 years ago
 

 		
 

 

 
Depends on: 1386673
Depends on: 1450774
Depends on: 1439237
Depends on: 1454188
Depends on: 1443673
Depends on: 1485582

 

 

 
 
 
 
 
 

 

 
 

 Updated
 

 •
 
7 years ago
 

 		
 

 

 
Depends on: 1489502
Depends on: 1502167
Depends on: 1511449

 

 

 
 
 
 
 
 

 

 
 

 Updated
 

 •
 
7 years ago
 

 		
 

 

 
Depends on: 1512802
Depends on: 1521986

 

 

 
 
 
 
 
 

 

 
 

 Updated
 

 •
 
7 years ago
 

 		
 

 

 
Depends on: 1524959
Depends on: 1545950
Type: defect → task
Depends on: 1554527
Depends on: 1554567
Depends on: 1555166
Depends on: 1555367
See Also: → 1509350
Depends on: 1560580
Depends on: 1538128
Depends on: 1574766
Depends on: 1479858
No longer blocks: 1545307
Depends on: 1545307
No longer blocks: 1604432
Depends on: 1604432
Depends on: 1616137
Depends on: 1620757
Depends on: 1631433
Depends on: 1634119
Depends on: 1634431
Depends on: 1636187
Depends on: 1638554
Depends on: 1642651
Depends on: 1636987
Depends on: 1656149
Depends on: 1656776
Depends on: 1661951
Depends on: 1663547
Depends on: 1677947

 

 

 
 
 
 
 
 

 

 
 

 Updated
 

 •
 
4 years ago
 

 		
 

 

 
Depends on: 1726540
Hi! I really like the multi container tabs, I use it everyday.


There is just one feature which me and other would really like to be implemented. I'm talking about enabling a default container, as for now, when you do CTRL+T aka new tab event, it opens in a default container, or, if I understand correctly from the source code, an internal container which is called "no container".


This is quite annoying in a daily basis because I use containers for everything, the "no container" container is useless for me.


I really want to implement a default container because this feature change seems quite straight forward, as the mock-up code below:


onNewTab((url) -> {
 if (!hasAssignedContainer(url)) {
 const defaultContainer = getDefaultContainer();
 openInContainer(defaultContainer, url);
 }
 ...
});



This would require to expose a method for setDefaultContainer and getDefaultContainer in the containers API for extensions.


So, this is basically the second time I contribute with the Mozilla Firefox ecosystem and I have a bunch of questions regarding where to start this implementation. Things like "where is the new tab handler for assigned URL's" would be very helpful to me.


Mateus, I suggest you create a new bug for your suggestion and mark it as a blocker for this one.


I wish you a Happy New Year!


Sebastian


Depends on: 1758921
Severity: normal → S3
Depends on: 1731313
Depends on: 1800971
Depends on: 1806732
Depends on: 1711037
Depends on: 1810538
Depends on: 1813350
Depends on: 1814542
Depends on: 1814969
Depends on: 1823065
Depends on: 1504782
Depends on: 1646985
Depends on: 1846754
Depends on: 1846714
Depends on: 1707085
Depends on: 1865404
Depends on: 1835372
Depends on: 1896127

 

 

 
 
 
 
 
 

 

 
 

 Updated
 

 •
 
1 year ago
 

 		
 

 

 
Depends on: 1918044
Depends on: 1969746

 

 

 
 
 
 
 
 

 

 
 

 Updated
 

 •
 
9 months ago
 

 		
 

 

 
Depends on: 1987287
Depends on: 2007881
Depends on: 1968158

 You need to log in
 before you can comment on or make changes to this bug.