Toggle the pref to disable @-moz-document in content pages on release

👁 Image	Emilio Cobos Álvarez [:emilio] Reporter
	Description • 8 years ago

+++ This bug was initially created as a clone of Bug #1035091 +++ Bug 1035091 landed the code on early Beta and Nightly. We should switch the pref in this one.

👁 Image	Jet Villegas (inactive)
	Updated • 8 years ago

👁 Image	Jet Villegas (inactive)
	Updated • 8 years ago

👁 Image	Tom Ritter [:tjr] Assignee
	Comment 1 • 8 years ago
mozreview-request

Comment hidden (mozreview-request)

Previously we had disabled them in content pages on Nightly and Early Beta, now we're ready to let this ride the trains in 61. Review commit: https://reviewboard.mozilla.org/r/228778/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/228778/

👁 Image	Emilio Cobos Álvarez [:emilio] Reporter
	Comment 2 • 8 years ago
mozreview-review

Comment on attachment 8959997 [details] Bug 1422245 Disable @-moz-document in content pages https://reviewboard.mozilla.org/r/228778/#review234480 Hah, so... This is fine I suppose. There's still some breakage from it (most notably Youtube comments, bug 1426068), and all of them were using `@-moz-document url-prefix()` for that, so I think we should still parse it on content pages. Curiously I filed bug 1446470 on that 2 days ago, and that includes this patch. Let's land this for now, I'll rebase my patches on top. Maybe mention that bug on the commit message? Thanks!

👁 Image	Emilio Cobos Álvarez [:emilio] Reporter
	Comment 3 • 8 years ago

(Or we can land this after those patches, and I'll remove part 3 on that bug, your call).

👁 Image	Tom Ritter [:tjr] Assignee
	Updated • 8 years ago

👁 Image	Tom Ritter [:tjr] Assignee
	Comment 4 • 8 years ago
mozreview-request

Comment hidden (mozreview-request)

Comment on attachment 8959997 [details] Bug 1422245 Disable @-moz-document in content pages Review request updated; see interdiff: https://reviewboard.mozilla.org/r/228778/diff/1-2/

👁 Image	Tom Ritter [:tjr] Assignee
	Updated • 8 years ago

👁 Image	Kohei Yoshino [:kohei]
	Comment 5 • 8 years ago

Posted the site compatibility note: https://www.fxsitecompat.com/en-CA/docs/2018/moz-document-has-been-dropped/

👁 Image	Emilio Cobos Álvarez [:emilio] Reporter
	Comment 6 • 8 years ago

(In reply to Kohei Yoshino [:kohei] from comment #5) > Posted the site compatibility note: > https://www.fxsitecompat.com/en-CA/docs/2018/moz-document-has-been-dropped/ Beware of bug 1446470, which will fix all the known breakages so far too, and is intended to land in time for the same firefox release. That bug means that @-moz-document url-prefix() { } will keep working.

👁 Image	Kohei Yoshino [:kohei]
	Comment 7 • 8 years ago

So no security issues will be solved here? This bug can be simply WONTFIXed then... :(

👁 Image	Emilio Cobos Álvarez [:emilio] Reporter
	Comment 8 • 8 years ago

Wait, what? Yes. The security issue is with other url matching functions, like regex(..), which this patch forbids. We'll just allow an empty url-prefix to avoid breaking websites.

👁 Image	Kohei Yoshino [:kohei]
	Comment 9 • 8 years ago

Thanks for the clarification. Updating the note accordingly.

👁 Image	Pulsebot
	Comment 10 • 8 years ago

Pushed by rgurzau@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a83ccbf8a6b6 Disable @-moz-document in content pages r=emilio

👁 Image	Xidorn Quan [:xidorn] UTC+10
	Comment 11 • 8 years ago

(In reply to Emilio Cobos Álvarez [:emilio] from comment #6) > (In reply to Kohei Yoshino [:kohei] from comment #5) > > Posted the site compatibility note: > > https://www.fxsitecompat.com/en-CA/docs/2018/moz-document-has-been-dropped/ > > Beware of bug 1446470, which will fix all the known breakages so far too, > and is intended to land in time for the same firefox release. > > That bug means that @-moz-document url-prefix() { } will keep working. We should probably post an update to the Intent to unship thread in dev-platform about this plan as well.

👁 Image	Arthur Iakab [arthur_iakab]
	Comment 12 • 8 years ago
bugherder

👁 Image	Will Bamberg [:wbamberg]
	Comment 13 • 8 years ago

I've updated the compat data to capture this: https://developer.mozilla.org/en-US/docs/Web/CSS/@document#Browser_compatibility Marking dev-doc-complete, but please comment if we need anything else.

👁 Image	Chris Mills [:cmills]
	Comment 14 • 8 years ago

(In reply to Will Bamberg [:wbamberg] from comment #13) > I've updated the compat data to capture this: > https://developer.mozilla.org/en-US/docs/Web/CSS/ > @document#Browser_compatibility > > Marking dev-doc-complete, but please comment if we need anything else. I also added a rel note: https://developer.mozilla.org/en-US/Firefox/Releases/61#CSS

👁 Image	Al Billings [:abillings - ex-MoCo]
	Updated • 7 years ago